Skip to content

fix: add first param titles to logs where missing - #7533

Merged
wraithgar merged 1 commit into
latestfrom
lk/log-titles
May 15, 2024
Merged

fix: add first param titles to logs where missing#7533
wraithgar merged 1 commit into
latestfrom
lk/log-titles

Conversation

@lukekarrys

@lukekarryslukekarrys commented May 15, 2024

Copy link
Copy Markdown
Contributor

The first argument to all log.method() calls gets formatted differently with a color. So calls to these should always be a short descriptive title or an empty string.

@lukekarrys
lukekarrys requested a review from a team as a code ownerMay 15, 2024 19:01
@npm-cli-bot

npm-cli-bot commented May 15, 2024

Copy link
Copy Markdown
Collaborator

found 1 benchmarks with statistically significant performance regressions

  • app-large: cache-only:peer-deps
timing results
app-largecleanlock-onlycache-onlymodules-onlyno-lockno-cacheno-modulesno-cleanshow-versionrun-scriptcache-only
peer-deps
no-clean
audit
npm@latest34.127 ±0.9711.022 ±0.4312.259 ±0.121.621 ±0.011.590 ±0.031.320 ±0.008.325 ±0.131.285 ±0.010.138 ±0.000.165 ±0.0013.905 ±0.063.549 ±2.11
#753333.327 ±0.9810.852 ±0.0312.110 ±0.141.640 ±0.031.594 ±0.001.319 ±0.008.444 ±0.121.332 ±0.020.143 ±0.000.169 ±0.0015.653 ±0.422.186 ±0.01
app-mediumcleanlock-onlycache-onlymodules-onlyno-lockno-cacheno-modulesno-cleanshow-versionrun-scriptcache-only
peer-deps
no-clean
audit
npm@latest26.306 ±1.207.959 ±0.008.931 ±0.041.548 ±0.031.534 ±0.031.428 ±0.015.858 ±0.031.360 ±0.010.141 ±0.000.171 ±0.009.784 ±0.173.122 ±1.66
#753326.914 ±0.578.284 ±0.049.276 ±0.051.587 ±0.011.542 ±0.021.487 ±0.076.046 ±0.031.315 ±0.010.139 ±0.000.167 ±0.0010.290 ±0.382.089 ±0.13

@wraithgar
wraithgar merged commit 12f103c into latestMay 15, 2024
@wraithgar
wraithgar deleted the lk/log-titles branch May 15, 2024 19:38
@github-actionsgithub-actionsBot mentioned this pull request May 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@npm-cli-bot@wraithgar