Uh oh!
There was an error while loading. Please reload this page.
fix: allows graceful shutdown without misleading messaging - #8523
Closed
owlstronaut wants to merge 1 commit into
Closed
fix: allows graceful shutdown without misleading messaging#8523owlstronaut wants to merge 1 commit into
owlstronaut wants to merge 1 commit into
Conversation
owlstronaut
marked this pull request as ready for review
August 22, 2025 18:19
owlstronautforce-pushed
the
exit-handler-messaging
branch
from
August 22, 2025 18:39
353fac4 to
03d3ee7Compare
owlstronautforce-pushed
the
exit-handler-messaging
branch
from
August 22, 2025 19:38
03d3ee7 to
0da9c2bCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8429
@wraithgar I think I over thought this before, and caused those side effects. It seems to me that the correct thing to do is revert that change and instead have proper messaging - these signals will be expected in container environments, and instead of saying there is a problem with npm itself, we just inform why it is exiting (the container signal). I think the messaging was misleading, not the behavior.