fix: --dry-run with --json output by greggman · Pull Request #8567 · npm/cli

greggman · 2025-09-14T21:09:49Z

This broke in 10.4. Before 10.4 npm install --dry-run --json would return JSON. After 10.4 it no longer returns JSON.

c209e98#r165769221

Note: This is the smallest change and I didn't update any tests. Nor was I sure where to one. The fact that it broke means there was no test for this before.

If it was up to me I think I'd add a summary.diff = [] and push the diffs on there. And then only at the end where it outputs summary, if you want diff output to stdout then map over summary.diff. That would put the checks for output in a single place.

References

Fixeds #8565

This broke in 10.4 npm@c209e98#r165769221

wraithgar · 2025-09-15T15:53:57Z

Yeah we'll definitely want a regression test for this in test/lib/utils/reify-output.js. There are two tests there already for dry-run and long you can use as a base for this new test.

greggman · 2025-09-15T22:32:21Z

you assigned this to yourself. does that mean you're planning to fix it? Or, should I put up a PR with tests?

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop and have it print from the summary object? it could either print summary.added, summary.removed, etc, or it could add a summary.diff array. I only suggested the diff array because it keeps order. If order is not important than printing from existing data at the end seems like a good idea?

wraithgar · 2025-09-16T17:03:02Z

you assigned this to yourself

This is a signal to the rest of the team that I'm reviewing the PR.

wraithgar · 2025-09-16T17:05:16Z

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop

I think this is a good iteration and it should be a separate PR. This quick fix for parsing opts should be easier to land since it's just one missing conditional and a test, leaving the optimization for a different PR.

## Summary - stop Arborist from saving `node_modules/.package-lock.json` during dry-run reification - add a regression that keeps both `package-lock.json` and the hidden lockfile unchanged after `update: true, dryRun: true` This addresses the dry-run lockfile mutation part of #9187. The JSON output behavior is separate and already has #8567 open. ## Testing - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry-run update does not save lockfiles'` - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry run, do not get anything wet|save complete lockfile on update-all'` - `../../node_modules/.bin/eslint lib/arborist/reify.js test/arborist/reify.js` - `git diff --check` Co-authored-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>

## Summary - suppress human-readable reify diff lines when JSON output is requested - preserve detailed diff output for non-JSON `--dry-run` and `--long` commands - cover both `--dry-run --json` and `--long --json` ## Background Detailed dry-run diff output was introduced in npm 10.4.0 by #7133 without accounting for JSON mode. The structured JSON summary already contains the add, remove, and change details, so the extra text is redundant and makes stdout invalid JSON. Related to #8567, with the regression coverage requested during review. ## Testing - `tap --no-coverage --no-check-coverage test/lib/utils/reify-output.js` - `eslint lib/utils/reify-output.js test/lib/utils/reify-output.js` Fixes#8565 Copilot-Session: 48e629f8-eb5a-467c-970b-feb313628c00

VariableVince · 2026-08-26T11:33:46Z

Seems to have been superseeded by #9823

greggman · 2025-09-14T21:09:49Z

This broke in 10.4. Before 10.4 npm install --dry-run --json would return JSON. After 10.4 it no longer returns JSON.

c209e98#r165769221

Note: This is the smallest change and I didn't update any tests. Nor was I sure where to one. The fact that it broke means there was no test for this before.

If it was up to me I think I'd add a summary.diff = [] and push the diffs on there. And then only at the end where it outputs summary, if you want diff output to stdout then map over summary.diff. That would put the checks for output in a single place.

References

Fixeds #8565

This broke in 10.4 npm@c209e98#r165769221

wraithgar · 2025-09-15T15:53:57Z

Yeah we'll definitely want a regression test for this in test/lib/utils/reify-output.js. There are two tests there already for dry-run and long you can use as a base for this new test.

greggman · 2025-09-15T22:32:21Z

you assigned this to yourself. does that mean you're planning to fix it? Or, should I put up a PR with tests?

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop and have it print from the summary object? it could either print summary.added, summary.removed, etc, or it could add a summary.diff array. I only suggested the diff array because it keeps order. If order is not important than printing from existing data at the end seems like a good idea?

wraithgar · 2025-09-16T17:03:02Z

you assigned this to yourself

This is a signal to the rest of the team that I'm reviewing the PR.

wraithgar · 2025-09-16T17:05:16Z

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop

I think this is a good iteration and it should be a separate PR. This quick fix for parsing opts should be easier to land since it's just one missing conditional and a test, leaving the optimization for a different PR.

## Summary - stop Arborist from saving `node_modules/.package-lock.json` during dry-run reification - add a regression that keeps both `package-lock.json` and the hidden lockfile unchanged after `update: true, dryRun: true` This addresses the dry-run lockfile mutation part of #9187. The JSON output behavior is separate and already has #8567 open. ## Testing - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry-run update does not save lockfiles'` - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry run, do not get anything wet|save complete lockfile on update-all'` - `../../node_modules/.bin/eslint lib/arborist/reify.js test/arborist/reify.js` - `git diff --check` Co-authored-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>

## Summary - suppress human-readable reify diff lines when JSON output is requested - preserve detailed diff output for non-JSON `--dry-run` and `--long` commands - cover both `--dry-run --json` and `--long --json` ## Background Detailed dry-run diff output was introduced in npm 10.4.0 by #7133 without accounting for JSON mode. The structured JSON summary already contains the add, remove, and change details, so the extra text is redundant and makes stdout invalid JSON. Related to #8567, with the regression coverage requested during review. ## Testing - `tap --no-coverage --no-check-coverage test/lib/utils/reify-output.js` - `eslint lib/utils/reify-output.js test/lib/utils/reify-output.js` Fixes#8565 Copilot-Session: 48e629f8-eb5a-467c-970b-feb313628c00

VariableVince · 2026-08-26T11:33:46Z

Seems to have been superseeded by #9823

greggman · 2025-09-14T21:09:49Z

This broke in 10.4. Before 10.4 npm install --dry-run --json would return JSON. After 10.4 it no longer returns JSON.

c209e98#r165769221

Note: This is the smallest change and I didn't update any tests. Nor was I sure where to one. The fact that it broke means there was no test for this before.

If it was up to me I think I'd add a summary.diff = [] and push the diffs on there. And then only at the end where it outputs summary, if you want diff output to stdout then map over summary.diff. That would put the checks for output in a single place.

References

Fixeds #8565

This broke in 10.4 npm@c209e98#r165769221

wraithgar · 2025-09-15T15:53:57Z

Yeah we'll definitely want a regression test for this in test/lib/utils/reify-output.js. There are two tests there already for dry-run and long you can use as a base for this new test.

greggman · 2025-09-15T22:32:21Z

you assigned this to yourself. does that mean you're planning to fix it? Or, should I put up a PR with tests?

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop and have it print from the summary object? it could either print summary.added, summary.removed, etc, or it could add a summary.diff array. I only suggested the diff array because it keeps order. If order is not important than printing from existing data at the end seems like a good idea?

wraithgar · 2025-09-16T17:03:02Z

you assigned this to yourself

This is a signal to the rest of the team that I'm reviewing the PR.

wraithgar · 2025-09-16T17:05:16Z

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop

I think this is a good iteration and it should be a separate PR. This quick fix for parsing opts should be easier to land since it's just one missing conditional and a test, leaving the optimization for a different PR.

## Summary - stop Arborist from saving `node_modules/.package-lock.json` during dry-run reification - add a regression that keeps both `package-lock.json` and the hidden lockfile unchanged after `update: true, dryRun: true` This addresses the dry-run lockfile mutation part of #9187. The JSON output behavior is separate and already has #8567 open. ## Testing - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry-run update does not save lockfiles'` - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry run, do not get anything wet|save complete lockfile on update-all'` - `../../node_modules/.bin/eslint lib/arborist/reify.js test/arborist/reify.js` - `git diff --check` Co-authored-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>

## Summary - suppress human-readable reify diff lines when JSON output is requested - preserve detailed diff output for non-JSON `--dry-run` and `--long` commands - cover both `--dry-run --json` and `--long --json` ## Background Detailed dry-run diff output was introduced in npm 10.4.0 by #7133 without accounting for JSON mode. The structured JSON summary already contains the add, remove, and change details, so the extra text is redundant and makes stdout invalid JSON. Related to #8567, with the regression coverage requested during review. ## Testing - `tap --no-coverage --no-check-coverage test/lib/utils/reify-output.js` - `eslint lib/utils/reify-output.js test/lib/utils/reify-output.js` Fixes#8565 Copilot-Session: 48e629f8-eb5a-467c-970b-feb313628c00

VariableVince · 2026-08-26T11:33:46Z

Seems to have been superseeded by #9823

greggman · 2025-09-14T21:09:49Z

This broke in 10.4. Before 10.4 npm install --dry-run --json would return JSON. After 10.4 it no longer returns JSON.

c209e98#r165769221

Note: This is the smallest change and I didn't update any tests. Nor was I sure where to one. The fact that it broke means there was no test for this before.

If it was up to me I think I'd add a summary.diff = [] and push the diffs on there. And then only at the end where it outputs summary, if you want diff output to stdout then map over summary.diff. That would put the checks for output in a single place.

References

Fixeds #8565

This broke in 10.4 npm@c209e98#r165769221

wraithgar · 2025-09-15T15:53:57Z

Yeah we'll definitely want a regression test for this in test/lib/utils/reify-output.js. There are two tests there already for dry-run and long you can use as a base for this new test.

greggman · 2025-09-15T22:32:21Z

you assigned this to yourself. does that mean you're planning to fix it? Or, should I put up a PR with tests?

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop and have it print from the summary object? it could either print summary.added, summary.removed, etc, or it could add a summary.diff array. I only suggested the diff array because it keeps order. If order is not important than printing from existing data at the end seems like a good idea?

wraithgar · 2025-09-16T17:03:02Z

you assigned this to yourself

This is a signal to the rest of the team that I'm reviewing the PR.

wraithgar · 2025-09-16T17:05:16Z

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop

I think this is a good iteration and it should be a separate PR. This quick fix for parsing opts should be easier to land since it's just one missing conditional and a test, leaving the optimization for a different PR.

## Summary - stop Arborist from saving `node_modules/.package-lock.json` during dry-run reification - add a regression that keeps both `package-lock.json` and the hidden lockfile unchanged after `update: true, dryRun: true` This addresses the dry-run lockfile mutation part of #9187. The JSON output behavior is separate and already has #8567 open. ## Testing - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry-run update does not save lockfiles'` - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry run, do not get anything wet|save complete lockfile on update-all'` - `../../node_modules/.bin/eslint lib/arborist/reify.js test/arborist/reify.js` - `git diff --check` Co-authored-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>

## Summary - suppress human-readable reify diff lines when JSON output is requested - preserve detailed diff output for non-JSON `--dry-run` and `--long` commands - cover both `--dry-run --json` and `--long --json` ## Background Detailed dry-run diff output was introduced in npm 10.4.0 by #7133 without accounting for JSON mode. The structured JSON summary already contains the add, remove, and change details, so the extra text is redundant and makes stdout invalid JSON. Related to #8567, with the regression coverage requested during review. ## Testing - `tap --no-coverage --no-check-coverage test/lib/utils/reify-output.js` - `eslint lib/utils/reify-output.js test/lib/utils/reify-output.js` Fixes#8565 Copilot-Session: 48e629f8-eb5a-467c-970b-feb313628c00

VariableVince · 2026-08-26T11:33:46Z

Seems to have been superseeded by #9823

greggman · 2025-09-14T21:09:49Z

This broke in 10.4. Before 10.4 npm install --dry-run --json would return JSON. After 10.4 it no longer returns JSON.

c209e98#r165769221

Note: This is the smallest change and I didn't update any tests. Nor was I sure where to one. The fact that it broke means there was no test for this before.

If it was up to me I think I'd add a summary.diff = [] and push the diffs on there. And then only at the end where it outputs summary, if you want diff output to stdout then map over summary.diff. That would put the checks for output in a single place.

References

Fixeds #8565

This broke in 10.4 npm@c209e98#r165769221

wraithgar · 2025-09-15T15:53:57Z

Yeah we'll definitely want a regression test for this in test/lib/utils/reify-output.js. There are two tests there already for dry-run and long you can use as a base for this new test.

greggman · 2025-09-15T22:32:21Z

you assigned this to yourself. does that mean you're planning to fix it? Or, should I put up a PR with tests?

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop and have it print from the summary object? it could either print summary.added, summary.removed, etc, or it could add a summary.diff array. I only suggested the diff array because it keeps order. If order is not important than printing from existing data at the end seems like a good idea?

wraithgar · 2025-09-16T17:03:02Z

you assigned this to yourself

This is a signal to the rest of the team that I'm reviewing the PR.

wraithgar · 2025-09-16T17:05:16Z

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop

I think this is a good iteration and it should be a separate PR. This quick fix for parsing opts should be easier to land since it's just one missing conditional and a test, leaving the optimization for a different PR.

## Summary - stop Arborist from saving `node_modules/.package-lock.json` during dry-run reification - add a regression that keeps both `package-lock.json` and the hidden lockfile unchanged after `update: true, dryRun: true` This addresses the dry-run lockfile mutation part of #9187. The JSON output behavior is separate and already has #8567 open. ## Testing - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry-run update does not save lockfiles'` - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry run, do not get anything wet|save complete lockfile on update-all'` - `../../node_modules/.bin/eslint lib/arborist/reify.js test/arborist/reify.js` - `git diff --check` Co-authored-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>

## Summary - suppress human-readable reify diff lines when JSON output is requested - preserve detailed diff output for non-JSON `--dry-run` and `--long` commands - cover both `--dry-run --json` and `--long --json` ## Background Detailed dry-run diff output was introduced in npm 10.4.0 by #7133 without accounting for JSON mode. The structured JSON summary already contains the add, remove, and change details, so the extra text is redundant and makes stdout invalid JSON. Related to #8567, with the regression coverage requested during review. ## Testing - `tap --no-coverage --no-check-coverage test/lib/utils/reify-output.js` - `eslint lib/utils/reify-output.js test/lib/utils/reify-output.js` Fixes#8565 Copilot-Session: 48e629f8-eb5a-467c-970b-feb313628c00

VariableVince · 2026-08-26T11:33:46Z

Seems to have been superseeded by #9823

greggman · 2025-09-14T21:09:49Z

This broke in 10.4. Before 10.4 npm install --dry-run --json would return JSON. After 10.4 it no longer returns JSON.

c209e98#r165769221

Note: This is the smallest change and I didn't update any tests. Nor was I sure where to one. The fact that it broke means there was no test for this before.

If it was up to me I think I'd add a summary.diff = [] and push the diffs on there. And then only at the end where it outputs summary, if you want diff output to stdout then map over summary.diff. That would put the checks for output in a single place.

References

Fixeds #8565

This broke in 10.4 npm@c209e98#r165769221

wraithgar · 2025-09-15T15:53:57Z

Yeah we'll definitely want a regression test for this in test/lib/utils/reify-output.js. There are two tests there already for dry-run and long you can use as a base for this new test.

greggman · 2025-09-15T22:32:21Z

you assigned this to yourself. does that mean you're planning to fix it? Or, should I put up a PR with tests?

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop and have it print from the summary object? it could either print summary.added, summary.removed, etc, or it could add a summary.diff array. I only suggested the diff array because it keeps order. If order is not important than printing from existing data at the end seems like a good idea?

wraithgar · 2025-09-16T17:03:02Z

you assigned this to yourself

This is a signal to the rest of the team that I'm reviewing the PR.

wraithgar · 2025-09-16T17:05:16Z

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop

I think this is a good iteration and it should be a separate PR. This quick fix for parsing opts should be easier to land since it's just one missing conditional and a test, leaving the optimization for a different PR.

## Summary - stop Arborist from saving `node_modules/.package-lock.json` during dry-run reification - add a regression that keeps both `package-lock.json` and the hidden lockfile unchanged after `update: true, dryRun: true` This addresses the dry-run lockfile mutation part of #9187. The JSON output behavior is separate and already has #8567 open. ## Testing - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry-run update does not save lockfiles'` - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry run, do not get anything wet|save complete lockfile on update-all'` - `../../node_modules/.bin/eslint lib/arborist/reify.js test/arborist/reify.js` - `git diff --check` Co-authored-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>

## Summary - suppress human-readable reify diff lines when JSON output is requested - preserve detailed diff output for non-JSON `--dry-run` and `--long` commands - cover both `--dry-run --json` and `--long --json` ## Background Detailed dry-run diff output was introduced in npm 10.4.0 by #7133 without accounting for JSON mode. The structured JSON summary already contains the add, remove, and change details, so the extra text is redundant and makes stdout invalid JSON. Related to #8567, with the regression coverage requested during review. ## Testing - `tap --no-coverage --no-check-coverage test/lib/utils/reify-output.js` - `eslint lib/utils/reify-output.js test/lib/utils/reify-output.js` Fixes#8565 Copilot-Session: 48e629f8-eb5a-467c-970b-feb313628c00

VariableVince · 2026-08-26T11:33:46Z

Seems to have been superseeded by #9823

greggman · 2025-09-14T21:09:49Z

This broke in 10.4. Before 10.4 npm install --dry-run --json would return JSON. After 10.4 it no longer returns JSON.

c209e98#r165769221

Note: This is the smallest change and I didn't update any tests. Nor was I sure where to one. The fact that it broke means there was no test for this before.

If it was up to me I think I'd add a summary.diff = [] and push the diffs on there. And then only at the end where it outputs summary, if you want diff output to stdout then map over summary.diff. That would put the checks for output in a single place.

References

Fixeds #8565

This broke in 10.4 npm@c209e98#r165769221

wraithgar · 2025-09-15T15:53:57Z

Yeah we'll definitely want a regression test for this in test/lib/utils/reify-output.js. There are two tests there already for dry-run and long you can use as a base for this new test.

greggman · 2025-09-15T22:32:21Z

you assigned this to yourself. does that mean you're planning to fix it? Or, should I put up a PR with tests?

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop and have it print from the summary object? it could either print summary.added, summary.removed, etc, or it could add a summary.diff array. I only suggested the diff array because it keeps order. If order is not important than printing from existing data at the end seems like a good idea?

wraithgar · 2025-09-16T17:03:02Z

you assigned this to yourself

This is a signal to the rest of the team that I'm reviewing the PR.

wraithgar · 2025-09-16T17:05:16Z

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop

I think this is a good iteration and it should be a separate PR. This quick fix for parsing opts should be easier to land since it's just one missing conditional and a test, leaving the optimization for a different PR.

## Summary - stop Arborist from saving `node_modules/.package-lock.json` during dry-run reification - add a regression that keeps both `package-lock.json` and the hidden lockfile unchanged after `update: true, dryRun: true` This addresses the dry-run lockfile mutation part of #9187. The JSON output behavior is separate and already has #8567 open. ## Testing - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry-run update does not save lockfiles'` - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry run, do not get anything wet|save complete lockfile on update-all'` - `../../node_modules/.bin/eslint lib/arborist/reify.js test/arborist/reify.js` - `git diff --check` Co-authored-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>

## Summary - suppress human-readable reify diff lines when JSON output is requested - preserve detailed diff output for non-JSON `--dry-run` and `--long` commands - cover both `--dry-run --json` and `--long --json` ## Background Detailed dry-run diff output was introduced in npm 10.4.0 by #7133 without accounting for JSON mode. The structured JSON summary already contains the add, remove, and change details, so the extra text is redundant and makes stdout invalid JSON. Related to #8567, with the regression coverage requested during review. ## Testing - `tap --no-coverage --no-check-coverage test/lib/utils/reify-output.js` - `eslint lib/utils/reify-output.js test/lib/utils/reify-output.js` Fixes#8565 Copilot-Session: 48e629f8-eb5a-467c-970b-feb313628c00

VariableVince · 2026-08-26T11:33:46Z

Seems to have been superseeded by #9823

greggman · 2025-09-14T21:09:49Z

This broke in 10.4. Before 10.4 npm install --dry-run --json would return JSON. After 10.4 it no longer returns JSON.

c209e98#r165769221

Note: This is the smallest change and I didn't update any tests. Nor was I sure where to one. The fact that it broke means there was no test for this before.

If it was up to me I think I'd add a summary.diff = [] and push the diffs on there. And then only at the end where it outputs summary, if you want diff output to stdout then map over summary.diff. That would put the checks for output in a single place.

References

Fixeds #8565

This broke in 10.4 npm@c209e98#r165769221

wraithgar · 2025-09-15T15:53:57Z

Yeah we'll definitely want a regression test for this in test/lib/utils/reify-output.js. There are two tests there already for dry-run and long you can use as a base for this new test.

greggman · 2025-09-15T22:32:21Z

you assigned this to yourself. does that mean you're planning to fix it? Or, should I put up a PR with tests?

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop and have it print from the summary object? it could either print summary.added, summary.removed, etc, or it could add a summary.diff array. I only suggested the diff array because it keeps order. If order is not important than printing from existing data at the end seems like a good idea?

wraithgar · 2025-09-16T17:03:02Z

you assigned this to yourself

This is a signal to the rest of the team that I'm reviewing the PR.

wraithgar · 2025-09-16T17:05:16Z

also, so you have any thoughts/comments on moving the "showfix" stuff outside the loop

I think this is a good iteration and it should be a separate PR. This quick fix for parsing opts should be easier to land since it's just one missing conditional and a test, leaving the optimization for a different PR.

## Summary - stop Arborist from saving `node_modules/.package-lock.json` during dry-run reification - add a regression that keeps both `package-lock.json` and the hidden lockfile unchanged after `update: true, dryRun: true` This addresses the dry-run lockfile mutation part of #9187. The JSON output behavior is separate and already has #8567 open. ## Testing - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry-run update does not save lockfiles'` - `../../node_modules/.bin/tap --no-coverage --no-check-coverage test/arborist/reify.js -g 'dry run, do not get anything wet|save complete lockfile on update-all'` - `../../node_modules/.bin/eslint lib/arborist/reify.js test/arborist/reify.js` - `git diff --check` Co-authored-by: Puneet Dixit <236133619+puneetdixit200@users.noreply.github.com>

## Summary - suppress human-readable reify diff lines when JSON output is requested - preserve detailed diff output for non-JSON `--dry-run` and `--long` commands - cover both `--dry-run --json` and `--long --json` ## Background Detailed dry-run diff output was introduced in npm 10.4.0 by #7133 without accounting for JSON mode. The structured JSON summary already contains the add, remove, and change details, so the extra text is redundant and makes stdout invalid JSON. Related to #8567, with the regression coverage requested during review. ## Testing - `tap --no-coverage --no-check-coverage test/lib/utils/reify-output.js` - `eslint lib/utils/reify-output.js test/lib/utils/reify-output.js` Fixes#8565 Copilot-Session: 48e629f8-eb5a-467c-970b-feb313628c00

VariableVince · 2026-08-26T11:33:46Z

Seems to have been superseeded by #9823

Fix install --dry-run --json to output JSON
9aee79c
This broke in 10.4 npm@c209e98#r165769221

greggman requested a review from a team as a code owner September 14, 2025 21:09

wraithgar changed the title ~~Fix install --dry-run --json to output JSON~~fix: --dry-run with --json outputSep 15, 2025

wraithgar self-assigned this Sep 15, 2025

puneetdixit200 mentioned this pull request May 23, 2026
fix: skip hidden lockfile save on dry run #9395
Merged

martinrrm mentioned this pull request Jul 30, 2026
fix: keep dry-run output valid json #9823
Merged

wraithgar removed their assignment Aug 26, 2026

Fix install --dry-run --json to output JSON
9aee79c
This broke in 10.4 npm@c209e98#r165769221

greggman requested a review from a team as a code owner September 14, 2025 21:09

wraithgar changed the title ~~Fix install --dry-run --json to output JSON~~fix: --dry-run with --json outputSep 15, 2025

wraithgar self-assigned this Sep 15, 2025

puneetdixit200 mentioned this pull request May 23, 2026
fix: skip hidden lockfile save on dry run #9395
Merged

martinrrm mentioned this pull request Jul 30, 2026
fix: keep dry-run output valid json #9823
Merged

wraithgar removed their assignment Aug 26, 2026

Fix install --dry-run --json to output JSON
9aee79c
This broke in 10.4 npm@c209e98#r165769221

greggman requested a review from a team as a code owner September 14, 2025 21:09

wraithgar changed the title ~~Fix install --dry-run --json to output JSON~~fix: --dry-run with --json outputSep 15, 2025

wraithgar self-assigned this Sep 15, 2025

puneetdixit200 mentioned this pull request May 23, 2026
fix: skip hidden lockfile save on dry run #9395
Merged

martinrrm mentioned this pull request Jul 30, 2026
fix: keep dry-run output valid json #9823
Merged

wraithgar removed their assignment Aug 26, 2026

Fix install --dry-run --json to output JSON
9aee79c
This broke in 10.4 npm@c209e98#r165769221

greggman requested a review from a team as a code owner September 14, 2025 21:09

wraithgar changed the title ~~Fix install --dry-run --json to output JSON~~fix: --dry-run with --json outputSep 15, 2025

wraithgar self-assigned this Sep 15, 2025

puneetdixit200 mentioned this pull request May 23, 2026
fix: skip hidden lockfile save on dry run #9395
Merged

martinrrm mentioned this pull request Jul 30, 2026
fix: keep dry-run output valid json #9823
Merged

wraithgar removed their assignment Aug 26, 2026

Fix install --dry-run --json to output JSON
9aee79c
This broke in 10.4 npm@c209e98#r165769221

greggman requested a review from a team as a code owner September 14, 2025 21:09

wraithgar changed the title ~~Fix install --dry-run --json to output JSON~~fix: --dry-run with --json outputSep 15, 2025

wraithgar self-assigned this Sep 15, 2025

puneetdixit200 mentioned this pull request May 23, 2026
fix: skip hidden lockfile save on dry run #9395
Merged

martinrrm mentioned this pull request Jul 30, 2026
fix: keep dry-run output valid json #9823
Merged

wraithgar removed their assignment Aug 26, 2026

Fix install --dry-run --json to output JSON
9aee79c
This broke in 10.4 npm@c209e98#r165769221

greggman requested a review from a team as a code owner September 14, 2025 21:09

wraithgar changed the title ~~Fix install --dry-run --json to output JSON~~fix: --dry-run with --json outputSep 15, 2025

wraithgar self-assigned this Sep 15, 2025

puneetdixit200 mentioned this pull request May 23, 2026
fix: skip hidden lockfile save on dry run #9395
Merged

martinrrm mentioned this pull request Jul 30, 2026
fix: keep dry-run output valid json #9823
Merged

wraithgar removed their assignment Aug 26, 2026

Fix install --dry-run --json to output JSON
9aee79c
This broke in 10.4 npm@c209e98#r165769221

greggman requested a review from a team as a code owner September 14, 2025 21:09

wraithgar changed the title ~~Fix install --dry-run --json to output JSON~~fix: --dry-run with --json outputSep 15, 2025

wraithgar self-assigned this Sep 15, 2025

puneetdixit200 mentioned this pull request May 23, 2026
fix: skip hidden lockfile save on dry run #9395
Merged

martinrrm mentioned this pull request Jul 30, 2026
fix: keep dry-run output valid json #9823
Merged

wraithgar removed their assignment Aug 26, 2026

Fix install --dry-run --json to output JSON
9aee79c
This broke in 10.4 npm@c209e98#r165769221

greggman requested a review from a team as a code owner September 14, 2025 21:09

wraithgar changed the title ~~Fix install --dry-run --json to output JSON~~fix: --dry-run with --json outputSep 15, 2025

wraithgar self-assigned this Sep 15, 2025

puneetdixit200 mentioned this pull request May 23, 2026
fix: skip hidden lockfile save on dry run #9395
Merged

martinrrm mentioned this pull request Jul 30, 2026
fix: keep dry-run output valid json #9823
Merged

wraithgar removed their assignment Aug 26, 2026

Uh oh!

Conversation

greggman commented Sep 14, 2025

References

Uh oh!

wraithgar commented Sep 15, 2025

Uh oh!

greggman commented Sep 15, 2025

Uh oh!

wraithgar commented Sep 16, 2025

Uh oh!

wraithgar commented Sep 16, 2025

Uh oh!

VariableVince commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

greggman commented Sep 14, 2025

References

Uh oh!

wraithgar commented Sep 15, 2025

Uh oh!

greggman commented Sep 15, 2025

Uh oh!

wraithgar commented Sep 16, 2025

Uh oh!

wraithgar commented Sep 16, 2025

Uh oh!

VariableVince commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

greggman commented Sep 14, 2025

References

Uh oh!

wraithgar commented Sep 15, 2025

Uh oh!

greggman commented Sep 15, 2025

Uh oh!

wraithgar commented Sep 16, 2025

Uh oh!

wraithgar commented Sep 16, 2025

Uh oh!

VariableVince commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

greggman commented Sep 14, 2025

References

Uh oh!

wraithgar commented Sep 15, 2025

Uh oh!

greggman commented Sep 15, 2025

Uh oh!

wraithgar commented Sep 16, 2025

Uh oh!