Skip to content

fix: code cleanup - #8677

Merged
wraithgar merged 12 commits into
latestfrom
gar/arborist-cleanup
Oct 16, 2025
Merged

fix: code cleanup#8677
wraithgar merged 12 commits into
latestfrom
gar/arborist-cleanup

Conversation

@wraithgar

@wraithgarwraithgar commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Smaller version of #8675 without the code rollups.

  • constructor logic was consolidated. It takes place in the main Arborist constructor when possible, allowing us to see all of the constructor at once and find any duplications or problems. It's evident that our approach to options/this.options needs some attention.
  • Some small single-use methods were inlined into the code that called them. In many cases this prevented re-pulling variables from this.
  • remove unused param from call to #linkFromSpec. The function is not expecting a fourth parameter.
  • remove unused private attributes, #dryRun and #savePrefix are not used anymore

@wraithgar
wraithgar requested a review from a team as a code ownerOctober 15, 2025 19:57
@wraithgar
move public build-ideal-tree constructor code to main class
0e6a14e
@wraithgar
consolidate constructors
d691575
move everything public to Arborist
move everything "private" and shared to build-ideal-tree
remove #resetQueues in favor of an initial value and explicit reset
@wraithgar
remove unused param from function call
b38b772
@wraithgar
move usePackageLock to this.options
075d770
@wraithgar
wraithgar merged commit 05319f0 into latestOct 16, 2025
16 checks passed
@wraithgar
wraithgar deleted the gar/arborist-cleanup branch October 16, 2025 01:30
@github-actionsgithub-actionsBot mentioned this pull request Oct 15, 2025
Merged
@github-actionsgithub-actionsBot mentioned this pull request May 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@owlstronautowlstronautowlstronaut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wraithgar@owlstronaut