Skip to content

fix: pass _isRoot context where missing - #9206

Merged
wraithgar merged 1 commit into
latestfrom
gar/allow-git-fix
Apr 15, 2026
Merged

fix: pass _isRoot context where missing#9206
wraithgar merged 1 commit into
latestfrom
gar/allow-git-fix

Conversation

@wraithgar

Copy link
Copy Markdown
Contributor

fixes: #9189

@wraithgar
wraithgar requested a review from a team as a code ownerApril 8, 2026 17:32

@owlstronautowlstronaut left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhenry

Copy link
Copy Markdown

@wraithgar

Copy link
Copy Markdown
ContributorAuthor

The test was fine, it's a negative test (i.e. refuses a situation). There is no positive test (i.e. allows the situation) and that's what would have caught this.

@akhenry

Copy link
Copy Markdown

The test was fine, it's a negative test (i.e. refuses a situation). There is no positive test (i.e. allows the situation) and that's what would have caught this.

Even if it's a negative test, it doesn't actually set allow-git to root, so it doesn't seem to be testing what it says it's testing:

Screenshot 2026-04-08 at 1 58 29 PM

@akhenry

Copy link
Copy Markdown

In any case, thank you for addressing this issue so quickly! Appreciate it.

@wraithgar
wraithgar merged commit dcad8ec into latestApr 15, 2026
32 of 35 checks passed
@wraithgar
wraithgar deleted the gar/allow-git-fix branch April 15, 2026 17:54
github-actionsBot pushed a commit that referenced this pull request Apr 15, 2026
@github-actions

This comment was marked as outdated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] allow-git=root does not allow root level git dependencies to be installed

3 participants

@wraithgar@akhenry@owlstronaut