Skip to content

fix(exec): resolve workspace-local bin under the linked install strategy - #9639

Merged
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin
Jun 24, 2026
Merged

fix(exec): resolve workspace-local bin under the linked install strategy#9639
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Contributor

In continuation of our exploration of using install-strategy=linked in the Gutenberg monorepo, which powers the WordPress Block Editor.

Under install-strategy=linked, npm exec -w <ws> -- <bin> ignored a workspace-local bin (provided by a sibling workspace dependency) and fell through to the registry, producing a spurious E404. The hoisted strategy ran the local bin correctly.

Why

For a workspace exec, the command computed the local bin directory as resolve(this.npm.localDir, name, 'node_modules', '.bin'), i.e. <root>/node_modules/<name>/node_modules/.bin. That path only resolves when the workspace is symlinked into the root node_modules as <name>, which is how the hoisted strategy lays workspaces out. The linked strategy does not hoist workspaces into the root node_modules; the workspace's real bin lives at <workspace>/node_modules/.bin. libnpmexec walks up from the given bin directory looking for node_modules/.bin/<bin>, so starting from the nonexistent hoisted path never reached the workspace's actual bin and the lookup fell back to the registry.

How

Base the local bin directory on the workspace's own path (runPath) instead of the hoisted localDir/<name> location. This is correct under both strategies: linked finds the bin in the workspace's node_modules/.bin, and hoisted still finds the root-hoisted bin because the walk-up continues from the workspace directory to the root node_modules/.bin.

References

Fixes#9616

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 12ebf3a to 8f6667eCompareJune 24, 2026 17:29
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 17:31
@manzoorwanijk
manzoorwanijk requested review from a team as code ownersJune 24, 2026 17:31
@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch 2 times, most recently from c4ab8a3 to 1a0596eCompareJune 24, 2026 18:29
@manzoorwanijk

manzoorwanijk commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

The coverage is broken in latest as well.

EDIT: Resolved by #9646

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 1a0596e to 86c6fd5CompareJune 24, 2026 18:54
@manzoorwanijk
manzoorwanijk marked this pull request as draft June 24, 2026 19:21
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 19:21
@owlstronaut
owlstronaut merged commit d6fbb55 into npm:latestJun 24, 2026
27 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Backport to release/v11 created: #9648

@manzoorwanijk
manzoorwanijk deleted the fix/linked-exec-workspace-bin branch June 24, 2026 19:48
@github-actionsgithub-actionsBot mentioned this pull request Jun 24, 2026
owlstronaut pushed a commit that referenced this pull request Jun 24, 2026
…egy (#9648)
Backport of #9639 to `release/v11`.
Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] install-strategy=linked: npm exec -w <ws> ignores a workspace-local bin and falls back to the registry

2 participants

@manzoorwanijk@owlstronaut
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(exec): resolve workspace-local bin under the linked install strategy by manzoorwanijk · Pull Request #9639 · npm/cli · GitHub
Skip to content

fix(exec): resolve workspace-local bin under the linked install strategy - #9639

Merged
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin
Jun 24, 2026
Merged

fix(exec): resolve workspace-local bin under the linked install strategy#9639
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Contributor

In continuation of our exploration of using install-strategy=linked in the Gutenberg monorepo, which powers the WordPress Block Editor.

Under install-strategy=linked, npm exec -w <ws> -- <bin> ignored a workspace-local bin (provided by a sibling workspace dependency) and fell through to the registry, producing a spurious E404. The hoisted strategy ran the local bin correctly.

Why

For a workspace exec, the command computed the local bin directory as resolve(this.npm.localDir, name, 'node_modules', '.bin'), i.e. <root>/node_modules/<name>/node_modules/.bin. That path only resolves when the workspace is symlinked into the root node_modules as <name>, which is how the hoisted strategy lays workspaces out. The linked strategy does not hoist workspaces into the root node_modules; the workspace's real bin lives at <workspace>/node_modules/.bin. libnpmexec walks up from the given bin directory looking for node_modules/.bin/<bin>, so starting from the nonexistent hoisted path never reached the workspace's actual bin and the lookup fell back to the registry.

How

Base the local bin directory on the workspace's own path (runPath) instead of the hoisted localDir/<name> location. This is correct under both strategies: linked finds the bin in the workspace's node_modules/.bin, and hoisted still finds the root-hoisted bin because the walk-up continues from the workspace directory to the root node_modules/.bin.

References

Fixes#9616

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 12ebf3a to 8f6667eCompareJune 24, 2026 17:29
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 17:31
@manzoorwanijk
manzoorwanijk requested review from a team as code ownersJune 24, 2026 17:31
@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch 2 times, most recently from c4ab8a3 to 1a0596eCompareJune 24, 2026 18:29
@manzoorwanijk

manzoorwanijk commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

The coverage is broken in latest as well.

EDIT: Resolved by #9646

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 1a0596e to 86c6fd5CompareJune 24, 2026 18:54
@manzoorwanijk
manzoorwanijk marked this pull request as draft June 24, 2026 19:21
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 19:21
@owlstronaut
owlstronaut merged commit d6fbb55 into npm:latestJun 24, 2026
27 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Backport to release/v11 created: #9648

@manzoorwanijk
manzoorwanijk deleted the fix/linked-exec-workspace-bin branch June 24, 2026 19:48
@github-actionsgithub-actionsBot mentioned this pull request Jun 24, 2026
owlstronaut pushed a commit that referenced this pull request Jun 24, 2026
…egy (#9648)
Backport of #9639 to `release/v11`.
Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] install-strategy=linked: npm exec -w <ws> ignores a workspace-local bin and falls back to the registry

2 participants

@manzoorwanijk@owlstronaut
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(exec): resolve workspace-local bin under the linked install strategy by manzoorwanijk · Pull Request #9639 · npm/cli · GitHub
Skip to content

fix(exec): resolve workspace-local bin under the linked install strategy - #9639

Merged
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin
Jun 24, 2026
Merged

fix(exec): resolve workspace-local bin under the linked install strategy#9639
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Contributor

In continuation of our exploration of using install-strategy=linked in the Gutenberg monorepo, which powers the WordPress Block Editor.

Under install-strategy=linked, npm exec -w <ws> -- <bin> ignored a workspace-local bin (provided by a sibling workspace dependency) and fell through to the registry, producing a spurious E404. The hoisted strategy ran the local bin correctly.

Why

For a workspace exec, the command computed the local bin directory as resolve(this.npm.localDir, name, 'node_modules', '.bin'), i.e. <root>/node_modules/<name>/node_modules/.bin. That path only resolves when the workspace is symlinked into the root node_modules as <name>, which is how the hoisted strategy lays workspaces out. The linked strategy does not hoist workspaces into the root node_modules; the workspace's real bin lives at <workspace>/node_modules/.bin. libnpmexec walks up from the given bin directory looking for node_modules/.bin/<bin>, so starting from the nonexistent hoisted path never reached the workspace's actual bin and the lookup fell back to the registry.

How

Base the local bin directory on the workspace's own path (runPath) instead of the hoisted localDir/<name> location. This is correct under both strategies: linked finds the bin in the workspace's node_modules/.bin, and hoisted still finds the root-hoisted bin because the walk-up continues from the workspace directory to the root node_modules/.bin.

References

Fixes#9616

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 12ebf3a to 8f6667eCompareJune 24, 2026 17:29
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 17:31
@manzoorwanijk
manzoorwanijk requested review from a team as code ownersJune 24, 2026 17:31
@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch 2 times, most recently from c4ab8a3 to 1a0596eCompareJune 24, 2026 18:29
@manzoorwanijk

manzoorwanijk commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

The coverage is broken in latest as well.

EDIT: Resolved by #9646

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 1a0596e to 86c6fd5CompareJune 24, 2026 18:54
@manzoorwanijk
manzoorwanijk marked this pull request as draft June 24, 2026 19:21
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 19:21
@owlstronaut
owlstronaut merged commit d6fbb55 into npm:latestJun 24, 2026
27 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Backport to release/v11 created: #9648

@manzoorwanijk
manzoorwanijk deleted the fix/linked-exec-workspace-bin branch June 24, 2026 19:48
@github-actionsgithub-actionsBot mentioned this pull request Jun 24, 2026
owlstronaut pushed a commit that referenced this pull request Jun 24, 2026
…egy (#9648)
Backport of #9639 to `release/v11`.
Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] install-strategy=linked: npm exec -w <ws> ignores a workspace-local bin and falls back to the registry

2 participants

@manzoorwanijk@owlstronaut
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(exec): resolve workspace-local bin under the linked install strategy by manzoorwanijk · Pull Request #9639 · npm/cli · GitHub
Skip to content

fix(exec): resolve workspace-local bin under the linked install strategy - #9639

Merged
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin
Jun 24, 2026
Merged

fix(exec): resolve workspace-local bin under the linked install strategy#9639
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Contributor

In continuation of our exploration of using install-strategy=linked in the Gutenberg monorepo, which powers the WordPress Block Editor.

Under install-strategy=linked, npm exec -w <ws> -- <bin> ignored a workspace-local bin (provided by a sibling workspace dependency) and fell through to the registry, producing a spurious E404. The hoisted strategy ran the local bin correctly.

Why

For a workspace exec, the command computed the local bin directory as resolve(this.npm.localDir, name, 'node_modules', '.bin'), i.e. <root>/node_modules/<name>/node_modules/.bin. That path only resolves when the workspace is symlinked into the root node_modules as <name>, which is how the hoisted strategy lays workspaces out. The linked strategy does not hoist workspaces into the root node_modules; the workspace's real bin lives at <workspace>/node_modules/.bin. libnpmexec walks up from the given bin directory looking for node_modules/.bin/<bin>, so starting from the nonexistent hoisted path never reached the workspace's actual bin and the lookup fell back to the registry.

How

Base the local bin directory on the workspace's own path (runPath) instead of the hoisted localDir/<name> location. This is correct under both strategies: linked finds the bin in the workspace's node_modules/.bin, and hoisted still finds the root-hoisted bin because the walk-up continues from the workspace directory to the root node_modules/.bin.

References

Fixes#9616

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 12ebf3a to 8f6667eCompareJune 24, 2026 17:29
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 17:31
@manzoorwanijk
manzoorwanijk requested review from a team as code ownersJune 24, 2026 17:31
@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch 2 times, most recently from c4ab8a3 to 1a0596eCompareJune 24, 2026 18:29
@manzoorwanijk

manzoorwanijk commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

The coverage is broken in latest as well.

EDIT: Resolved by #9646

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 1a0596e to 86c6fd5CompareJune 24, 2026 18:54
@manzoorwanijk
manzoorwanijk marked this pull request as draft June 24, 2026 19:21
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 19:21
@owlstronaut
owlstronaut merged commit d6fbb55 into npm:latestJun 24, 2026
27 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Backport to release/v11 created: #9648

@manzoorwanijk
manzoorwanijk deleted the fix/linked-exec-workspace-bin branch June 24, 2026 19:48
@github-actionsgithub-actionsBot mentioned this pull request Jun 24, 2026
owlstronaut pushed a commit that referenced this pull request Jun 24, 2026
…egy (#9648)
Backport of #9639 to `release/v11`.
Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] install-strategy=linked: npm exec -w <ws> ignores a workspace-local bin and falls back to the registry

2 participants

@manzoorwanijk@owlstronaut
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(exec): resolve workspace-local bin under the linked install strategy by manzoorwanijk · Pull Request #9639 · npm/cli · GitHub
Skip to content

fix(exec): resolve workspace-local bin under the linked install strategy - #9639

Merged
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin
Jun 24, 2026
Merged

fix(exec): resolve workspace-local bin under the linked install strategy#9639
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Contributor

In continuation of our exploration of using install-strategy=linked in the Gutenberg monorepo, which powers the WordPress Block Editor.

Under install-strategy=linked, npm exec -w <ws> -- <bin> ignored a workspace-local bin (provided by a sibling workspace dependency) and fell through to the registry, producing a spurious E404. The hoisted strategy ran the local bin correctly.

Why

For a workspace exec, the command computed the local bin directory as resolve(this.npm.localDir, name, 'node_modules', '.bin'), i.e. <root>/node_modules/<name>/node_modules/.bin. That path only resolves when the workspace is symlinked into the root node_modules as <name>, which is how the hoisted strategy lays workspaces out. The linked strategy does not hoist workspaces into the root node_modules; the workspace's real bin lives at <workspace>/node_modules/.bin. libnpmexec walks up from the given bin directory looking for node_modules/.bin/<bin>, so starting from the nonexistent hoisted path never reached the workspace's actual bin and the lookup fell back to the registry.

How

Base the local bin directory on the workspace's own path (runPath) instead of the hoisted localDir/<name> location. This is correct under both strategies: linked finds the bin in the workspace's node_modules/.bin, and hoisted still finds the root-hoisted bin because the walk-up continues from the workspace directory to the root node_modules/.bin.

References

Fixes#9616

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 12ebf3a to 8f6667eCompareJune 24, 2026 17:29
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 17:31
@manzoorwanijk
manzoorwanijk requested review from a team as code ownersJune 24, 2026 17:31
@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch 2 times, most recently from c4ab8a3 to 1a0596eCompareJune 24, 2026 18:29
@manzoorwanijk

manzoorwanijk commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

The coverage is broken in latest as well.

EDIT: Resolved by #9646

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 1a0596e to 86c6fd5CompareJune 24, 2026 18:54
@manzoorwanijk
manzoorwanijk marked this pull request as draft June 24, 2026 19:21
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 19:21
@owlstronaut
owlstronaut merged commit d6fbb55 into npm:latestJun 24, 2026
27 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Backport to release/v11 created: #9648

@manzoorwanijk
manzoorwanijk deleted the fix/linked-exec-workspace-bin branch June 24, 2026 19:48
@github-actionsgithub-actionsBot mentioned this pull request Jun 24, 2026
owlstronaut pushed a commit that referenced this pull request Jun 24, 2026
…egy (#9648)
Backport of #9639 to `release/v11`.
Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] install-strategy=linked: npm exec -w <ws> ignores a workspace-local bin and falls back to the registry

2 participants

@manzoorwanijk@owlstronaut
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(exec): resolve workspace-local bin under the linked install strategy by manzoorwanijk · Pull Request #9639 · npm/cli · GitHub
Skip to content

fix(exec): resolve workspace-local bin under the linked install strategy - #9639

Merged
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin
Jun 24, 2026
Merged

fix(exec): resolve workspace-local bin under the linked install strategy#9639
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Contributor

In continuation of our exploration of using install-strategy=linked in the Gutenberg monorepo, which powers the WordPress Block Editor.

Under install-strategy=linked, npm exec -w <ws> -- <bin> ignored a workspace-local bin (provided by a sibling workspace dependency) and fell through to the registry, producing a spurious E404. The hoisted strategy ran the local bin correctly.

Why

For a workspace exec, the command computed the local bin directory as resolve(this.npm.localDir, name, 'node_modules', '.bin'), i.e. <root>/node_modules/<name>/node_modules/.bin. That path only resolves when the workspace is symlinked into the root node_modules as <name>, which is how the hoisted strategy lays workspaces out. The linked strategy does not hoist workspaces into the root node_modules; the workspace's real bin lives at <workspace>/node_modules/.bin. libnpmexec walks up from the given bin directory looking for node_modules/.bin/<bin>, so starting from the nonexistent hoisted path never reached the workspace's actual bin and the lookup fell back to the registry.

How

Base the local bin directory on the workspace's own path (runPath) instead of the hoisted localDir/<name> location. This is correct under both strategies: linked finds the bin in the workspace's node_modules/.bin, and hoisted still finds the root-hoisted bin because the walk-up continues from the workspace directory to the root node_modules/.bin.

References

Fixes#9616

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 12ebf3a to 8f6667eCompareJune 24, 2026 17:29
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 17:31
@manzoorwanijk
manzoorwanijk requested review from a team as code ownersJune 24, 2026 17:31
@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch 2 times, most recently from c4ab8a3 to 1a0596eCompareJune 24, 2026 18:29
@manzoorwanijk

manzoorwanijk commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

The coverage is broken in latest as well.

EDIT: Resolved by #9646

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 1a0596e to 86c6fd5CompareJune 24, 2026 18:54
@manzoorwanijk
manzoorwanijk marked this pull request as draft June 24, 2026 19:21
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 19:21
@owlstronaut
owlstronaut merged commit d6fbb55 into npm:latestJun 24, 2026
27 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Backport to release/v11 created: #9648

@manzoorwanijk
manzoorwanijk deleted the fix/linked-exec-workspace-bin branch June 24, 2026 19:48
@github-actionsgithub-actionsBot mentioned this pull request Jun 24, 2026
owlstronaut pushed a commit that referenced this pull request Jun 24, 2026
…egy (#9648)
Backport of #9639 to `release/v11`.
Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] install-strategy=linked: npm exec -w <ws> ignores a workspace-local bin and falls back to the registry

2 participants

@manzoorwanijk@owlstronaut
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(exec): resolve workspace-local bin under the linked install strategy by manzoorwanijk · Pull Request #9639 · npm/cli · GitHub
Skip to content

fix(exec): resolve workspace-local bin under the linked install strategy - #9639

Merged
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin
Jun 24, 2026
Merged

fix(exec): resolve workspace-local bin under the linked install strategy#9639
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Contributor

In continuation of our exploration of using install-strategy=linked in the Gutenberg monorepo, which powers the WordPress Block Editor.

Under install-strategy=linked, npm exec -w <ws> -- <bin> ignored a workspace-local bin (provided by a sibling workspace dependency) and fell through to the registry, producing a spurious E404. The hoisted strategy ran the local bin correctly.

Why

For a workspace exec, the command computed the local bin directory as resolve(this.npm.localDir, name, 'node_modules', '.bin'), i.e. <root>/node_modules/<name>/node_modules/.bin. That path only resolves when the workspace is symlinked into the root node_modules as <name>, which is how the hoisted strategy lays workspaces out. The linked strategy does not hoist workspaces into the root node_modules; the workspace's real bin lives at <workspace>/node_modules/.bin. libnpmexec walks up from the given bin directory looking for node_modules/.bin/<bin>, so starting from the nonexistent hoisted path never reached the workspace's actual bin and the lookup fell back to the registry.

How

Base the local bin directory on the workspace's own path (runPath) instead of the hoisted localDir/<name> location. This is correct under both strategies: linked finds the bin in the workspace's node_modules/.bin, and hoisted still finds the root-hoisted bin because the walk-up continues from the workspace directory to the root node_modules/.bin.

References

Fixes#9616

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 12ebf3a to 8f6667eCompareJune 24, 2026 17:29
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 17:31
@manzoorwanijk
manzoorwanijk requested review from a team as code ownersJune 24, 2026 17:31
@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch 2 times, most recently from c4ab8a3 to 1a0596eCompareJune 24, 2026 18:29
@manzoorwanijk

manzoorwanijk commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

The coverage is broken in latest as well.

EDIT: Resolved by #9646

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 1a0596e to 86c6fd5CompareJune 24, 2026 18:54
@manzoorwanijk
manzoorwanijk marked this pull request as draft June 24, 2026 19:21
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 19:21
@owlstronaut
owlstronaut merged commit d6fbb55 into npm:latestJun 24, 2026
27 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Backport to release/v11 created: #9648

@manzoorwanijk
manzoorwanijk deleted the fix/linked-exec-workspace-bin branch June 24, 2026 19:48
@github-actionsgithub-actionsBot mentioned this pull request Jun 24, 2026
owlstronaut pushed a commit that referenced this pull request Jun 24, 2026
…egy (#9648)
Backport of #9639 to `release/v11`.
Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] install-strategy=linked: npm exec -w <ws> ignores a workspace-local bin and falls back to the registry

2 participants

@manzoorwanijk@owlstronaut
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(exec): resolve workspace-local bin under the linked install strategy by manzoorwanijk · Pull Request #9639 · npm/cli · GitHub
Skip to content

fix(exec): resolve workspace-local bin under the linked install strategy - #9639

Merged
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin
Jun 24, 2026
Merged

fix(exec): resolve workspace-local bin under the linked install strategy#9639
owlstronaut merged 1 commit into
npm:latestfrom
manzoorwanijk:fix/linked-exec-workspace-bin

Conversation

@manzoorwanijk

Copy link
Copy Markdown
Contributor

In continuation of our exploration of using install-strategy=linked in the Gutenberg monorepo, which powers the WordPress Block Editor.

Under install-strategy=linked, npm exec -w <ws> -- <bin> ignored a workspace-local bin (provided by a sibling workspace dependency) and fell through to the registry, producing a spurious E404. The hoisted strategy ran the local bin correctly.

Why

For a workspace exec, the command computed the local bin directory as resolve(this.npm.localDir, name, 'node_modules', '.bin'), i.e. <root>/node_modules/<name>/node_modules/.bin. That path only resolves when the workspace is symlinked into the root node_modules as <name>, which is how the hoisted strategy lays workspaces out. The linked strategy does not hoist workspaces into the root node_modules; the workspace's real bin lives at <workspace>/node_modules/.bin. libnpmexec walks up from the given bin directory looking for node_modules/.bin/<bin>, so starting from the nonexistent hoisted path never reached the workspace's actual bin and the lookup fell back to the registry.

How

Base the local bin directory on the workspace's own path (runPath) instead of the hoisted localDir/<name> location. This is correct under both strategies: linked finds the bin in the workspace's node_modules/.bin, and hoisted still finds the root-hoisted bin because the walk-up continues from the workspace directory to the root node_modules/.bin.

References

Fixes#9616

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 12ebf3a to 8f6667eCompareJune 24, 2026 17:29
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 17:31
@manzoorwanijk
manzoorwanijk requested review from a team as code ownersJune 24, 2026 17:31
@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch 2 times, most recently from c4ab8a3 to 1a0596eCompareJune 24, 2026 18:29
@manzoorwanijk

manzoorwanijk commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

The coverage is broken in latest as well.

EDIT: Resolved by #9646

@manzoorwanijk
manzoorwanijkforce-pushed the fix/linked-exec-workspace-bin branch from 1a0596e to 86c6fd5CompareJune 24, 2026 18:54
@manzoorwanijk
manzoorwanijk marked this pull request as draft June 24, 2026 19:21
@manzoorwanijk
manzoorwanijk marked this pull request as ready for review June 24, 2026 19:21
@owlstronaut
owlstronaut merged commit d6fbb55 into npm:latestJun 24, 2026
27 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Backport to release/v11 created: #9648

@manzoorwanijk
manzoorwanijk deleted the fix/linked-exec-workspace-bin branch June 24, 2026 19:48
@github-actionsgithub-actionsBot mentioned this pull request Jun 24, 2026
owlstronaut pushed a commit that referenced this pull request Jun 24, 2026
…egy (#9648)
Backport of #9639 to `release/v11`.
Co-authored-by: Manzoor Wani <manzoorwani.jk@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] install-strategy=linked: npm exec -w <ws> ignores a workspace-local bin and falls back to the registry

2 participants

@manzoorwanijk@owlstronaut