Skip to content

fix: intersects with v0.0.0 and v0.0.0-0 - #538

Merged
wraithgar merged 2 commits into
mainfrom
gar/zero-intersects
Apr 10, 2023
Merged

fix: intersects with v0.0.0 and v0.0.0-0#538
wraithgar merged 2 commits into
mainfrom
gar/zero-intersects

Conversation

@wraithgar

@wraithgarwraithgar commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

Also fix options not being passed through from semver.intersects

Closes#521

@wraithgar
wraithgar requested a review from a team as a code ownerApril 6, 2023 23:58
@wraithgar
wraithgar requested review from lukekarrys and removed request for a teamApril 6, 2023 23:58
@wraithgar

Copy link
Copy Markdown
ContributorAuthor

This can't land before #535 since that removes the dead code that is causing coverage failures here.

Comment threadclasses/comparator.js Outdated
nlf
nlf approved these changes Apr 10, 2023

@nlfnlf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome, good bug fix and so much more readable!

Also fix options not being passed through from semver.intersects
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] intersects(r1, r2, options) function returns true if the not intersected range < 0.0.0 and 0.x are supplied

3 participants

@wraithgar@nlf@H4ad