RFC: Multiple Funding Sources by ljharb · Pull Request #68 · npm/rfcs

ljharb · 2019-11-19T01:00:40Z

What / Why

Allow the funding field, which currently can contain a string or an object, to contain an array of those things as well.

See the document for more details.

ljharb · 2019-11-26T17:50:21Z

@mikemimik i'd love to get this approved and into 6.14 (happy to do the implementation PR myself); will there be time, assuming it's approved in the meeting tomorrow?

mikemimik · 2019-11-26T18:30:23Z

@ljharb provided it gets accepted tomorrow, of course we can get this in! If you've got time to implement, then that pull-request would be welcomed with open arms. 👍

See npm/rfcs#68

ljharb · 2020-01-27T23:31:53Z

This RFC has been updated, and I've filed npm/cli#731 to implement the feature (under the presumption that this RFC will be accepted and merged in the next RFC call, absent any objections)

See npm/rfcs#68

@darcy

See npm/rfcs#68 PR-URL: #731 Credit: @ Close: #731 Reviewed-by: @darcy Clarke

tunnckoCore · 2020-02-25T21:47:47Z

+
+## Prior Art
+
+ - The `repository` field works in this same manner; it can be a string, an object, or an array of either.


Huh, definitely didn't know that! Cool. But in same time, what's the use case for array? And I'm curious how this will be shown in the npm page :D

@tunnckoCore see the RFC; but i have 200+ packages, all of which could have both the same Github Sponsors URL for me personally, and a unique Tidelift URL for the package.
It's up to npm to decide how it shows on the website; hopefully I get the chance to weigh in before they launch a change :-D

That's clear, i value that. I asked about the repository field, because didn't know it support an array.

In that case this might be a mistake on my part :-) https://docs.npmjs.com/files/package.json#repository says it can be a string or an object; I was thinking of the "author" field (which is also string or object) vs the "contributors" field (which is an array of strings-or-objects).

Hahaa. Good catch, huh?
Cool, everything is clear now :)

ljharb · 2019-11-19T01:00:40Z

What / Why

Allow the funding field, which currently can contain a string or an object, to contain an array of those things as well.

See the document for more details.

ljharb · 2019-11-26T17:50:21Z

@mikemimik i'd love to get this approved and into 6.14 (happy to do the implementation PR myself); will there be time, assuming it's approved in the meeting tomorrow?

mikemimik · 2019-11-26T18:30:23Z

@ljharb provided it gets accepted tomorrow, of course we can get this in! If you've got time to implement, then that pull-request would be welcomed with open arms. 👍

See npm/rfcs#68

ljharb · 2020-01-27T23:31:53Z

This RFC has been updated, and I've filed npm/cli#731 to implement the feature (under the presumption that this RFC will be accepted and merged in the next RFC call, absent any objections)

See npm/rfcs#68

@darcy

See npm/rfcs#68 PR-URL: #731 Credit: @ Close: #731 Reviewed-by: @darcy Clarke

tunnckoCore · 2020-02-25T21:47:47Z

+
+## Prior Art
+
+ - The `repository` field works in this same manner; it can be a string, an object, or an array of either.


Huh, definitely didn't know that! Cool. But in same time, what's the use case for array? And I'm curious how this will be shown in the npm page :D

@tunnckoCore see the RFC; but i have 200+ packages, all of which could have both the same Github Sponsors URL for me personally, and a unique Tidelift URL for the package.
It's up to npm to decide how it shows on the website; hopefully I get the chance to weigh in before they launch a change :-D

That's clear, i value that. I asked about the repository field, because didn't know it support an array.

In that case this might be a mistake on my part :-) https://docs.npmjs.com/files/package.json#repository says it can be a string or an object; I was thinking of the "author" field (which is also string or object) vs the "contributors" field (which is an array of strings-or-objects).

Hahaa. Good catch, huh?
Cool, everything is clear now :)

ljharb · 2019-11-19T01:00:40Z

What / Why

Allow the funding field, which currently can contain a string or an object, to contain an array of those things as well.

See the document for more details.

ljharb · 2019-11-26T17:50:21Z

@mikemimik i'd love to get this approved and into 6.14 (happy to do the implementation PR myself); will there be time, assuming it's approved in the meeting tomorrow?

mikemimik · 2019-11-26T18:30:23Z

@ljharb provided it gets accepted tomorrow, of course we can get this in! If you've got time to implement, then that pull-request would be welcomed with open arms. 👍

See npm/rfcs#68

ljharb · 2020-01-27T23:31:53Z

This RFC has been updated, and I've filed npm/cli#731 to implement the feature (under the presumption that this RFC will be accepted and merged in the next RFC call, absent any objections)

See npm/rfcs#68

@darcy

See npm/rfcs#68 PR-URL: #731 Credit: @ Close: #731 Reviewed-by: @darcy Clarke

tunnckoCore · 2020-02-25T21:47:47Z

+
+## Prior Art
+
+ - The `repository` field works in this same manner; it can be a string, an object, or an array of either.


Huh, definitely didn't know that! Cool. But in same time, what's the use case for array? And I'm curious how this will be shown in the npm page :D

@tunnckoCore see the RFC; but i have 200+ packages, all of which could have both the same Github Sponsors URL for me personally, and a unique Tidelift URL for the package.
It's up to npm to decide how it shows on the website; hopefully I get the chance to weigh in before they launch a change :-D

That's clear, i value that. I asked about the repository field, because didn't know it support an array.

In that case this might be a mistake on my part :-) https://docs.npmjs.com/files/package.json#repository says it can be a string or an object; I was thinking of the "author" field (which is also string or object) vs the "contributors" field (which is an array of strings-or-objects).

Hahaa. Good catch, huh?
Cool, everything is clear now :)

ljharb · 2019-11-19T01:00:40Z

What / Why

Allow the funding field, which currently can contain a string or an object, to contain an array of those things as well.

See the document for more details.

ljharb · 2019-11-26T17:50:21Z

@mikemimik i'd love to get this approved and into 6.14 (happy to do the implementation PR myself); will there be time, assuming it's approved in the meeting tomorrow?

mikemimik · 2019-11-26T18:30:23Z

@ljharb provided it gets accepted tomorrow, of course we can get this in! If you've got time to implement, then that pull-request would be welcomed with open arms. 👍

See npm/rfcs#68

ljharb · 2020-01-27T23:31:53Z

This RFC has been updated, and I've filed npm/cli#731 to implement the feature (under the presumption that this RFC will be accepted and merged in the next RFC call, absent any objections)

See npm/rfcs#68

@darcy

See npm/rfcs#68 PR-URL: #731 Credit: @ Close: #731 Reviewed-by: @darcy Clarke

tunnckoCore · 2020-02-25T21:47:47Z

+
+## Prior Art
+
+ - The `repository` field works in this same manner; it can be a string, an object, or an array of either.


Huh, definitely didn't know that! Cool. But in same time, what's the use case for array? And I'm curious how this will be shown in the npm page :D

@tunnckoCore see the RFC; but i have 200+ packages, all of which could have both the same Github Sponsors URL for me personally, and a unique Tidelift URL for the package.
It's up to npm to decide how it shows on the website; hopefully I get the chance to weigh in before they launch a change :-D

That's clear, i value that. I asked about the repository field, because didn't know it support an array.

In that case this might be a mistake on my part :-) https://docs.npmjs.com/files/package.json#repository says it can be a string or an object; I was thinking of the "author" field (which is also string or object) vs the "contributors" field (which is an array of strings-or-objects).

Hahaa. Good catch, huh?
Cool, everything is clear now :)

ljharb · 2019-11-19T01:00:40Z

What / Why

Allow the funding field, which currently can contain a string or an object, to contain an array of those things as well.

See the document for more details.

ljharb · 2019-11-26T17:50:21Z

@mikemimik i'd love to get this approved and into 6.14 (happy to do the implementation PR myself); will there be time, assuming it's approved in the meeting tomorrow?

mikemimik · 2019-11-26T18:30:23Z

@ljharb provided it gets accepted tomorrow, of course we can get this in! If you've got time to implement, then that pull-request would be welcomed with open arms. 👍

See npm/rfcs#68

ljharb · 2020-01-27T23:31:53Z

This RFC has been updated, and I've filed npm/cli#731 to implement the feature (under the presumption that this RFC will be accepted and merged in the next RFC call, absent any objections)

See npm/rfcs#68

@darcy

See npm/rfcs#68 PR-URL: #731 Credit: @ Close: #731 Reviewed-by: @darcy Clarke

tunnckoCore · 2020-02-25T21:47:47Z

+
+## Prior Art
+
+ - The `repository` field works in this same manner; it can be a string, an object, or an array of either.


Huh, definitely didn't know that! Cool. But in same time, what's the use case for array? And I'm curious how this will be shown in the npm page :D

@tunnckoCore see the RFC; but i have 200+ packages, all of which could have both the same Github Sponsors URL for me personally, and a unique Tidelift URL for the package.
It's up to npm to decide how it shows on the website; hopefully I get the chance to weigh in before they launch a change :-D

That's clear, i value that. I asked about the repository field, because didn't know it support an array.

In that case this might be a mistake on my part :-) https://docs.npmjs.com/files/package.json#repository says it can be a string or an object; I was thinking of the "author" field (which is also string or object) vs the "contributors" field (which is an array of strings-or-objects).

Hahaa. Good catch, huh?
Cool, everything is clear now :)

ljharb · 2019-11-19T01:00:40Z

What / Why

Allow the funding field, which currently can contain a string or an object, to contain an array of those things as well.

See the document for more details.

ljharb · 2019-11-26T17:50:21Z

@mikemimik i'd love to get this approved and into 6.14 (happy to do the implementation PR myself); will there be time, assuming it's approved in the meeting tomorrow?

mikemimik · 2019-11-26T18:30:23Z

@ljharb provided it gets accepted tomorrow, of course we can get this in! If you've got time to implement, then that pull-request would be welcomed with open arms. 👍

See npm/rfcs#68

ljharb · 2020-01-27T23:31:53Z

This RFC has been updated, and I've filed npm/cli#731 to implement the feature (under the presumption that this RFC will be accepted and merged in the next RFC call, absent any objections)

See npm/rfcs#68

@darcy

See npm/rfcs#68 PR-URL: #731 Credit: @ Close: #731 Reviewed-by: @darcy Clarke

tunnckoCore · 2020-02-25T21:47:47Z

+
+## Prior Art
+
+ - The `repository` field works in this same manner; it can be a string, an object, or an array of either.


Huh, definitely didn't know that! Cool. But in same time, what's the use case for array? And I'm curious how this will be shown in the npm page :D

@tunnckoCore see the RFC; but i have 200+ packages, all of which could have both the same Github Sponsors URL for me personally, and a unique Tidelift URL for the package.
It's up to npm to decide how it shows on the website; hopefully I get the chance to weigh in before they launch a change :-D

That's clear, i value that. I asked about the repository field, because didn't know it support an array.

In that case this might be a mistake on my part :-) https://docs.npmjs.com/files/package.json#repository says it can be a string or an object; I was thinking of the "author" field (which is also string or object) vs the "contributors" field (which is an array of strings-or-objects).

Hahaa. Good catch, huh?
Cool, everything is clear now :)

ljharb · 2019-11-19T01:00:40Z

What / Why

Allow the funding field, which currently can contain a string or an object, to contain an array of those things as well.

See the document for more details.

ljharb · 2019-11-26T17:50:21Z

@mikemimik i'd love to get this approved and into 6.14 (happy to do the implementation PR myself); will there be time, assuming it's approved in the meeting tomorrow?

mikemimik · 2019-11-26T18:30:23Z

@ljharb provided it gets accepted tomorrow, of course we can get this in! If you've got time to implement, then that pull-request would be welcomed with open arms. 👍

See npm/rfcs#68

ljharb · 2020-01-27T23:31:53Z

This RFC has been updated, and I've filed npm/cli#731 to implement the feature (under the presumption that this RFC will be accepted and merged in the next RFC call, absent any objections)

See npm/rfcs#68

@darcy

See npm/rfcs#68 PR-URL: #731 Credit: @ Close: #731 Reviewed-by: @darcy Clarke

tunnckoCore · 2020-02-25T21:47:47Z

+
+## Prior Art
+
+ - The `repository` field works in this same manner; it can be a string, an object, or an array of either.


Huh, definitely didn't know that! Cool. But in same time, what's the use case for array? And I'm curious how this will be shown in the npm page :D

@tunnckoCore see the RFC; but i have 200+ packages, all of which could have both the same Github Sponsors URL for me personally, and a unique Tidelift URL for the package.
It's up to npm to decide how it shows on the website; hopefully I get the chance to weigh in before they launch a change :-D

That's clear, i value that. I asked about the repository field, because didn't know it support an array.

In that case this might be a mistake on my part :-) https://docs.npmjs.com/files/package.json#repository says it can be a string or an object; I was thinking of the "author" field (which is also string or object) vs the "contributors" field (which is an array of strings-or-objects).

Hahaa. Good catch, huh?
Cool, everything is clear now :)

ljharb · 2019-11-19T01:00:40Z

What / Why

Allow the funding field, which currently can contain a string or an object, to contain an array of those things as well.

See the document for more details.

ljharb · 2019-11-26T17:50:21Z

@mikemimik i'd love to get this approved and into 6.14 (happy to do the implementation PR myself); will there be time, assuming it's approved in the meeting tomorrow?

mikemimik · 2019-11-26T18:30:23Z

@ljharb provided it gets accepted tomorrow, of course we can get this in! If you've got time to implement, then that pull-request would be welcomed with open arms. 👍

See npm/rfcs#68

ljharb · 2020-01-27T23:31:53Z

This RFC has been updated, and I've filed npm/cli#731 to implement the feature (under the presumption that this RFC will be accepted and merged in the next RFC call, absent any objections)

See npm/rfcs#68

@darcy

See npm/rfcs#68 PR-URL: #731 Credit: @ Close: #731 Reviewed-by: @darcy Clarke

tunnckoCore · 2020-02-25T21:47:47Z

+
+## Prior Art
+
+ - The `repository` field works in this same manner; it can be a string, an object, or an array of either.


Huh, definitely didn't know that! Cool. But in same time, what's the use case for array? And I'm curious how this will be shown in the npm page :D

@tunnckoCore see the RFC; but i have 200+ packages, all of which could have both the same Github Sponsors URL for me personally, and a unique Tidelift URL for the package.
It's up to npm to decide how it shows on the website; hopefully I get the chance to weigh in before they launch a change :-D

That's clear, i value that. I asked about the repository field, because didn't know it support an array.

In that case this might be a mistake on my part :-) https://docs.npmjs.com/files/package.json#repository says it can be a string or an object; I was thinking of the "author" field (which is also string or object) vs the "contributors" field (which is an array of strings-or-objects).

Hahaa. Good catch, huh?
Cool, everything is clear now :)

RFC: Multiple Funding Sources
56c8aa3

darcyclarke added Agenda will be discussed at the Open RFC call semver:minor new backwards-compatible feature Enhancement new feature or improvement Needs Discussion is pending a discussion Release 6.x labels Nov 19, 2019

ljharb mentioned this pull request Nov 20, 2019
[FEATURE] funding field as array npm/cli#503
Closed

darcyclarke mentioned this pull request Nov 21, 2019
Open RFC Meeting - Wednesday, November 27, 2019, 2:00 PM EST #70
Closed

darcyclarke mentioned this pull request Jan 8, 2020
Open RFC Meeting - Wednesday, January 8, 2020, 2:00 PM EST #87
Closed

darcyclarke assigned ruyadorno Jan 14, 2020

darcyclarke added this to the OSS - Sprint 2 milestone Jan 14, 2020

darcyclarke mentioned this pull request Jan 21, 2020
Open RFC Meeting - Wednesday, January 22, 2020, 2:00 PM EST #91
Closed

darcyclarke removed the Needs Discussion is pending a discussion label Jan 22, 2020

fixup: add bikeshed resolution
acda17f

ljharb force-pushed the multiple-funding-sources branch from 7ff7a55 to acda17fCompare January 27, 2020 23:25

ljharb added a commit to ljharb/cli that referenced this pull request Jan 27, 2020
fund: support multiple funding sources
c89c45d
See npm/rfcs#68

ljharb mentioned this pull request Jan 27, 2020
fund: support multiple funding sources npm/cli#731
Closed

ljharb added a commit to ljharb/cli that referenced this pull request Jan 27, 2020
fund: support multiple funding sources
bc98441
See npm/rfcs#68

ljharb added a commit to ljharb/cli that referenced this pull request Jan 27, 2020
fund: support multiple funding sources
88433bf
See npm/rfcs#68

darcyclarke modified the milestones: OSS - Sprint 2, OSS - Sprint 3 Jan 28, 2020

ljharb added a commit to ljharb/cli that referenced this pull request Jan 28, 2020
fund: support multiple funding sources
557a856
See npm/rfcs#68

darcyclarke mentioned this pull request Feb 5, 2020
Open RFC Meeting - Wednesday, February 5, 2020, 2:00 PM EST #99
Closed

darcyclarke merged commit 116a216 into npm:latestFeb 5, 2020

ljharb deleted the multiple-funding-sources branch February 5, 2020 19:11

darcyclarke mentioned this pull request Feb 10, 2020
Open RFC Meeting - Wednesday, February 19, 2020, 2:00 PM EST #101
Closed

ljharb added a commit to ljharb/cli that referenced this pull request Feb 19, 2020
fund: support multiple funding sources
06c5cfb
See npm/rfcs#68

darcyclarke removed the Agenda will be discussed at the Open RFC call label Feb 19, 2020

ljharb added a commit to ljharb/cli that referenced this pull request Feb 19, 2020
fund: support multiple funding sources
a764b5c
See npm/rfcs#68

darcyclarke pushed a commit to npm/cli that referenced this pull request Feb 25, 2020
fund: support multiple funding sources
30f1708
See npm/rfcs#68 PR-URL: #731 Credit: @ Close: #731 Reviewed-by: @darcy Clarke

tunnckoCore reviewed Feb 25, 2020
View reviewed changes