chore: add e18e lint plugin by 43081j · Pull Request #1019 · npmx-dev/npmx.dev

43081j · 2026-02-05T13:00:53Z

This also disables no-console since pretty much everything in this
repo can run server-side, where console logs are valuable when done
right.

vercel · 2026-02-05T13:00:57Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Feb 5, 2026 2:47pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Feb 5, 2026 2:47pm
npmx-lunaria	Ignored		Feb 5, 2026 2:47pm

codecov · 2026-02-05T13:03:30Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

coderabbitai · 2026-02-05T13:03:35Z

📝 Walkthrough

Walkthrough

Adds @e18e/eslint-plugin as a devDependency and updates .oxlintrc.json to register several e18e/* rules as error and disable no-console for specific file groups. Removes scripts/lint.ts and updates CI: install root deps (no scripts) and run pnpm lint. Small code edits: replace spread+map with Array.from(resolved.values(), ...) in server/utils/dependency-analysis.ts; extract a top-level prefixId(tagName, attribs) used by sanitizeHtml in server/utils/readme.ts; switch /readme/i.test(pathname) in test/e2e/test-utils.ts; add @e18e/eslint-plugin to knip.ts ignore list; mutate authors via Object.assign in server/api/atproto/author-profiles.get.ts.

Possibly related PRs

feat: add server side atproto blog apis #841 — Modifies server/api/atproto/author-profiles.get.ts; both PRs change how author objects are constructed there (object creation vs in-place mutation).
fix: readme rendering result lacks anchor point jump #994 — Changes server/utils/readme.ts to centralise prefixId and apply it in sanitizeHtmltransformTags (direct overlap).
chore: clean up deps & add comments to knip #849 — Updates knip.ts ignoreDependencies; both PRs add @e18e/eslint-plugin to the ignore list.

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description addresses one key aspect of the changeset—disabling no-console—but omits several significant changes including adding the e18e lint plugin, refactoring dependency analysis code, and restructuring linting infrastructure.	Expand the description to cover the full scope of changes, particularly the addition of the e18e lint plugin and the refactoring of the linting workflow infrastructure.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch jg/lint-perf

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

This also disables `no-console` since pretty much everything in this repo can run server-side, where console logs are valuable when done right.

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

server/utils/readme.ts (1)
448-452: ⚠️ Potential issue | 🟡 Minor
The section and article transforms are ineffective.
The prefixId transform is applied to section and article tags, but these tags are not included in ALLOWED_TAGS (lines 102-139). Since sanitize-html strips tags not in the allowed list, these transforms will never execute.
Either add section and article to ALLOWED_TAGS if they should be permitted, or remove them from transformTags to avoid confusion.
🔧 Option A: Remove ineffective transforms
 div: prefixId,
p: prefixId,
span: prefixId,
- section: prefixId,- article: prefixId,
},
🔧 Option B: Add tags to ALLOWED_TAGS (around line 139)
 'button',
+ 'section',+ 'article',
]

🧹 Nitpick comments (2)

.oxlintrc.json (1)
22-22: Consider removing the empty overrides array.
The empty overrides array serves no functional purpose. If it's a placeholder for future configuration, consider adding a comment to clarify intent; otherwise, it can be removed to reduce noise.
🧹 Suggested removal
- "overrides": [],
scripts/lint.ts (1)
14-16: Pre-existing issue: error message is inconsistent with actual command.
The error message references pnpm info ${dependencyName} version, but the actual command executed is npm pkg get devDependencies.${dependencyName}. Consider updating the message for accurate debugging.
📝 Suggested fix
 if (result.status) {
- throw new Error(`Command failed: pnpm info ${dependencyName} version`)+ throw new Error(`Command failed: npm pkg get devDependencies.${dependencyName}`)
}

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

scripts/lint.ts (1)
19-21: ⚠️ Potential issue | 🟡 Minor
Error message does not match the actual command.
The error message references pnpm info but the command executed on line 15 is npm pkg get. This would be misleading when debugging failures.
🐛 Proposed fix
 if (result.status) {
- throw new Error(`Command failed: pnpm info ${dependencyName} version`)+ throw new Error(`Command failed: npm pkg get devDependencies.${dependencyName}`)
}

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

scripts/lint.ts (1)
19-21: ⚠️ Potential issue | 🟡 Minor
Error message does not match the actual command.
The error message references pnpm info but the command being executed is npm pkg get. This will cause confusion when debugging failures.
🐛 Proposed fix
 if (result.status) {
- throw new Error(`Command failed: pnpm info ${dependencyName} version`)+ throw new Error(`Command failed: npm pkg get devDependencies.${dependencyName}`)
}

serhalp · 2026-02-05T14:33:15Z

 },
 "rules": {
- "no-console": "warn",
+ "no-console": "off",


I never understood the purpose of warns, so I'm good with this 😁. Longer term should we be using a li'l logger module and turning this to "error"? (maybe keep off for scripts/)

we really need to review logging overall.
only truly error-level things should be logged at error level, for example. this isn't currently the case iirc
i'll start a discussion around this 👍

would it be possible to disable this just on a per-directory case? so we disable it for server/ and cli/ but keep it for app/ ?

serhalp

LGTM

43081j · 2026-02-05T14:35:47Z

FYI this does mean the lint job can often take longer now (if it is the first to populate the cache)

but having the workaround lint.ts was causing a lot of friction and means we can't use lint plugins. we should revisit how we can speed it back up

danielroe · 2026-02-05T14:45:57Z

@43081j are you happy with those small tweaks?

43081j · 2026-02-05T14:53:18Z

looks good to me 👍

vercelBotdeployed to Preview – npmx.dev February 5, 2026 13:02 View deployment

vercelBotdeployed to Preview – docs.npmx.dev February 5, 2026 13:02 View deployment

43081j force-pushed the jg/lint-perf branch from 74fc8e0 to 9fde955Compare February 5, 2026 13:08

vercelBotdeployed to Preview – docs.npmx.dev February 5, 2026 13:09 View deployment

vercelBotdeployed to Preview – npmx.dev February 5, 2026 13:09 View deployment

43081j force-pushed the jg/lint-perf branch from 9fde955 to 5059ae0Compare February 5, 2026 13:10

vercelBotdeployed to Preview – docs.npmx.dev February 5, 2026 13:11 View deployment

vercelBotdeployed to Preview – npmx.dev February 5, 2026 13:12 View deployment

chore: add e18e lint plugin
f28d0ec
This also disables `no-console` since pretty much everything in this repo can run server-side, where console logs are valuable when done right.

43081j force-pushed the jg/lint-perf branch from 5059ae0 to f28d0ecCompare February 5, 2026 13:12

vercelBotdeployed to Preview – docs.npmx.dev February 5, 2026 13:13 View deployment

vercelBotdeployed to Preview – npmx.dev February 5, 2026 13:13 View deployment

coderabbitaiBot reviewed Feb 5, 2026
View reviewed changes

chore: use global install because dlx doesn't do the job
6bb7c9d

vercelBotdeployed to Preview – npmx.dev February 5, 2026 13:28 View deployment

chore: ppffft.
bee742f

vercelBotdeployed to Preview – npmx.dev February 5, 2026 13:34 View deployment

chore: ignore in knip
70d80b1

vercelBotdeployed to Preview – npmx.dev February 5, 2026 13:41 View deployment

vercelBotdeployed to Preview – npmx.dev February 5, 2026 13:59 View deployment

coderabbitaiBot reviewed Feb 5, 2026
View reviewed changes

chore: make this sketchy file sketchier
8f52a60

43081j force-pushed the jg/lint-perf branch from bb91a95 to 8f52a60Compare February 5, 2026 14:05

vercelBotdeployed to Preview – npmx.dev February 5, 2026 14:07 View deployment

coderabbitaiBot reviewed Feb 5, 2026
View reviewed changes

Comment threadscripts/lint.ts Outdated

chore: try a different approach
8cf4628

vercelBotdeployed to Preview – npmx.dev February 5, 2026 14:18 View deployment

serhalp reviewed Feb 5, 2026
View reviewed changes

Comment thread.github/workflows/ci.yml

serhalp reviewed Feb 5, 2026
View reviewed changes

chore: enable cache
49c95e9

serhalp approved these changes Feb 5, 2026
View reviewed changes

vercelBotdeployed to Preview – npmx.dev February 5, 2026 14:35 View deployment

danielroe approved these changes Feb 5, 2026
View reviewed changes

danielroe added 2 commits February 5, 2026 14:46

chore: update to use per-directory warning
83a644d

fix: use more performant map
7efb507

vercelBotdeployed to Preview – npmx.dev February 5, 2026 14:47 View deployment

43081j added this pull request to the merge queue Feb 5, 2026

Merged via the queue into main with commit 18bcb8aFeb 5, 2026
20 checks passed

43081j deleted the jg/lint-perf branch February 5, 2026 14:56

coderabbitaiBot mentioned this pull request Feb 7, 2026
chore: add eslint-plugin-regexp#1123
Merged

Uh oh!

Uh oh!

Conversation

43081j commented Feb 5, 2026

Uh oh!

vercelBot commented Feb 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented Feb 5, 2026

Codecov Report

Uh oh!

coderabbitaiBot commented Feb 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

serhalpFeb 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

43081jFeb 5, 2026

Choose a reason for hiding this comment

Uh oh!

danielroeFeb 5, 2026

Choose a reason for hiding this comment

Uh oh!

serhalp left a comment

Choose a reason for hiding this comment

Uh oh!

43081j commented Feb 5, 2026

Uh oh!

danielroe commented Feb 5, 2026

Uh oh!

43081j commented Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercelBot commented Feb 5, 2026•
edited
Loading

coderabbitaiBot commented Feb 5, 2026•
edited
Loading

serhalpFeb 5, 2026•
edited
Loading