Skip to content

feat(i18n): add Spanish translations for privacy page (including some missing entries) - #1036

Closed
userquin wants to merge 3 commits into
npmx-dev:mainfrom
userquin:include-privacy-spanish-translations
Closed

feat(i18n): add Spanish translations for privacy page (including some missing entries)#1036
userquin wants to merge 3 commits into
npmx-dev:mainfrom
userquin:include-privacy-spanish-translations

Conversation

@userquin

Copy link
Copy Markdown
Member

This PR includes the following missing Spanish (es-ES and es-419) translations:

  • privacy_policy.*
  • package.replacement.learn_more_above
  • package.replacement.consider_no_dep
  • package.likes.like
  • package.likes.unlike
  • package.readme.callout.note
  • package.readme.callout.tip
  • package.readme.callout.important
  • package.readme.callout.warning
  • package.readme.callout.caution
  • package.provenance_section.title
  • package.provenance_section.built_and_signed_on
  • package.provenance_section.view_build_summary
  • package.provenance_section.source_commit
  • package.provenance_section.build_file
  • package.provenance_section.public_ledger
  • package.provenance_section.transparency_log_entry
  • package.provenance_section.view_more_details
  • package.provenance_section.error_loading
  • package.downloads.community_distribution
  • badges.provenance.view_more_details
  • compare.no_dependency.label
  • compare.no_dependency.typeahead_title
  • compare.no_dependency.typeahead_description
  • compare.no_dependency.tooltip_title
  • compare.no_dependency.tooltip_description
  • compare.no_dependency.e18e_community
  • compare.no_dependency.add_column
  • compare.facets.values.up_to_you

/cc @mrcego

@vercel

vercelBot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devErrorErrorFeb 5, 2026 8:20pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 5, 2026 8:20pm
npmx-lunariaIgnoredIgnoredFeb 5, 2026 8:20pm

Request Review

@github-actions

github-actionsBot commented Feb 5, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
lunaria/files/es-419.jsonLocalization changed, will be marked as complete.
lunaria/files/es-ES.jsonLocalization changed, will be marked as complete.
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecovBot commented Feb 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request adds many new i18n translation keys across Spanish locale files (es-419.json, es.json, es-ES.json and lunaria manifests). New top-level sections include privacy_policy, provenance_section, package.readme.callout, package.replacement additions, package.links.likes, compare.selector.no_dependency and numerous UI facets/values. Changes are additive and expand nested localization objects; no function signatures or runtime APIs were modified.

Possibly related PRs

Suggested reviewers

  • Daniel Roe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly relates to the changeset, detailing specific Spanish translation additions across multiple localization files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment threadlunaria/files/es-419.json Outdated
"built_and_signed_on": "Construido y firmado en {provider}",
"view_build_summary": "Ver resumen de construcción",
"source_commit": "Commit fuente",
"build_file": "Archivo de construcción",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Archivo de compilación

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, updated at es.json

Comment threadlunaria/files/es-419.json Outdated
"view_build_summary": "Ver resumen de construcción",
"source_commit": "Commit fuente",
"build_file": "Archivo de construcción",
"public_ledger": "Libro mayor público",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registro público

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, updated at es.json

"no_dependency": {
"label": "(Sin dependencia)",
"typeahead_title": "¿Qué haría James?",
"typeahead_description": "¡Compara contra no usar una dependencia! Aprobado por e18e.",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Compara versus no usar....

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: moved typeahead_description and tooltip_description to es-419.json

"typeahead_title": "¿Qué haría James?",
"typeahead_description": "¡Compara contra no usar una dependencia! Aprobado por e18e.",
"tooltip_title": "Quizás no necesites una dependencia",
"tooltip_description": "¡Compara contra no usar una dependencia! La {link} mantiene una lista de paquetes que pueden ser reemplazados con APIs nativas o alternativas más simples.",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Compara versus no usar...

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done: moved typeahead_description and tooltip_description to es-419.json

"title": "Administración de cookies",
"p1": "Puedes configurar tu navegador para aceptar, rechazar o eliminar cookies según tus preferencias. Sin embargo, ten en cuenta que {bold}.",
"bold": "rechazar cookies esenciales puede impedir el acceso completo a la aplicación",
"p2": "A continuación se muestran enlaces con instrucciones para la administración de cookies en los navegadores más utilizados:",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gestión de cookies

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, removed from es-419.json (using es.json)

@userquin

Copy link
Copy Markdown
MemberAuthor

arggggggggg, what's doing autofix?

@userquin
userquin requested a review from mrcegoFebruary 5, 2026 20:44
@userquin

Copy link
Copy Markdown
MemberAuthor

I'm going to fix scripts/compare-translatation.ts don't merge yet

@mrcego

Copy link
Copy Markdown

I'm going to fix scripts/compare-translatation.ts don't merge yet

Going here because saw some i18n keys empty and without translations. Make sense now.

@userquin

Copy link
Copy Markdown
MemberAuthor

should be fixed once #1063 merged

@userquin

Copy link
Copy Markdown
MemberAuthor

supersede by #1175

@mrcego check changes at 1175

@userquinuserquin closed this Feb 7, 2026
@userquin
userquin deleted the include-privacy-spanish-translations branch February 7, 2026 21:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@userquin@mrcego@serhalp