Skip to content

feat(i18n,ui): add accessibility statement page - #1096

Merged
danielroe merged 11 commits into
npmx-dev:mainfrom
userquin:feat-add-a11y-statement-page
Feb 10, 2026
Merged

feat(i18n,ui): add accessibility statement page#1096
danielroe merged 11 commits into
npmx-dev:mainfrom
userquin:feat-add-a11y-statement-page

Conversation

@userquin

@userquinuserquin commented Feb 6, 2026

Copy link
Copy Markdown
Member

This PR also includes:

  • add /accessibility page at nuxt.config.ts (at routeRules with prerender true)
  • add /accessibility page at canonical redirects server middleware
  • add wcag-aa level 2.1 svg icon to public folder
  • link at footer (link with text a11y and accessibility title (we can rename the page to a11y for short)
  • add en.json, es.json and es-419.json entries (a11y.*)

@vercel

vercelBot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 10, 2026 5:17pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 10, 2026 5:17pm
npmx-lunariaIgnoredIgnoredFeb 10, 2026 5:17pm

Request Review

@github-actions

github-actionsBot commented Feb 6, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
lunaria/files/en-GB.jsonLocalization changed, will be marked as complete. 🔄️
lunaria/files/en-US.jsonSource changed, localizations will be marked as outdated.
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecovBot commented Feb 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR adds a public Accessibility page (app/pages/accessibility.vue) with i18n-driven content and SEO metadata, inserts an Accessibility link into the desktop footer and mobile header navigation, updates locale files and i18n schema with an a11y section, marks /accessibility to be prerendered in nuxt.config.ts, and registers the path in canonical-redirects middleware. No exported/public API signatures were changed.

Possibly related PRs

Suggested labels

front, a11y

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description is related to the changeset, covering key additions like the /accessibility page, routing configuration, footer link, and i18n entries.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
server/middleware/canonical-redirects.global.ts (1)

17-18: Minor: /accessibility is inserted before /about, breaking alphabetical order.

The rest of the array is sorted alphabetically. /about should precede /accessibility since "about" < "accessibility" lexicographically.

Suggested reorder
 '/200.html',
- '/accessibility',
'/about',
+ '/accessibility',
'/compare',

Comment threadapp/pages/accessibility.vue
Comment threadapp/pages/accessibility.vue Outdated
Comment threadapp/pages/accessibility.vue Outdated
Comment threadi18n/locales/es-419.json Outdated
Comment threadapp/pages/accessibility.vue Outdated

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment threadapp/pages/accessibility.vue Outdated
@knowler

knowler commented Feb 7, 2026

Copy link
Copy Markdown
Member

Marking this as a draft since we’ll need to revise this before merging it.

Namely, we should not make a conformance claim either now or, in my opinion, the future. Reason being is that currently we are not conformant and even if we did become conformant, I don’t think we currently have the people-infrastructure to maintain conformance. As WCAG states, even if we are conformant, there’s no requirement that we claim it. I think that’s a good, honest posture to have with accessibility.

I’ll make some wording suggestions over the next few days.

@knowlerknowler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is good! We can iterate on the known issues section (if there are any issues that become outstanding).

@userquin

userquin commented Feb 10, 2026

Copy link
Copy Markdown
MemberAuthor

reminder: we need to add a11y link (below privacy) on mobile menu:

image

@userquin

Copy link
Copy Markdown
MemberAuthor

@danielroe can you remove Spanish translations? I can send the translations later in another PR

@danielroe

Copy link
Copy Markdown
Member

I already removed the spanish translations when I reworded it ✅

@danielroe
danielroe added this pull request to the merge queueFeb 10, 2026
Merged via the queue into npmx-dev:main with commit 5ff2b17Feb 10, 2026
17 checks passed
@userquin
userquin deleted the feat-add-a11y-statement-page branch February 10, 2026 17:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@userquin@knowler@danielroe@mrcego