Uh oh!
There was an error while loading. Please reload this page.
feat: use default cursor for non-link items - #1153
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughRemoved the global Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/assets/main.css (1)
204-216: Good button reset and focus-visible styling.The button reset (
background: transparent; border: none; font: inherit; padding: 0;) is a standard normalisation pattern. The focus-visible rule for buttons and selects addsborder-radius: 4pxto round the focus outline, which complements the global:focus-visiblerule at lines 189-196.Note that the
outlineandoutline-offsetproperties in lines 213-214 are redundant with the global rule (lines 194-195), which uses!importantand will take precedence. Consider simplifying to only includeborder-radius: 4pxif that's the intended addition.🔧 Optional: Simplify to only the unique property
button:focus-visible, select:focus-visible { - outline: 2px solid var(--accent);- outline-offset: 2px; border-radius: 4px; }
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Removed custom button styles from main.css.
alexdln
commented
Feb 8, 2026
Hi @kalu5, you've closed the issue. Is there anything I can do to help? The code is great btw, thanks for working on it |
kalu5
commented
Feb 8, 2026
Well, I noticed that I re-based some of the previous commits and there are still some conflicts with the main branch. I will resubmit a new PR #1216 . Thank you for your attention. |
resolves#1074