Skip to content

feat(ui): add mobile buttons for package nav, and wrap badges - #1188

Merged
serhalp merged 3 commits into
mainfrom
feat/header-nav
Feb 8, 2026
Merged

feat(ui): add mobile buttons for package nav, and wrap badges#1188
serhalp merged 3 commits into
mainfrom
feat/header-nav

Conversation

@danielroe

Copy link
Copy Markdown
Member

this forced badges on to a new line, to reduce layout shift

it also moves the top sub nav bar (docs/compare/code) to a floating nav bar at the bottom on mobile:

beforeScreen Shot 2026-02-08 at 01 46 07
afterScreen Shot 2026-02-08 at 01 46 05

@vercel

vercelBot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 8, 2026 1:52am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 8, 2026 1:52am
npmx-lunariaIgnoredIgnoredFeb 8, 2026 1:52am

Request Review

@danielroedanielroe changed the title feat: add mobile buttons for package nav, and wrap badgesfeat(ui): add mobile buttons for package nav, and wrap badgesFeb 8, 2026
@danielroedanielroe added the front Frontend, Design label Feb 8, 2026
@codecov

codecovBot commented Feb 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/pages/package/[[org]]/[name].vue33.33%6 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Feb 8, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request refines layout and responsive navigation on the package detail page and its skeleton component. The skeleton's header spacing is split into horizontal and vertical gap classes, the metrics badges container is changed to a full-width basis layout, and an additional skeleton badge block was added. The package page replaces the previous inline metrics block with a desktop inline ButtonGroup and a new mobile floating bottom navigation, adjusts header gap handling, updates metrics-badges positioning, and adds CSS for the mobile nav and bottom padding.

Possibly related PRs

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly describes the changeset: forcing badges onto a new line to reduce layout shift and moving the sub navigation bar to a floating bottom navigation on mobile, supported by before/after screenshots.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/header-nav

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment threadapp/pages/package/[[org]]/[name].vue

@serhalpserhalp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

@serhalp
serhalp added this pull request to the merge queueFeb 8, 2026
Merged via the queue into main with commit e77dcf9Feb 8, 2026
20 checks passed
@serhalp
serhalp deleted the feat/header-nav branch February 8, 2026 02:59
This was referenced Feb 23, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontFrontend, Design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@serhalp