Skip to content

fix: remove block from flex elements - #1308

Merged
whitep4nth3r merged 1 commit into
npmx-dev:mainfrom
bluwy:remove-block-on-flex
Feb 10, 2026
Merged

fix: remove block from flex elements#1308
whitep4nth3r merged 1 commit into
npmx-dev:mainfrom
bluwy:remove-block-on-flex

Conversation

@bluwy

Copy link
Copy Markdown
Contributor

#1274 added the block class to flex elements, which cause the UI to look like this

image

This PR removes the block as flex is enough.

@vercel

vercelBot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 10, 2026 2:30am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 10, 2026 2:30am
npmx-lunariaIgnoredIgnoredFeb 10, 2026 2:30am

Request Review

@codecov

codecovBot commented Feb 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request removes the block CSS utility class from span elements across three Vue component files: PackageSelector.vue, DeprecatedTree.vue, and VulnerabilityTree.vue. The modifications affect the display behaviour of wrapper spans in dropdown buttons and tree headers. No logical changes, event handlers, or public APIs were altered. The changes are purely cosmetic CSS class adjustments totalling three lines modified across the three files.

Possibly related PRs

  • PR 1274: Modifies the same wrapper elements and their display classes in the identical component files, indicating overlapping scope in layout adjustments.
  • PR 1243: Updates the same UI element in PackageSelector.vue (the No Dependency option markup), though with broader refactoring involving component restructuring alongside class modifications.
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly relates to the changeset, referencing PR #1274 and explaining the removal of the block class from flex elements to fix a UI issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@Sybren-crwkSybren-crwk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, we can't indeed have flex and block on the same element

@whitep4nth3r
whitep4nth3r added this pull request to the merge queueFeb 10, 2026
Merged via the queue into npmx-dev:main with commit 4911372Feb 10, 2026
17 checks passed
@bluwy
bluwy deleted the remove-block-on-flex branch February 10, 2026 09:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bluwy@Sybren-crwk@whitep4nth3r