Skip to content

fix: overlapping watermark with rotated labels - #1361

Merged
danielroe merged 1 commit into
npmx-dev:mainfrom
vinnymac:vt/fix-snapshot
Feb 11, 2026
Merged

fix: overlapping watermark with rotated labels#1361
danielroe merged 1 commit into
npmx-dev:mainfrom
vinnymac:vt/fix-snapshot

Conversation

@vinnymac

@vinnymacvinnymac commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

When the labels are rotated they overlap with the watermark, so these changes ensure it is drawn in the appropriate area. We had shifted it when the legend was in the way, but now the legend is at the top of the chart, so this works just fine.

vue-ui-xy-6

@vercel

vercelBot commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 11, 2026 0:27am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 11, 2026 0:27am
npmx-lunariaIgnoredIgnoredFeb 11, 2026 0:27am

Request Review

@codecov

codecovBot commented Feb 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/components/Package/VersionDistribution.vue0.00%1 Missing ⚠️
app/composables/useChartWatermark.ts0.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Feb 11, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request modifies chart rendering and watermark positioning logic across two components. In the VersionDistribution component, the bottom padding calculation for charts is adjusted to use reduced values when the x-axis contains more than 10 labels, optimising space allocation. Additionally, the NPMX watermark positioning parameter is changed from 'belowDrawingArea' to 'bottom' during SVG export operations. Concurrently, the useChartWatermark composable adjusts the vertical position offset for watermarks positioned below the drawing area, shifting them downward by 10 pixels.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly explains the changes: adjusting watermark positioning to prevent overlap with rotated labels now that the legend has moved to the top of the chart.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe
danielroe added this pull request to the merge queueFeb 11, 2026
Merged via the queue into npmx-dev:main with commit 5928d54Feb 11, 2026
18 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vinnymac@danielroe