Skip to content

chore: remove vacations from lunaria and compare logic - #1441

Merged
danielroe merged 1 commit into
npmx-dev:mainfrom
userquin:chore-delete-vacations-keys
Feb 12, 2026
Merged

chore: remove vacations from lunaria and compare logic#1441
danielroe merged 1 commit into
npmx-dev:mainfrom
userquin:chore-delete-vacations-keys

Conversation

@userquin

@userquinuserquin commented Feb 12, 2026

Copy link
Copy Markdown
Member

This PR just removes vacations included at #1363 when running:

  • build:lunaria script: preparing lunaria files
  • i18n:check and i18n:check:fix scripts: check and fix translation files

This will keep translation statuses ok: without this PR we'll have missing entries for vacations.*, app/pages/recharging.vue is a temporal page that will be removed once we're back).

@vercel

vercelBot commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 12, 2026 7:42pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 12, 2026 7:42pm
npmx-lunariaIgnoredIgnoredFeb 12, 2026 7:42pm

Request Review

@github-actions

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
lunaria/files/en-GB.jsonLocalization changed, will be marked as complete.
lunaria/files/en-US.jsonSource changed, localizations will be marked as outdated.
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai

coderabbitaiBot commented Feb 12, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request removes vacation-related localization data from the English language files (en-GB.json and en-US.json), eliminating the a11y.vacations object and its nested properties. Correspondingly, the build tooling is updated to exclude the vacations key during JSON processing in the locale file preparation and translation comparison scripts, alongside the existing $schema exclusion.

Possibly related PRs

Suggested reviewers

  • shuuji3
  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check nameStatusExplanation
Merge Conflict Detection✅ Passed✅ No merge conflicts detected when merging into main
Description check✅ PassedThe PR description clearly relates to the changeset, explaining the removal of vacations keys and their purpose.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecovBot commented Feb 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe
danielroe added this pull request to the merge queueFeb 12, 2026
Merged via the queue into npmx-dev:main with commit 0a2b395Feb 12, 2026
19 checks passed
@userquin
userquin deleted the chore-delete-vacations-keys branch February 13, 2026 00:14
This was referenced Feb 22, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@userquin@danielroe