Uh oh!
There was an error while loading. Please reload this page.
fix(a11y): include latest hash and params for skip button - #1443
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis change modifies the skip link in Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
OrbisK
commented
Feb 12, 2026
|
ben-basten
commented
Feb 12, 2026
Thank you for the quick response to the issue! I just tried the deployment preview - it looks like this PR fixes the query param issue, but now focus no longer moves to the main content and stays on the skip link. So the actual "skip" never happens. |
danielroe
commented
Feb 12, 2026
merging as a hotfix but I think this is an issue with LinkBase |
Uh oh!
There was an error while loading. Please reload this page.
alexdln
commented
Feb 12, 2026
It seems that "NuxtLink" and HTML "a" behave differently in the context of hash anchors... |
OrbisK
commented
Feb 13, 2026
@ben-basten Thank you! I have fixed this in #1460 |
ben-basten
commented
Feb 13, 2026
@OrbisK That looks great, thank you!! |
fixes#1437
ensures that we keep the query and params on skip link.