Uh oh!
There was an error while loading. Please reload this page.
refactor: use buttons and links components in account menu - #1451
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request updates icon references and refactors component usage across multiple Vue files. The Bluesky icon is changed from the simple-icons set to the carbon logo set in AppHeader.vue and CallToAction.vue. The Filter/Panel.vue component's radio button selection mechanism is refactored to use TagRadioButton components with v-model binding instead of manual button markup and click handlers. Multiple components (AccountMenu.client.vue, AuthModal.client.vue, ConnectorModal.vue) replace native HTML button and anchor elements with ButtonBase and LinkBase components, introducing a new classicon prop to ButtonBase for icon handling. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
app/components/Header/AccountMenu.client.vue (1)
86-86: Consider using colon syntax for UnoCSS icons.The icon classes use dash-separated syntax (e.g.,
i-carbon-terminal,i-carbon-chevron-down). For performance optimisation with UnoCSS preset-icons, prefer the colon syntax (e.g.,i-carbon:terminal,i-carbon:chevron-down). This helps UnoCSS resolve the collection directly.Based on learnings: "In Vue components, use colon syntax for UnoCSS preset-icons (e.g.,
i-carbon:checkmarkinstead ofi-carbon-checkmark)."Also applies to: 104-104, 115-116, 164-164, 206-206, 232-237, 258-258
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This reverts commit ef77ff4.
essenmitsosse
commented
Feb 13, 2026
Sorry the |
No description provided.