Uh oh!
There was an error while loading. Please reload this page.
feat: add TanStack Start to framework list - #1523
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughA new framework entry for tanstack start is added to the SHOWCASED_FRAMEWORKS constant in app/utils/frameworks.ts. The entry includes the framework name, package identifier Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/utils/frameworks.ts (1)
73-75: Optional: Consider a type-safe alternative to the non-null assertion.The
!assertion is safe in practice becauseFrameworkPackageNameis derived from the same array, but the coding guidelines emphasise strictly type-safe code. A minor refactor could eliminate the assertion.♻️ Type-safe alternative
export function getFrameworkColor(framework: FrameworkPackageName): string { - return SHOWCASED_FRAMEWORKS.find(f => f.package === framework)!.color+ const found = SHOWCASED_FRAMEWORKS.find(f => f.package === framework)+ if (!found) {+ throw new Error(`Framework not found: ${framework}`)+ }+ return found.color }As per coding guidelines: "Ensure you write strictly type-safe code, for example by ensuring you always check when accessing an array value by index".
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tannerlinsley
commented
Feb 15, 2026
LGTM |
schiller-manuel
commented
Feb 22, 2026
this is not using the correct package. @tanstack/react-start (and soon vue) are the correct packages here @tanstack/start is stale |
farisaziz12
commented
Feb 22, 2026
Thank you, @schiller-manuel. My bad! I'll open up a PR tomorrow to point to @tanstack/react-start |
Context
TanStack Start as a framework has been gaining popularity (13.5K GH Stars). Based on that, it makes sense to add it to the homepage framework list.
I've picked the
oklchcolor based on the--color-cyan-600used on the TanStack Start page of the TanStack website.Screenshots
Desktop
Mobile
CC: @tannerlinsley, @TkDodo, @schiller-manuel