Skip to content

chore: add type constraints for icon class names - #1538

Merged
danielroe merged 4 commits into
npmx-dev:mainfrom
Yusra89hash:main
Feb 22, 2026
Merged

chore: add type constraints for icon class names#1538
danielroe merged 4 commits into
npmx-dev:mainfrom
Yusra89hash:main

Conversation

@Yusra89hash

@Yusra89hashYusra89hash commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercelBot commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 22, 2026 9:39am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 22, 2026 9:39am
npmx-lunariaIgnoredIgnoredFeb 22, 2026 9:39am

Request Review

@codecov

codecovBot commented Feb 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/pages/package/[[org]]/[name].vue0.00%2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Adds a new exported type alias IconClass (union of specific icon namespace template-literal strings) and re-exports it from app/types/index.ts. Updates components and a page to import and use IconClass instead of string for classicon props and related icon-typing, and changes a clipboard config to use a function source () => resolvedVersion.value ?? '' so the copied version is read reactively.

Possibly related PRs

Suggested reviewers

  • alexdln
🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check nameStatusExplanationResolution
Description check❓ InconclusiveThe pull request has no author-provided description, making it impossible to assess whether a description relates to the changeset.Add a pull request description that explains the purpose and scope of the type constraint changes for icon class names.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment threadapp/pages/package/[[org]]/[name].vue Outdated
@danielroedanielroe changed the title added proper typing for icon class nameschore: add type constraints for icon class names in <ButtonBase>Feb 22, 2026
@danielroedanielroe changed the title chore: add type constraints for icon class names in <ButtonBase>chore: add type constraints for icon class namesFeb 22, 2026
Comment threadapp/pages/package/[[org]]/[name].vue Outdated
@danielroe
danielroe added this pull request to the merge queueFeb 22, 2026
Merged via the queue into npmx-dev:main with commit 200875eFeb 22, 2026
16 checks passed
@github-actions

Copy link
Copy Markdown

Thanks for your first contribution, @Yusra89hash! 💥

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Yusra89hash@danielroe