chore: add generic type annotations to chart components by graphieros · Pull Request #1615 · npmx-dev/npmx.dev

graphieros · 2026-02-23T21:52:36Z

Resolves#1606

Bump vue-data-ui to 3.15.6
Use vue-data-ui generic type annotations on all charts
Remove some now useless type defs & casts that compensated missing generic types

This also fixes a remaining CLS when opening the versions modal, with other improvements:

remove translateY transition
add overlay during loading state

vercel · 2026-02-23T21:52:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Feb 23, 2026 10:24pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Feb 23, 2026 10:24pm
npmx-lunaria	Ignored		Feb 23, 2026 10:24pm

coderabbitai · 2026-02-23T22:03:44Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed0e384 and c669cc8.

📒 Files selected for processing (1)

app/components/Package/TrendsChart.vue

🚧 Files skipped from review as they are similar to previous changes (1)

app/components/Package/TrendsChart.vue

📝 Walkthrough

Walkthrough

Adds generic type annotations to chart configuration computed properties (VueUiXyConfig / VueUiSparklineConfig) across TrendsChart, VersionDistribution and WeeklyDownloadStats; tightens and adjusts imports from vue-data-ui; adds runtime guards for export callbacks (img/csv/svg); changes default theme handling and chart sizing/overlay; removes chart-container entry animation; adjusts a modal aspect-ratio; and bumps vue-data-ui from 3.15.5 to 3.15.6.

Possibly related PRs

fix: tweak versions chart config #1365: Modifies VersionDistribution.vue export callbacks and chartConfig with similar guarding and typing changes.
fix: bump vue-data-ui and impacts #1568: Applies tooltip/export guard and typing adjustments across TrendsChart, VersionDistribution and WeeklyDownloadStats alongside a vue-data-ui version bump.
chore: bump vue-data-ui from 3.14.10 to 3.15.0 #1455: Updates chartConfig/userOptions and vue-data-ui imports/types across chart components, overlapping with these changes.

Suggested labels

front

Suggested reviewers

danielroe
shuuji3

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description accurately describes the changeset, including the vue-data-ui bump, generic type annotations, removal of compensating type definitions, and CLS fixes.
Linked Issues check	✅ Passed	All objectives from `#1606` are met: vue-data-ui bumped to 3.15.6, generic type annotations added to chart configs, type defs removed, and guards added to export callbacks.
Out of Scope Changes check	✅ Passed	All changes are within scope of `#1606` objectives. The aspect-ratio adjustment in Versions.vue and runtime coercions in WeeklyDownloadStats.vue are necessary accompanying changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/components/Package/WeeklyDownloadStats.vue (1)
234-239: ⚠️ Potential issue | 🟡 Minor
Avoid passing an undefined pulse colour.
Line 238 can still resolve to undefined before CSS variables are ready, so the chart may receive an invalid colour. A fallback keeps this safe.
💡 Suggested fix
- color: pulseColor.value!,+ color: pulseColor.value ?? OKLCH_NEUTRAL_FALLBACK,

🧹 Nitpick comments (1)

package.json (1)
113-113: Lockfile already reflects the 3.15.6 bump correctly.
The pnpm-lock.yaml is up to date with vue-data-ui@3.15.6. If needed, verify the release notes directly on the npm package page or GitHub repository for any breaking changes.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ce52be and 8a72913.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (5)

app/components/Package/TrendsChart.vue
app/components/Package/VersionDistribution.vue
app/components/Package/Versions.vue
app/components/Package/WeeklyDownloadStats.vue
package.json

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/components/Package/TrendsChart.vue (1)
1518-1522: ⚠️ Potential issue | 🟡 Minor
Unsafe index access on non-array datapoint.
Line 1521 accesses datapoint[0] without verifying datapoint is an array, yielding undefined for plain objects and blanking the tooltip. This violates the coding guideline requiring strictly type-safe code.
Suggested fix
- const items = Array.isArray(datapoint) ? datapoint : [datapoint[0]]+ const items = Array.isArray(datapoint) ? datapoint : [datapoint]

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c731f28 and ed0e384.

📒 Files selected for processing (2)

app/components/Package/TrendsChart.vue
app/components/Package/VersionDistribution.vue

codecov · 2026-02-23T23:26:10Z

Codecov Report

❌ Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
app/components/Package/VersionDistribution.vue	0.00%	9 Missing and 3 partials ⚠️
app/components/Package/TrendsChart.vue	16.66%	6 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

serhalp

❤️

serhalp · 2026-02-24T00:33:05Z

do the CLS fixes resolve #1342 or is that separate?

graphieros · 2026-02-24T04:09:23Z

do the CLS fixes resolve #1342 or is that separate?

No, unfortunately I forgot this one

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

graphieros added 3 commits February 23, 2026 22:48

chore: bump vue-data-ui from 3.15.5 to 3.15.6
8b34cd8

chore: use vue-data-ui generic type annotations
2bf037c

fix: address versions modal CLS issues
8a72913

fix: remove unused import
c731f28

vercelBotdeployed to Preview – npmx.dev February 23, 2026 21:54 View deployment

vercelBotdeployed to Preview – npmx.dev February 23, 2026 21:56 View deployment

graphieros enabled auto-merge February 23, 2026 21:58

coderabbitaiBot reviewed Feb 23, 2026
View reviewed changes

Comment threadapp/components/Package/TrendsChart.vue Outdated
Comment threadapp/components/Package/VersionDistribution.vue Outdated

graphierosand others added 2 commits February 23, 2026 23:05

fix: add missing guard
57278f8
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

fix: add missing guard
ed0e384

vercelBotdeployed to Preview – npmx.dev February 23, 2026 22:08 View deployment

coderabbitaiBot reviewed Feb 23, 2026
View reviewed changes

fix: refactor
c669cc8

vercelBotdeployed to Preview – npmx.dev February 23, 2026 22:24 View deployment

serhalp approved these changes Feb 24, 2026
View reviewed changes

graphieros added this pull request to the merge queue Feb 24, 2026

Merged via the queue into npmx-dev:main with commit f4943b9Feb 24, 2026
17 checks passed

This was referenced Feb 24, 2026
fix: address CLS in downloads modal #1619
Merged
feat: fix known download anomalies with interpolation #1636
Merged
feat: generate alt text in charts #1644
Merged

alex-key pushed a commit to alex-key/npmx.dev that referenced this pull request Feb 25, 2026
chore: add generic type annotations to chart components (npmx-dev#1615)
8778be6
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

This was referenced Feb 26, 2026
feat: implement alt copy for versions chart #1660
Merged
perf: only load vue-data-ui css in components that use it #1918
Merged

coderabbitaiBot mentioned this pull request Mar 6, 2026
chore: bump vue-data-ui from 3.15.9 to 3.15.10 #1957
Merged

coderabbitaiBot mentioned this pull request Mar 12, 2026
chore: bump vue-data-ui from 3.15.11 to 3.15.12 #2040
Merged

This was referenced Mar 22, 2026
feat: charts a11y improvements #2193
Merged
feat: compare download charts with sparklines #2273
Merged

Navigation Menu

Uh oh!

Uh oh!

chore: add generic type annotations to chart components - #1615

chore: add generic type annotations to chart components#1615
graphieros merged 7 commits into
npmx-dev:mainfrom
graphieros:main

graphieros commented Feb 23, 2026•
edited
Loading

Uh oh!

vercelBot commented Feb 23, 2026•
edited
Loading

Uh oh!

coderabbitaiBot commented Feb 23, 2026•
edited
Loading

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitaiBot left a comment

Uh oh!

codecovBot commented Feb 23, 2026

Uh oh!

serhalp left a comment

Uh oh!

serhalp commented Feb 24, 2026

Uh oh!

Uh oh!

graphieros commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

graphieros commented Feb 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercelBot commented Feb 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitaiBot commented Feb 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

codecovBot commented Feb 23, 2026

Codecov Report

Uh oh!

serhalp left a comment

Choose a reason for hiding this comment

Uh oh!

serhalp commented Feb 24, 2026

Uh oh!

Uh oh!

graphieros commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

graphieros commented Feb 23, 2026•
edited
Loading

vercelBot commented Feb 23, 2026•
edited
Loading

coderabbitaiBot commented Feb 23, 2026•
edited
Loading