Uh oh!
There was an error while loading. Please reload this page.
feat: show registered anomalies as dashed segments on download charts - #1744
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis PR threads anomaly metadata through the charting stack. It adds optional Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/components/Package/TrendsChart.vue (1)
394-396: Return a strict boolean fromhasDownloadAnomalies.This computed can currently resolve to
undefined; coercing tofalseavoids tri-state behaviour in conditions.As per coding guidelines "Ensure you write strictly type-safe code, for example by ensuring you always check when accessing an array value by index".Proposed tweak
-const hasDownloadAnomalies = computed(() =>- normalisedDataset.value?.some(datapoint => !!datapoint.dashIndices.length),-)+const hasDownloadAnomalies = computed(+ () => !!normalisedDataset.value?.some(datapoint => datapoint.dashIndices.length > 0),+)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
app/components/Package/TrendsChart.vue (1)
393-396: Consider using a more explicit length check.The current
!!datapoint.dashIndices.lengthworks, but.length > 0is more explicit and reads more naturally.♻️ Optional: More explicit check
const hasDownloadAnomalies = computed(() => - normalisedDataset.value?.some(datapoint => !!datapoint.dashIndices.length),+ normalisedDataset.value?.some(datapoint => datapoint.dashIndices.length > 0), )
Uh oh!
There was an error while loading. Please reload this page.
alexdln
commented
Feb 28, 2026
I really love this change 🔥 |
Follow up to #1636