feat(ui): add subheading to weekly downloads to clarify scope by serhalp · Pull Request #1752 · npmx-dev/npmx.dev

serhalp · 2026-02-28T16:03:16Z

🔗 Linked issue

Resolves#1670

🧭 Context

The npm downloads API aggregates data at the package level only, not per version. Users could be misled when selecting a different version and seeing the same download stats. This change adds a clarifying subtitle to make this behaviour explicit upfront.

📚 Description

Added a subheading feature to the CollapsibleSection component to display secondary text below section headings. The weekly downloads section now displays "Across all versions" as a subheading below "Weekly Downloads".

Add the same to the chart modal when downloads is selected:

Clarifies that download stats are aggregated at the package level, not per version. Adds a subtitle prop to CollapsibleSection and uses it in the downloads sidebar to reduce user confusion. Closes#1670

vercel · 2026-02-28T16:03:21Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Feb 28, 2026 4:59pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Feb 28, 2026 4:59pm
npmx-lunaria	Ignored		Feb 28, 2026 4:59pm

graphieros · 2026-02-28T16:03:47Z

lol you beat me to it ^^

github-actions · 2026-02-28T16:04:12Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
lunaria/files/en-GB.json	Localization changed, will be marked as complete.
lunaria/files/en-US.json	Source changed, localizations will be marked as outdated.
lunaria/files/fr-FR.json	Localization changed, will be marked as complete.

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

codecov · 2026-02-28T16:05:12Z

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
app/components/Package/WeeklyDownloadStats.vue	50.00%	2 Missing and 2 partials ⚠️
app/components/Modal.client.vue	75.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

graphieros · 2026-02-28T16:06:14Z

I think we can add a modal-subtitle prop to chartModal too, wdyt ?

graphieros

Looks good to me ❤️

coderabbitai · 2026-02-28T16:44:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07530bb and 5426dd5.

📒 Files selected for processing (1)

app/components/Modal.client.vue

📝 Walkthrough

Walkthrough

This pull request adds subtitle support across multiple Vue components and updates localisation. It introduces an optional subtitle?: string prop to CollapsibleSection, an optional modalSubtitle?: string prop to Modal and ChartModal, and wires a computed modalSubtitle through WeeklyDownloadStats into the modal and collapsible section. Templates and ARIA attributes are updated to render and describe subtitles. i18n schema and locale files (en, en-GB, en-US, fr-FR) gain a downloads.subtitle key. Tests were updated to assert the subtitle text appears.

Possibly related PRs

fix: dialog title switch with select #1497: Modifies Package/WeeklyDownloadStats.vue and modal prop bindings, changing header/subtitle behaviour in the downloads modal.
fix(ui): hide awkward empty state for weekly downloads for new packages #1054: Touches Package/WeeklyDownloadStats.vue to adjust chart/modal rendering and guards, overlapping with modal/chart wiring changes.
feat(ui): community version distribution #1245: Updates ChartModal.vue props and template bindings, closely related to adding and passing modal subtitle props.

Suggested reviewers

graphieros
danielroe

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description clearly explains the motivation (npm API aggregates at package level), the implementation (subheading feature added to CollapsibleSection), and the visual changes with supporting screenshots.
Linked Issues check	✅ Passed	All coding requirements from issue `#1670` are met: subtitle feature added to CollapsibleSection component, subtitle integrated into WeeklyDownloadStats and ChartModal components, and clarifying text displayed in both summary and modal UI.
Out of Scope Changes check	✅ Passed	All changes directly support the objective of clarifying download aggregation scope: component modifications, prop additions, i18n translations, schema updates, and test assertions all relate to implementing the subtitle feature.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch serhalp/empty-search-subheading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5ccbff and 07530bb.

📒 Files selected for processing (11)

app/components/CollapsibleSection.vue
app/components/Modal.client.vue
app/components/Package/ChartModal.vue
app/components/Package/WeeklyDownloadStats.vue
i18n/locales/en.json
i18n/locales/fr-FR.json
i18n/schema.json
lunaria/files/en-GB.json
lunaria/files/en-US.json
lunaria/files/fr-FR.json
test/nuxt/components/PackageWeeklyDownloadStats.spec.ts

feat: add "across all versions" subtitle to weekly downloads section
c7126fe
Clarifies that download stats are aggregated at the package level, not per version. Adds a subtitle prop to CollapsibleSection and uses it in the downloads sidebar to reduce user confusion. Closes#1670

serhalp changed the title ~~feat: add 'across all versions' subtitle to weekly downloads section~~feat(ui): add subheading to weekly downloads to clarify scopeFeb 28, 2026

vercelBotdeployed to Preview – npmx.dev February 28, 2026 16:05 View deployment

feat: also add subheading to chart modal
3f68e08

vercelBotdeployed to Preview – npmx.dev February 28, 2026 16:29 View deployment

fix: improve subheading contrast
07530bb

vercelBotdeployed to Preview – npmx.dev February 28, 2026 16:37 View deployment

serhalp marked this pull request as ready for review February 28, 2026 16:40

serhalp requested a review from graphieros February 28, 2026 16:40

graphieros approved these changes Feb 28, 2026
View reviewed changes

coderabbitaiBot reviewed Feb 28, 2026
View reviewed changes

Comment threadapp/components/Modal.client.vue

fix: add subheading to SR dialog description
5426dd5

vercelBotdeployed to Preview – npmx.dev February 28, 2026 16:59 View deployment

serhalp enabled auto-merge February 28, 2026 17:00

serhalp added this pull request to the merge queue Feb 28, 2026

Merged via the queue into main with commit 80dc9beFeb 28, 2026
21 checks passed

serhalp deleted the serhalp/empty-search-subheading branch February 28, 2026 17:04

Navigation Menu

Uh oh!

Uh oh!

feat(ui): add subheading to weekly downloads to clarify scope - #1752

feat(ui): add subheading to weekly downloads to clarify scope#1752
serhalp merged 4 commits into
mainfrom
serhalp/empty-search-subheading

serhalp commented Feb 28, 2026•
edited
Loading

Uh oh!

vercelBot commented Feb 28, 2026•
edited
Loading

Uh oh!

graphieros commented Feb 28, 2026

Uh oh!

github-actionsBot commented Feb 28, 2026•
edited
Loading

Uh oh!

codecovBot commented Feb 28, 2026•
edited
Loading

Uh oh!

graphieros commented Feb 28, 2026

Uh oh!

graphieros left a comment

Uh oh!

coderabbitaiBot commented Feb 28, 2026•
edited
Loading

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

serhalp commented Feb 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

🧭 Context

📚 Description

Uh oh!

vercelBot commented Feb 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphieros commented Feb 28, 2026

Uh oh!

github-actionsBot commented Feb 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

codecovBot commented Feb 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphieros commented Feb 28, 2026

Uh oh!

graphieros left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitaiBot commented Feb 28, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

serhalp commented Feb 28, 2026•
edited
Loading

vercelBot commented Feb 28, 2026•
edited
Loading

github-actionsBot commented Feb 28, 2026•
edited
Loading

codecovBot commented Feb 28, 2026•
edited
Loading

coderabbitaiBot commented Feb 28, 2026•
edited
Loading