Skip to content

feat(a11y): add route announcer (w/ limited noise on search) - #1754

Merged
knowler merged 1 commit into
npmx-dev:mainfrom
taskylizard:feat/1751-route-announcer
Mar 1, 2026
Merged

feat(a11y): add route announcer (w/ limited noise on search)#1754
knowler merged 1 commit into
npmx-dev:mainfrom
taskylizard:feat/1751-route-announcer

Conversation

@taskylizard

Copy link
Copy Markdown
Contributor

fixes#1751

@vercel

vercelBot commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 28, 2026 4:18pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 28, 2026 4:18pm
npmx-lunariaIgnoredIgnoredFeb 28, 2026 4:18pm

Request Review

@codecov

codecovBot commented Feb 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/app.vue0.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5ccbff and 2586a40.

📒 Files selected for processing (1)
  • app/app.vue

📝 Walkthrough

Walkthrough

The change adds a NuxtRouteAnnouncer component to App.vue that handles route change announcements through a scoped slot. The component conditionally renders different text based on the active route: for the search route, it outputs a translated package title followed by " - npmx", whilst for all other routes it renders the standard route announcement message. This introduces accessibility-focused route change notifications via Nuxt's built-in announcer component.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description references issue #1751, which directly relates to adding NuxtRouteAnnouncer functionality shown in the changeset.
Linked Issues check✅ PassedThe code changes implement the NuxtRouteAnnouncer with custom logic that announces initial search route navigation while suppressing noise from subsequent result updates.
Out of Scope Changes check✅ PassedThe changes are limited to App.vue and directly address the stated objective of adding NuxtRouteAnnouncer with controlled announcement behaviour.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroedanielroe changed the title fix(a11y): limit route announcer noise on searchfeat(a11y): add route announcer (w/ limited noise on search)Mar 1, 2026

@knowlerknowler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works—thank you!

@knowler
knowler added this pull request to the merge queueMar 1, 2026
Merged via the queue into npmx-dev:main with commit 3d0ae04Mar 1, 2026
19 checks passed
@taskylizard
taskylizard deleted the feat/1751-route-announcer branch March 1, 2026 22:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add NuxtRouteAnnouncer to announce route changes

2 participants

@taskylizard@knowler