Skip to content

docs: fix outdated mention of dark mode default - #1800

Merged
danielroe merged 1 commit into
mainfrom
serhalp/fix-dark-mode-docs
Mar 1, 2026
Merged

docs: fix outdated mention of dark mode default#1800
danielroe merged 1 commit into
mainfrom
serhalp/fix-dark-mode-docs

Conversation

@serhalp

Copy link
Copy Markdown
Member

🔗 Linked issue

N/A

🧭 Context

Early on dark mode was the default. Now the default is to respect the user's system preference.

📚 Description

Replace docs card with copy about dark mode support and respecting user preferences.

@vercel

vercelBot commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devBuildingBuildingPreview, CommentMar 1, 2026 8:27pm
npmx.devBuildingBuildingPreview, CommentMar 1, 2026 8:27pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
npmx-lunariaIgnoredIgnoredMar 1, 2026 8:27pm

Request Review

@codecov

codecovBot commented Mar 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The documentation file for the index page was updated to revise the description text for the dark mode feature. The generic note was replaced with a more detailed statement describing full dark mode support and the system preference respect functionality. This is a documentation-only change affecting the content presentation without altering any code structure, control flow, or feature implementation.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly explains the context and intent: updating outdated dark mode documentation to reflect that the system now respects user preferences rather than defaulting to dark mode.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch serhalp/fix-dark-mode-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b8e8976 and b164550.

📒 Files selected for processing (1)
  • docs/content/index.md

Comment threaddocs/content/index.md
:::

:::u-page-feature{icon="i-lucide:moon" to="/guide/features" title="Enjoy dark mode" description="Dark mode by default for a better viewing experience."}
:::u-page-feature{icon="i-lucide:moon" to="/guide/features" title="Enjoy dark mode" description="Full dark mode support that respects your system preferences."}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

rg -i "dark.?mode" --type=md docs/ -C 2

Repository: npmx-dev/npmx.dev

Length of output: 1683


Fix confirmed, but consider updating related documentation elsewhere.

The description on line 48 is clear and accurately reflects that dark mode respects system preferences. However, the search revealed another documentation reference in docs/content/1.getting-started/1.introduction.md that describes a "clean, dark-mode interface", which could mislead users given the correction here. Consider reviewing and updating that reference to align with the system preference behaviour.

@danielroe
danielroe added this pull request to the merge queueMar 1, 2026
Merged via the queue into main with commit 28b4500Mar 1, 2026
21 checks passed
@danielroe
danielroe deleted the serhalp/fix-dark-mode-docs branch March 1, 2026 21:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@serhalp@danielroe