Skip to content

fix: run sparkline pulse animation only once - #1818

Merged
graphieros merged 4 commits into
npmx-dev:mainfrom
graphieros:main
Mar 2, 2026
Merged

fix: run sparkline pulse animation only once#1818
graphieros merged 4 commits into
npmx-dev:mainfrom
graphieros:main

Conversation

@graphieros

Copy link
Copy Markdown
Member

To address concerns regarding the pulse animation expressed in chat:

  • pulse animation runs only once
  • toggle button and related translations are removed

@vercel

vercelBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMar 2, 2026 8:07am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMar 2, 2026 8:07am
npmx-lunariaIgnoredIgnoredMar 2, 2026 8:07am

Request Review

@github-actions

github-actionsBot commented Mar 2, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
lunaria/files/az-AZ.jsonLocalization changed, will be marked as complete.
lunaria/files/bg-BG.jsonLocalization changed, will be marked as complete.
lunaria/files/cs-CZ.jsonLocalization changed, will be marked as complete.
lunaria/files/de-DE.jsonLocalization changed, will be marked as complete.
lunaria/files/en-GB.jsonLocalization changed, will be marked as complete.
lunaria/files/en-US.jsonSource changed, localizations will be marked as outdated.
lunaria/files/es-419.jsonLocalization changed, will be marked as complete.
lunaria/files/es-ES.jsonLocalization changed, will be marked as complete.
lunaria/files/fr-FR.jsonLocalization changed, will be marked as complete.
lunaria/files/hu-HU.jsonLocalization changed, will be marked as complete.
lunaria/files/id-ID.jsonLocalization changed, will be marked as complete.
lunaria/files/ja-JP.jsonLocalization changed, will be marked as complete.
lunaria/files/pl-PL.jsonLocalization changed, will be marked as complete.
lunaria/files/ru-RU.jsonLocalization changed, will be marked as complete.
lunaria/files/tr-TR.jsonLocalization changed, will be marked as complete.
lunaria/files/uk-UA.jsonLocalization changed, will be marked as complete.
lunaria/files/zh-CN.jsonLocalization changed, will be marked as complete.
lunaria/files/zh-TW.jsonLocalization changed, will be marked as complete.
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecovBot commented Mar 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7656f2a and 272ac2c.

📒 Files selected for processing (1)
  • app/components/Package/WeeklyDownloadStats.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/components/Package/WeeklyDownloadStats.vue

📝 Walkthrough

Walkthrough

This pull request removes the sparkline animation toggle from the WeeklyDownloadStats component and associated settings and translations. Changes: deleted the toggle logic and UI in app/components/Package/WeeklyDownloadStats.vue, hard-coded sparkline pulse.show and pulse.loop values, removed animateSparkline from the AppSettings.sidebar interface and DEFAULT_SETTINGS in app/composables/useSettings.ts, and deleted play_animation / pause_animation keys from i18n locale files, lunaria translation files and the i18n schema.

Possibly related PRs

Suggested reviewers

  • knowler
  • shuuji3
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description accurately describes the changeset, explaining that the pulse animation now runs only once and that the toggle button and related translations have been removed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@graphieros

Copy link
Copy Markdown
MemberAuthor

Note: this would require to close #1635

@graphieros
graphieros enabled auto-merge March 2, 2026 07:42
Comment threadapp/components/Package/WeeklyDownloadStats.vue Outdated
@graphieros
graphieros added this pull request to the merge queueMar 2, 2026
Merged via the queue into npmx-dev:main with commit 33e9814Mar 2, 2026
17 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@graphieros@jhroemer@danielroe