Skip to content

fix(i18n): update Japanese translations - #1860

Merged
serhalp merged 2 commits into
mainfrom
shuuji3/fix/update-japanese
Mar 3, 2026
Merged

fix(i18n): update Japanese translations#1860
serhalp merged 2 commits into
mainfrom
shuuji3/fix/update-japanese

Conversation

@shuuji3

Copy link
Copy Markdown
Member

🔗 Linked issue

N/A

🧭 Context

  • New instant search setting was added

📚 Description

  • Just updated two keys
  • (probably this is the final update before alpha-release?)

@vercel

vercelBot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devBuildingBuildingPreview, CommentMar 3, 2026 2:41am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredMar 3, 2026 2:41am
npmx-lunariaIgnoredIgnoredMar 3, 2026 2:41am

Request Review

@github-actions

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
i18n/locales/ja-JP.jsonLocalization changed, will be marked as complete.
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecovBot commented Mar 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2c29857 and 27063d9.

📒 Files selected for processing (1)
  • i18n/locales/ja-JP.json

📝 Walkthrough

Walkthrough

This pull request adds two new Japanese localization entries to the ja-JP.json file. The additions include a translation for "instant_search" and its corresponding description, which describes functionality that navigates to a search page and updates results whilst typing. The change expands the Japanese language support without modifying any control flow or error handling logic.

Suggested reviewers

  • danielroe
  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly relates to the changeset, explaining that two Japanese translation keys were updated to support a new instant search setting.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shuuji3/fix/update-japanese

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@serhalp
serhalp added this pull request to the merge queueMar 3, 2026
Merged via the queue into main with commit f8a6075Mar 3, 2026
24 checks passed
@serhalp
serhalp deleted the shuuji3/fix/update-japanese branch March 3, 2026 02:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shuuji3@serhalp