Skip to content

fix: remove getKey from bluesky-author-profiles.get.ts endpoint#1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
userquin wants to merge 6 commits into from
Closed

fix: remove getKey from bluesky-author-profiles.get.ts endpoint #1981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f82a1b
fix: remove `getKey` from `bluesky-author-profiles.get.ts` endpoint
userquin Mar 7, 2026
83ea7bf
chore: enable `nuxt-og-image` debug
userquin Mar 7, 2026
191e6a7
Revert "chore: enable `nuxt-og-image` debug"
userquin Mar 7, 2026
8642db8
chore: change wrong `tinyglobby` glob pattern
userquin Mar 7, 2026
f3bd443
chore: update `tinyglobby` glob pattern
userquin Mar 7, 2026
add6658
chore: lazy load avatar image
userquin Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/components/BlueskyComments.vue
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@ const postUrl = computed(() => data.value?.postUrl)
:src="like.actor.avatar"
:alt="like.actor.displayName || like.actor.handle"
class="w-8 h-8 rounded-full hover:opacity-80 transition-opacity m-0"
loading="lazy"
/>
<div
v-else
Expand Down
2 changes: 1 addition & 1 deletion modules/blog.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ function resolveAuthors(authors: Author[], avatarMap: Map<string, string>): Reso
* Resolves Bluesky avatars at build time.
*/
async function loadBlogPosts(blogDir: string, imagesDir: string): Promise<BlogPostFrontmatter[]> {
const files: string[] = globSync(join(blogDir, '*.md'))
const files: string[] = globSync(`${blogDir}/*.md`)

// First pass: extract raw frontmatter and collect all Bluesky handles
const rawPosts: Array<{ frontmatter: Record<string, unknown> }> = []
Expand Down
2 changes: 2 additions & 0 deletions nuxt.config.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -205,6 +205,8 @@ export default defineNuxtConfig({
compatibilityDate: '2026-01-31',

nitro: {
debug: true,
logLevel: 999,
Comment on lines +208 to +209

@coderabbitaicoderabbitaiBotMar 7, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Debug settings should be environment-gated for development only.

These settings will apply unconditionally in all environments, including production. Verbose logging (logLevel: 999) and debug mode can impact performance and may expose internal details.

Consider gating these with environment checks, similar to the pattern in modules/cache.ts (lines 15-25) which uses provider/environment checks:

🛠️ Proposed fix to conditionally apply debug settings
 nitro: {
- debug: true,- logLevel: 999,+ ...(process.env.NITRO_DEBUG === 'true' && {+ debug: true,+ logLevel: 999,+ }),
externals: {

Alternatively, use the existing isTest or check process.env.NODE_ENV:

 nitro: {
+ ...(isTest && { debug: true, logLevel: 999 }),
externals: {

@userquinuserquinMar 7, 2026•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove the entries once the error at CI fixed: I just add these entries to check the error, an ogImage failing in some blog entry

@coderabbitaicoderabbitaiBotMar 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@userquin, understood — thanks for the context! Since these are temporary additions to help diagnose the CI error, the concern about leaving them in production doesn't apply here. Feel free to remove them once the issue is resolved. 👍

🧠 Learnings used
Learnt from: alexdln
Repo: npmx-dev/npmx.dev PR: 1845
File: app/components/InstantSearch.vue:6-11
Timestamp: 2026-03-03T09:42:56.622Z
Learning: In the npmx.dev project, `onPrehydrate` callbacks consistently use `JSON.parse(localStorage.getItem('npmx-settings') || '{}')` without try-catch error handling. This is the established pattern across all components that read settings during prehydration (e.g., app/components/Settings/BgThemePicker.vue, app/components/Settings/AccentColorPicker.vue, app/components/CollapsibleSection.vue, app/components/InstantSearch.vue). Do not suggest adding try-catch blocks to this pattern unless refactoring all instances project-wide.

externals: {
inline: [
'shiki',
Expand Down
8 changes: 4 additions & 4 deletions server/api/atproto/bluesky-author-profiles.get.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,9 +73,9 @@ export default defineCachedEventHandler(
{
name: 'author-profiles',
maxAge: CACHE_MAX_AGE_ONE_DAY,
getKey: event => {
const { authors } = getQuery(event)
return `author-profiles:${authors ?? 'npmx.dev'}`
},
// getKey: event => {
// const { authors } = getQuery(event)
// return `author-profiles:${authors ?? 'npmx.dev'}`
// },
},
)
Loading