Skip to content

fix: fix og image generation errors - #1982

Merged
danielroe merged 19 commits into
npmx-dev:mainfrom
alexdln:chore/check-og-errors
Mar 7, 2026
Merged

fix: fix og image generation errors#1982
danielroe merged 19 commits into
npmx-dev:mainfrom
alexdln:chore/check-og-errors

Conversation

@alexdln

@alexdlnalexdln commented Mar 7, 2026

Copy link
Copy Markdown
Member

🧭 Context

Accumulated problems:

  • OG generation doesn't display errors
  • Tiniglobby didn't work on Windows due to Posix, so many errors were lost
  • The image didn't have dimensions, which crashed by default
  • The image was loaded in webp and written to png

Fixed and configured as it should be

@vercel

vercelBot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMar 7, 2026 11:10pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMar 7, 2026 11:10pm
npmx-lunariaIgnoredIgnoredMar 7, 2026 11:10pm

Request Review

@codecov

codecovBot commented Mar 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@alexdlnalexdln changed the title chore: check og errorsfix: fix og image generation errorsMar 7, 2026
@alexdln
alexdln marked this pull request as ready for review March 7, 2026 22:56
@coderabbitai

coderabbitaiBot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4c11c9c4-81c6-4ef4-8e57-8fae5b0cfc6c

📥 Commits

Reviewing files that changed from the base of the PR and between 7bbff92 and ba38b21.

📒 Files selected for processing (1)
  • modules/blog.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • modules/blog.ts

📝 Walkthrough

Walkthrough

This change adds explicit width="48" and height="48" attributes to avatar elements in the visible authors loop of app/components/OgImage/BlogPost.vue. In modules/blog.ts, avatar handling is switched from JPEG to PNG (fetch URL, destination extension, and served avatar path), fetch responses are validated before saving, and the Markdown glob pattern is normalised to use forward slashes on Windows.

Possibly related PRs

Suggested reviewers

  • 43081j
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly relates to the changeset by addressing OG image generation issues including avatar dimensions, image format handling, and Windows path compatibility.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1bedeae8-7da8-4666-998d-9ac78a6453d0

📥 Commits

Reviewing files that changed from the base of the PR and between 0d952fa and 7bbff92.

📒 Files selected for processing (2)
  • app/components/OgImage/BlogPost.vue
  • modules/blog.ts

Comment threadmodules/blog.ts Outdated
@danielroe
danielroe added this pull request to the merge queueMar 7, 2026
Merged via the queue into npmx-dev:main with commit b6da02dMar 7, 2026
20 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Mar 7, 2026
@coderabbitaicoderabbitaiBot mentioned this pull request Mar 17, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1Priority 1 bug (high)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexdln@danielroe@userquin