Skip to content

refactor: remove redundant title attributes from package nav - #1999

Merged
danielroe merged 1 commit into
mainfrom
knowler/the-war-on-title-attribute
Mar 9, 2026
Merged

refactor: remove redundant title attributes from package nav#1999
danielroe merged 1 commit into
mainfrom
knowler/the-war-on-title-attribute

Conversation

@knowler

@knowlerknowler commented Mar 9, 2026

Copy link
Copy Markdown
Member

This is the beginning of a iterative refactor to remove title attributes throughout the app.

These are all for the package navigation bar (on the package page). I left the title for “diff” because its description was actually descriptive (eventually it will replaced with a tooltip). You could argue that they would be useful for smaller viewports, but they don’t show up on touchscreens anyway.

Ideally, we’ll use tooltips instead of title in all situations, but our tooltip implementation is not correct (something I’ll detail more in an issue I’ll create soon, along with a proposal of how we should fix it).

Further reading:

@vercel

vercelBot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMar 9, 2026 0:02am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredMar 9, 2026 0:02am
npmx-lunariaIgnoredIgnoredMar 9, 2026 0:02am

Request Review

@knowlerknowler changed the title Remove redundant title attributesrefactor: remove redundant title attributes from package navMar 9, 2026
@coderabbitai

coderabbitaiBot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request removes :title attribute bindings from multiple UI elements in the package navigation page. The changes eliminate title attributes from the Docs, Code, and Compare navigation links, as well as from the Scroll to Top button. The modification consists of 4 lines removed with no new additions.

Possibly related PRs

  • NPM-1708: Removes native/title bindings for the Like button in the same package page file, indicating a broader pattern of removing title attribute bindings across different UI components.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly explains the purpose of removing title attributes, provides context about accessibility concerns, and references relevant standards and articles.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch knowler/the-war-on-title-attribute

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecovBot commented Mar 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe
danielroe added this pull request to the merge queueMar 9, 2026
Merged via the queue into main with commit 089a73bMar 9, 2026
24 of 25 checks passed
@danielroe
danielroe deleted the knowler/the-war-on-title-attribute branch March 9, 2026 08:04
@github-actionsgithub-actionsBot mentioned this pull request Mar 9, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@knowler@danielroe