Skip to content

fix: various chart improvements#2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Mar 9, 2026
+15 −10
Merged

fix: various chart improvements #2003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e6d545
fix: apply ellipsis to long package names in charts
graphieros Mar 9, 2026
09e2e87
fix: use same tooltip layout as other charts
graphieros Mar 9, 2026
c62a022
fix: add missing imports
graphieros Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/components/Compare/FacetBarChart.vue
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -220,13 +220,18 @@ const config = computed<VueUiHorizontalBarConfig>(() => {
const name = datapoint?.name?.replace(/\n/g, '<br>')
return `
<div class="font-mono p-3 border border-border rounded-md bg-[var(--bg)]/10 backdrop-blur-md">
<div class="flex items-center gap-2">
<div class="grid grid-cols-[12px_minmax(0,1fr)_max-content] items-center gap-x-3">
<div class="w-3 h-3">
<svg viewBox="0 0 2 2" class="w-full h-full">
<rect x="0" y="0" width="2" height="2" rx="0.3" fill="${datapoint?.color}" />
</svg>
</div>
<span>${name}: ${(datapoint as VueUiHorizontalBarDatapoint).formattedValue ?? 0}</span>
<span class="text-3xs uppercase tracking-wide text-[var(--fg)]/70 truncate">
${name}
</span>
<span class="text-base text-[var(--fg)] font-mono tabular-nums text-end">
${(datapoint as VueUiHorizontalBarDatapoint).formattedValue ?? 0}
</span>
</div>
</div>
`
Expand Down
10 changes: 5 additions & 5 deletions app/components/Package/TrendsChart.vue
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@ import type {
import { DATE_INPUT_MAX } from '~/utils/input'
import { applyDataCorrection } from '~/utils/chart-data-correction'
import { applyBlocklistCorrection, getAnomaliesForPackages } from '~/utils/download-anomalies'
import { copyAltTextForTrendLineChart, sanitise, loadFile } from '~/utils/charts'
import { copyAltTextForTrendLineChart, sanitise, loadFile, applyEllipsis } from '~/utils/charts'

import('vue-data-ui/style.css')

Expand DownExpand Up@@ -215,7 +215,7 @@ function formatXyDataset(
const temperatureColors = lightColor ? [lightColor, accent.value] : undefined

const datasetItem: VueUiXyDatasetItem = {
name: seriesName,
name: applyEllipsis(seriesName, 32),
Comment thread
graphieros marked this conversation as resolved.
type: 'line',
series: dataset.map(d => d.value),
color: accent.value,
Expand DownExpand Up@@ -1050,7 +1050,7 @@ const chartData = computed<{
.filter(index => index !== -1)

const item: VueUiXyDatasetItem = {
name: pkg,
name: applyEllipsis(pkg, 32),
type: 'line',
series,
dashIndices,
Expand DownExpand Up@@ -1111,10 +1111,10 @@ function buildExportFilename(extension: string): string {

if (!isMultiPackageMode.value) {
const name = effectivePackageNames.value[0] ?? props.packageName ?? 'package'
return `${sanitise(name)}-${g}_${range}.${extension}`
return `${sanitise(applyEllipsis(name, 32))}-${g}_${range}.${extension}`
}

const names = effectivePackageNames.value
const names = effectivePackageNames.value.map(name => applyEllipsis(name, 32))
const label = names.length === 1 ? names[0] : names.join('_')
return `${sanitise(label ?? '')}-${g}_${range}.${extension}`
}
Expand Down
6 changes: 3 additions & 3 deletions app/components/Package/VersionDistribution.vue
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@ import {
drawNpmxLogoAndTaglineWatermark,
} from '~/composables/useChartWatermark'
import TooltipApp from '~/components/Tooltip/App.vue'
import { copyAltTextForVersionsBarChart, sanitise, loadFile } from '~/utils/charts'
import { copyAltTextForVersionsBarChart, sanitise, loadFile, applyEllipsis } from '~/utils/charts'

import('vue-data-ui/style.css')

Expand DownExpand Up@@ -131,7 +131,7 @@ const dateRangeLabel = computed(() => {
function buildExportFilename(extension: string): string {
const range = dateRangeLabel.value.replaceAll(' ', '_').replaceAll(',', '')

const label = props.packageName
const label = applyEllipsis(props.packageName, 32)
return `${sanitise(label ?? '')}_${range}.${extension}`
}

Expand All@@ -141,7 +141,7 @@ const xyDataset = computed<VueUiXyDatasetItem[]>(() => {

return [
{
name: props.packageName,
name: applyEllipsis(props.packageName, 32),
series: chartDataset.value.map(item => item.downloads),
type: 'bar' as const,
color: accent.value,
Expand Down
Loading