Uh oh!
There was an error while loading. Please reload this page.
fix(ui): remove redundant calendar icons from date inputs - #2042
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemoved the calendar icon span elements that preceded the startDate and endDate inputs in TrendsChart.vue. Removed the Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alexdln
commented
Mar 12, 2026
@shuuji3 sorry, minor changes request 🙃 |
No problem! I thought I canceled the queue by approving it 😄 |
graphieros
commented
Mar 12, 2026
FIxed in https://github.com/npmx-dev/npmx.dev/pull/2037/changes |
Co-authored-by: Alex Savelyev <91429106+alexdln@users.noreply.github.com>
Co-authored-by: Alex Savelyev <91429106+alexdln@users.noreply.github.com>
marlonwq
commented
Mar 12, 2026
Wow, thanks for the quick reply! I've implemented the suggestions 🙂 |
graphieros
commented
Mar 12, 2026
I'm glad this one is in :) |
lukewarlow
commented
Mar 12, 2026
@graphieros that's not correct btw, firefox android does still have a bug but it seems related to the w-full and min-w-0 on the input. Chrome android had a separate bug that has been fixed by that patch. |

🧭 Context
Resolves#2038
📚 Description
This PR removes the manual calendar icons, preventing duplication.
🛠️ Changes
<span>icons with classi-lucide:calendar.InputBasepadding fromps-7tops-2to align text correctly after icon removal.🧪 Testing