Skip to content

fix: fix zindex issue of button in header - #2081

Merged
alexdln merged 3 commits into
npmx-dev:mainfrom
ShroXd:fix-button-zindex
Mar 16, 2026
Merged

fix: fix zindex issue of button in header#2081
alexdln merged 3 commits into
npmx-dev:mainfrom
ShroXd:fix-button-zindex

Conversation

@ShroXd

@ShroXdShroXd commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Resolves#2074

🧭 Context

CopyToClipboardButton is hidden behind the header. This PR fixes it.

FYI @alexdln

📚 Description

This button is also used in the compare page where it works fine, so the fix is applied locally rather than changing the z-index in the button component itself.

ScenarioScreenshot
Copy buttonfixed-zindex
ConnectQQ20260316-104619
Outline of compare buttonQQ20260316-104731
Outline of active menuQQ20260316-104720
Outline of non-active menuQQ20260316-104704

@vercel

vercelBot commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMar 16, 2026 11:19am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMar 16, 2026 11:19am
npmx-lunariaIgnoredIgnoredMar 16, 2026 11:19am

Request Review

@codecov

codecovBot commented Mar 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/components/Package/Header.vue50.00%1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Mar 15, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Adjusted presentation and accessibility styles in the Package Header component: added bottom padding (pb-1) to the header, lowered the sticky header container z-index from z-50 to z-10, and added focus-visible:[outline-offset:-2px]! to navigation and subheader link classes. No runtime logic, control flow, data handling, exported APIs or public signatures were changed.

Possibly related PRs

Suggested labels

front

Suggested reviewers

  • graphieros
  • shuuji3
  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly explains the issue being fixed (CopyToClipboardButton hidden behind header) and provides context, rationale, and visual evidence through screenshots.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

Comment threadapp/components/Package/Header.vue Outdated
@alexdln
alexdln added this pull request to the merge queueMar 16, 2026
@alexdln

Copy link
Copy Markdown
Member

Perfect, thank you ❤️

Merged via the queue into npmx-dev:main with commit 82ab52cMar 16, 2026
21 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Mar 16, 2026
@ShroXd
ShroXd deleted the fix-button-zindex branch March 16, 2026 11:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual issues with recently reworked package header

2 participants

@ShroXd@alexdln