Skip to content

fix: fetch resolved version for install size - #2086

Merged
serhalp merged 1 commit into
npmx-dev:mainfrom
gameroman:install-size-version
Mar 15, 2026
Merged

fix: fetch resolved version for install size#2086
serhalp merged 1 commit into
npmx-dev:mainfrom
gameroman:install-size-version

Conversation

@gameroman

@gameromangameroman commented Mar 15, 2026

Copy link
Copy Markdown
Member

Fixes package install size resolution by fetching resolved version for install size

Example: https://npmx.dev/package/fd-package-json/v/%5E2.0.0

Before:

image

After:

image

@vercel

vercelBot commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMar 15, 2026 1:31pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMar 15, 2026 1:31pm
npmx-lunariaIgnoredIgnoredMar 15, 2026 1:31pm

Request Review

@codecov

codecovBot commented Mar 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/pages/package/[[org]]/[name].vue0.00%3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 27206382-9b16-4111-9f2f-6f714ccf5641

📥 Commits

Reviewing files that changed from the base of the PR and between 9342f6c and 06247cb.

📒 Files selected for processing (1)
  • app/pages/package/[[org]]/[name].vue

📝 Walkthrough

Walkthrough

The change modifies the package page component to defer install size data fetching. Instead of fetching immediately when the component mounts, the fetch is now triggered by a watcher that observes the resolvedVersion and resolvedStatus properties. The fetch only executes when a valid resolved version exists and the resolution status is 'success', with initial evaluation enabled. This alters when and under what conditions the install size data is requested.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Description check⚠️ WarningThe pull request has no description provided by the author, making it impossible to assess the intent and context of the changes.Add a pull request description explaining the rationale for the changes, the problem being solved, and how the watch-based trigger improves the install size fetching logic.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@serhalpserhalp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooooh was that why? thanks for fixing!

👀 do we have the same bug on the compare page?

@serhalp
serhalp added this pull request to the merge queueMar 15, 2026
Merged via the queue into npmx-dev:main with commit 6e8f2b2Mar 15, 2026
21 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Mar 15, 2026
@gameroman
gameroman deleted the install-size-version branch March 15, 2026 14:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gameroman@serhalp