Skip to content

fix: normalize metrics language across possible values - #2138

Merged
danielroe merged 1 commit into
npmx-dev:mainfrom
bnb:bnb/update-esm-and-types-in-en-locale
Mar 18, 2026
Merged

fix: normalize metrics language across possible values#2138
danielroe merged 1 commit into
npmx-dev:mainfrom
bnb:bnb/update-esm-and-types-in-en-locale

Conversation

@bnb

@bnbbnb commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

resolves#2131

🧭 Context

Tiny change to normalize a few strings just to bring the structure of what's being communicated in-line so it's consistent across the board.

Normalizes two strings into the same formats as their peers.

📚 Description

Currently, the tooltip for ESM says No ESM Support if there is no ESM but ESM Supported if there is ESM. CJS Says CJS Supported. This PR normalizes the first to be ESM Supported so it's consistent with the others.

The tooltops for Types are Types included, Types available via {package}, and No TypeScript types. This PR normalizes the last to be the same as the other two and changes it to No types.

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMar 18, 2026 6:54pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMar 18, 2026 6:54pm
npmx-lunariaIgnoredIgnoredMar 18, 2026 6:54pm

Request Review

@bnb

bnb commented Mar 18, 2026

Copy link
Copy Markdown
ContributorAuthor

definitely didn't open this against my own fork first; if you saw that no you didn't 🤫

@github-actions

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
i18n/locales/en.jsonSource changed, localizations will be marked as outdated.
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecovBot commented Mar 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8beb0f8a-eddb-4a7b-b9a2-0b28051a7e0a

📥 Commits

Reviewing files that changed from the base of the PR and between 77c4570 and 3cb2a58.

📒 Files selected for processing (1)
  • i18n/locales/en.json

📝 Walkthrough

Walkthrough

The pull request updates localisation strings in the English language JSON file. Two metric-related strings are modified: the ES Modules support message is changed from "No ES Modules support" to "ES Modules unsupported", and the TypeScript types support message is changed from "No TypeScript types" to "No types". These changes are made to improve consistency across the localisation values for metrics support indicators.

Suggested reviewers

  • 9romise
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe PR description clearly relates to the changeset, explaining the normalisation of two localisation strings for ESM and Types tooltips.
Linked Issues check✅ PassedThe PR directly addresses all requirements from issue #2131: normalises ESM tooltip from 'No ESM Support' to 'ESM Supported' and changes Types tooltip from 'No TypeScript types' to 'No types'.
Out of Scope Changes check✅ PassedAll changes are limited to the English localisation file with only the two specified tooltip strings modified, remaining entirely within the scope of issue #2131.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

@danielroedanielroe changed the title doc: normalize metrics language across possible valuesfix: normalize metrics language across possible valuesMar 18, 2026
@danielroe
danielroe added this pull request to the merge queueMar 18, 2026
Merged via the queue into npmx-dev:main with commit 5d8fcf5Mar 18, 2026
20 of 21 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Mar 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

English Localization for ESM and Types support should be consistent across possible values

2 participants

@bnb@danielroe