Skip to content

ci: use voidzero-dev/setup-vp instead of setup-node + pnpm/action-setup - #2145

Merged
ghostdevv merged 23 commits into
npmx-dev:mainfrom
fengmk2:use-setup-vp-instead
Apr 4, 2026
Merged

ci: use voidzero-dev/setup-vp instead of setup-node + pnpm/action-setup#2145
ghostdevv merged 23 commits into
npmx-dev:mainfrom
fengmk2:use-setup-vp-instead

Conversation

@fengmk2

@fengmk2fengmk2 commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

#2129

🧭 Context

Replace the two-step setup pattern (actions/setup-node + pnpm/action-setup + pnpm install) with the unified voidzero-dev/setup-vp action across all CI workflows. This simplifies setup to a single step with node-version, cache, and automatic dependency installation via vp.

  • Replace all pnpm vp commands with vp directly
  • Build storybook via vp before passing to chromatic action
  • Migrating .github/workflows/chromatic.yml to setup-vp will fail, so skip it for now.

📚 Description

The time for installing node and dependencies after switching will not be significantly different from before.

@vercel

vercelBot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devReadyReadyPreview, CommentApr 4, 2026 7:08pm
npmx.devReadyReadyPreview, CommentApr 4, 2026 7:08pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
npmx-lunariaIgnoredIgnoredApr 4, 2026 7:08pm

Request Review

@codecov

codecovBot commented Mar 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR updates five GitHub Actions workflows (.github/workflows/autofix.yml, ci.yml, lunaria.yml, release-pr.yml, release-tag.yml) to replace actions/setup-node and pnpm/action-setup plus explicit pnpm install steps with voidzero-dev/setup-vp@v1 configured with node-version: lts/* and action-level caching where enabled. Invocation of dependency/install/build commands was switched from pnpm ... / pnpm vp ... to vp ... / vp install ..., and some jobs set run-install: false or adjusted install scopes. No source-code exports or public API declarations were changed.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly relates to the changeset, explaining the replacement of the two-step setup pattern with voidzero-dev/setup-vp and the command changes across CI workflows.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9c3bd404-b7d1-4d49-8353-e0d2b01d1d7c

📥 Commits

Reviewing files that changed from the base of the PR and between 5d8fcf5 and 3285237.

📒 Files selected for processing (6)
  • .github/workflows/autofix.yml
  • .github/workflows/chromatic.yml
  • .github/workflows/ci.yml
  • .github/workflows/lunaria.yml
  • .github/workflows/release-pr.yml
  • .github/workflows/release-tag.yml

Comment thread.github/workflows/ci.yml
Comment thread.github/workflows/ci.yml
Comment thread.github/workflows/release-tag.yml Outdated
@fengmk2
fengmk2 marked this pull request as draft March 19, 2026 11:45
@fengmk2

This comment was marked as resolved.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

♻️ Duplicate comments (1)
.github/workflows/ci.yml (1)

37-37: ⚠️ Potential issue | 🔴 Critical

vp run lint and vp run knip still appear to target missing scripts.

Line 37 and Line 164 will fail if package.json does not define lint/knip scripts (only lint:fix/knip:fix). This was already raised earlier and still appears unresolved.

#!/bin/bashset -euo pipefail
echo"=== Workflow commands in CI ==="
rg -n 'run:\s*vp run (lint|knip)' .github/workflows/ci.yml
echo"=== Matching scripts in root package.json ==="
jq -r '.scripts | keys[]' package.json | rg '^(lint|lint:fix|knip|knip:fix)$'||trueecho"=== Explicit values for candidate scripts ==="
jq -r '.scripts["lint"], .scripts["lint:fix"], .scripts["knip"], .scripts["knip:fix"]' package.json

Also applies to: 164-164


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca1ba98c-d702-4124-bb0b-d31995e64c23

📥 Commits

Reviewing files that changed from the base of the PR and between 3285237 and 9102ca2.

📒 Files selected for processing (5)
  • .github/workflows/autofix.yml
  • .github/workflows/ci.yml
  • .github/workflows/lunaria.yml
  • .github/workflows/release-pr.yml
  • .github/workflows/release-tag.yml
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/lunaria.yml
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/autofix.yml
  • .github/workflows/release-tag.yml

Comment thread.github/workflows/ci.yml Outdated
Replace the two-step setup pattern (actions/setup-node + pnpm/action-setup +
pnpm install) with the unified voidzero-dev/setup-vp action across all CI
workflows. This simplifies setup to a single step with node-version, cache,
and automatic dependency installation via vp.
- Replace all pnpm vp commands with vp directly
- Build storybook via vp before passing to chromatic action
Add run-install: false and manual vp install --filter . --ignore-scripts
for lint, i18n, and tag jobs to match original behavior and avoid running
heavy postinstall tasks (generate:lexicons, generate:sprite, nuxt prepare)
in jobs that don't need them.
Cache is unnecessary when only installing root deps with --ignore-scripts.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/release-tag.yml (1)

97-101: Keep the publish job on an explicit connector-only install.

setup-vp defaults run-install to true, so this step now does a root-level install before the connector build. That drops the previous connector-only scoping and pulls the workspace root postinstall into the npm publish path, which adds unrelated work and failure modes to a release job. I’d keep auto-install off here and restore the explicit filtered install step instead. (raw.githubusercontent.com)

💡 Minimal change
 - uses: voidzero-dev/setup-vp@73e69397a8b289de4b1d017ced18e18004183bb1 # v1
with:
node-version: lts/*
cache: true
registry-url: https://registry.npmjs.org
+ run-install: false

Then restore the previous connector-only install step before the build.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c006621f-ef6c-421c-8392-386888fe02b3

📥 Commits

Reviewing files that changed from the base of the PR and between 586deee and 4a7dbed.

📒 Files selected for processing (5)
  • .github/workflows/autofix.yml
  • .github/workflows/ci.yml
  • .github/workflows/lunaria.yml
  • .github/workflows/release-pr.yml
  • .github/workflows/release-tag.yml
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/ci.yml
  • .github/workflows/autofix.yml

@fengmk2
fengmk2 requested a review from ghostdevvMarch 20, 2026 08:42
Chromatic action runs `pnpm run build-storybook` internally, which
fails with ENOENT when pnpm is not available. Add `vp install -g pnpm`
after setup-vp to ensure pnpm is on PATH.
@fengmk2

Copy link
Copy Markdown
ContributorAuthor

@ghostdevv Temporarily install pnpm globally via vp i -g pnpm, and I will follow up this at voidzero-dev/setup-vp#27

kodiakhqBot pushed a commit to wolfstar-project/wolfstar.rocks that referenced this pull request Apr 4, 2026
…up (#109)
## What
Replace the two-step setup pattern (\`actions/setup-node\` +
\`pnpm/action-setup\` + \`pnpm install\`) with the unified
\`voidzero-dev/setup-vp\` action across all CI workflows.
## Why
Simplifies CI setup to a single step with \`node-version\`, \`cache\`,
and automatic dependency installation via \`vp\`. Based on
[npmx-dev/npmx.dev#2145](npmx-dev/npmx.dev#2145).
## Changes
- **continuous-integration.yml**: 7 jobs migrated (lint, unit, test,
browser, benchmark, a11y, knip)
- **autofix.yml**: Replaced 3-step setup with single \`setup-vp\`
- **release-tag.yml**: Replaced \`setup-node\` + \`pnpm/action-setup\`
with \`setup-vp\`
- **release-pr.yml**: Replaced \`setup-node\` with \`setup-vp\`
### Key patterns
- \`cache: true\` for jobs needing full dependency install (auto-runs
\`vp install\`)
- \`run-install: false\` for jobs with partial install (\`vp install
--filter . --ignore-scripts\`)
- \`pnpm vp run/test/exec\` -> \`vp run/test/exec\`
- Pinned to \`v1.6.0\` (\`8ecb3917\`)
## Impact
CI-only change. No runtime code changes.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Updated CI/CD workflow tooling and infrastructure configurations
across automated build and testing pipelines to improve consistency and
efficiency.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

@ghostdevvghostdevv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it!

@ghostdevv
ghostdevv added this pull request to the merge queueApr 4, 2026
Merged via the queue into npmx-dev:main with commit af6a590Apr 4, 2026
20 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Apr 4, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fengmk2@ghostdevv