Uh oh!
There was an error while loading. Please reload this page.
fix: use displayVersion instead of pkg - #2186
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe license display logic across two components has been updated to prefer the displayed version's license information over the package's default license. In both 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ghostdevv
left a comment
There was a problem hiding this comment.
Ideally we fix this where we're loading the packument from the registry, since presumably we're either getting license from the top level of the packument which is just referring to latest. We should be getting license, and most other data, from the packument version instead if that makes sense?
Flo0806
commented
Mar 21, 2026
displayVersion resolves always the current license, doesn't it? From this it works as well for me with this fix. Did I overlook anything? |
RYGRIT
commented
Mar 25, 2026
Perhaps she meant to directly handle the |
ghostdevv
commented
Mar 25, 2026
apologies for the delay, but yea! like ideally when we're actually getting this data from the registry we'd use the correct field. It could be more complicated than it seems though, I haven't had the time to actually poke around to see how, so let me know if it's not possible with our current setup. But then this would also hopefully fix stuff like the og images using the wrong license that was also reported in the original issue. |
Flo0806
commented
Mar 26, 2026
I'll have a look 🙏 |
🔗 Linked issue
Fixes: #2163
🧭 Context
If you switch to older/other versions in a package which have a different version the version doesn't change
📚 Description
Problem is the loaded packages (latest/current version) was used to show license informations. Now we use the
displayVersionfor that and we now always see the current license.