feat: add a warning when the package license changes by aisiklar · Pull Request #2188 · npmx-dev/npmx.dev

aisiklar · 2026-03-21T23:23:41Z

🔗 Linked issue

🧭 Context

added info/warning beneath the license info, "changed!" if there is a change in the license with additional tooltip which shows info about the change, similar to "from x to y at version a.b".
Also modified the Turkish language support too.

📚 Description

as mentioned in the issue, sometimes license changes and it is important to notify the potential user of the package. This pull request is done to make sure that if there is a change in the license the user will be able to see it and also will get info about the details of the change (like from x license to y license and at version a.b.c)

The following changes are done to the codebase:
modified the [name].vue file: added a new props to LicenseDisplay component.
new composable, useLicenseChanges is written.
In the LicenseDisplay component, changes were made to use this composable and add new element for displaying info about the changed license.
Additionally, en.json and tr-TR.json and schema.json files are modified, to add i18n infrastructure and add Turkish language support (for other languages, additional changes are required)

before:

after:

… language too.

vercel · 2026-03-21T23:23:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	May 2, 2026 10:44am

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	May 2, 2026 10:44am
npmx-lunaria	Ignored		May 2, 2026 10:44am

github-actions · 2026-03-21T23:24:27Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
i18n/locales/en.json	Source changed, localizations will be marked as outdated.
i18n/locales/tr-TR.json	Localization changed, will be marked as complete. 🔄️

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

coderabbitai · 2026-03-21T23:25:33Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

This change introduces a license-change detection and notification system for package versions. A new composable fetches npm registry metadata for a given package, extracts and chronologically sorts all versions, then compares licenses between consecutive versions to identify transitions. When changes are detected, they are displayed via a warning component that renders an amber alert panel with formatted change details. Supporting internationalization strings have been added to the schema and locale files in English and Turkish.

Suggested reviewers

danielroe
trueberryless

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The pull request description clearly relates to the changeset, explaining the implementation of license change detection and warning UI.
Linked Issues check	✅ Passed	All primary objectives from issue `#1826` are met: detecting license changes, surfacing visible indicators, and providing contextual details.
Out of Scope Changes check	✅ Passed	All changes are directly aligned with the linked issue; no out-of-scope modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ghostdevv

Could you do the style similar to the package size increase warning that we have? #1673 Let me know if you have any questions or need any help!

coderabbitai

Actionable comments posted: 3

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f7c1c88e-8b86-4447-9fdb-bfbc10c1ff70

📥 Commits

Reviewing files that changed from the base of the PR and between 4294ada and bfd9550.

📒 Files selected for processing (6)

app/components/LicenseDisplay.vue
app/composables/useLicenseChanges.ts
app/pages/package/[[org]]/[name].vue
i18n/locales/en.json
i18n/locales/tr-TR.json
i18n/schema.json

aisiklar · 2026-03-23T04:03:28Z

Could you do the style similar to the package size increase warning that we have? #1673 Let me know if you have any questions or need any help!

hi @ghostdevv
thanks for your comment. I will check the link you mentioned and also the comments made by coderabbitai and change accordingly. I will return you in case i have additional questions. Thanks.

ghostdevv · 2026-03-23T04:31:05Z

Awesome! I'll mark this as draft for now, and you can mark it as ready when you want me to take another look!

codecov · 2026-03-24T04:25:59Z

Codecov Report

❌ Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
app/composables/useLicenseChanges.ts	0.00%	6 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

…sorting versions to date of release

aisiklar · 2026-03-24T05:08:18Z

Hi @ghostdevv
Can you please check again?
I made the style change and also fixed the other issues pointed by bot.
I did NOT rebase on the current state of main, if you want, i can do it and make a new commit. This is my first PR so please advice if I am missing some other things.
Thanks

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 274b5e5e-8053-43ca-946d-f111b04b96f3

📥 Commits

Reviewing files that changed from the base of the PR and between bfd9550 and ecbb660.

📒 Files selected for processing (5)

app/components/LicenseDisplay.vue
app/composables/useLicenseChanges.ts
i18n/locales/en.json
i18n/locales/tr-TR.json
i18n/schema.json

✅ Files skipped from review due to trivial changes (2)

i18n/locales/en.json
i18n/schema.json

🚧 Files skipped from review as they are similar to previous changes (2)

i18n/locales/tr-TR.json
app/composables/useLicenseChanges.ts

ghostdevv · 2026-03-25T18:45:05Z

 aria-hidden="true"
 />
 </span>
+ <div


Hey, the warning should be here like the package size increase one

ghostdevv · 2026-03-25T18:47:42Z

+ let prevLicense: string | undefined = undefined
+
+ // `data.versions` is an object with version keys
+ const versions = Object.values(data.versions) as NpmRegistryVersion[]


I think we should only compare to the last version, there is some logic here that could be reused (you can move it into its own utility file in shared too
npmx.dev/app/composables/useInstallSizeDiff.ts
Lines 19 to 39 in 1dd1be9
functiongetComparisonVersion(pkg: SlimPackument,resolvedVersion: string): string|null{
constisCurrentPrerelease=prerelease(resolvedVersion)!==null
if(isCurrentPrerelease){
constlatest=pkg['dist-tags']?.latest
if(!latest||latest===resolvedVersion)returnnull
returnlatest
}
// Find the previous version in time that was stable
conststableVersions=Object.keys(pkg.time)
.filter(v=>v!=='modified'&&v!=='created'&&valid(v)!==null&&prerelease(v)===null)
.sort((a,b)=>compare(a,b))
constcurrentIdx=stableVersions.indexOf(resolvedVersion)
// Don't compare the second version against the first as the first
// has no baseline so a large size difference is expected
if(currentIdx<=1)returnnull
returnstableVersions[currentIdx-1]!
}

aisiklar · 2026-03-27T15:09:33Z

Hi @ghostdevv thanks for the comments. I am working on them.

…pdated in license-change api

gameroman

Looks good 👍

Probably better to merge after #2662

Co-authored-by: Roman <dev@rman.dev>

aisiklar · 2026-05-02T08:02:09Z

Looks good 👍
Probably better to merge after #2662

thanks for the fix @gameroman

addressed, approved by another maintainer

github-actions · 2026-05-09T16:25:21Z

Thanks for your first contribution, @aisiklar! 🤩

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Willow (GHOST) <git@willow.sh> Co-authored-by: James Garbutt <43081j@users.noreply.github.com> Co-authored-by: Roman <dev@rman.dev>

1826-add a warning and info for license changes. Added support for TR…
3a0543f
… language too.

[autofix.ci] apply automated fixes
bfd9550

aisiklar mentioned this pull request Mar 21, 2026
highlight license changes #1826
Closed
3 tasks

ghostdevv changed the title ~~1826-add a warning and info for license changes. Added support for TR language too.~~feat: add a warning when the package license changesMar 21, 2026

vercelBotdeployed to Preview – npmx.dev March 21, 2026 23:27 View deployment

ghostdevv requested changes Mar 21, 2026
View reviewed changes

coderabbitaiBot reviewed Mar 21, 2026
View reviewed changes

Comment threadapp/components/LicenseDisplay.vue Outdated
Comment threadapp/components/LicenseDisplay.vue Outdated
Comment threadapp/composables/useLicenseChanges.ts Outdated

ghostdevv marked this pull request as draft March 23, 2026 04:31

aisiklarand others added 2 commits March 24, 2026 04:22

fix:warning style changed and unintended chars erased
fa52bff

[autofix.ci] apply automated fixes
bd4ebe5

vercelBotdeployed to Preview – npmx.dev March 24, 2026 04:25 View deployment

aisiklarand others added 2 commits March 24, 2026 05:02

fix:added TR language support for warning text and changed logic for …
9afe21d
…sorting versions to date of release

[autofix.ci] apply automated fixes
ecbb660

vercelBotdeployed to Preview – npmx.dev March 24, 2026 05:06 View deployment

aisiklar marked this pull request as ready for review March 24, 2026 07:13

coderabbitaiBot reviewed Mar 24, 2026
View reviewed changes

Comment threadapp/components/LicenseDisplay.vue Outdated
Comment threadapp/components/LicenseDisplay.vue Outdated

fix: removed the vue-118n import and used autoimported
b91aab5

vercelBotdeployed to Preview – npmx.dev March 24, 2026 07:52 View deployment

ghostdevv requested changes Mar 25, 2026
View reviewed changes

Merge branch 'main' into feature/1826_license_changes
34b84c5

vercelBotdeployed to Preview – docs.npmx.dev March 25, 2026 18:50 View deployment

vercelBotdeployed to Preview – npmx.dev March 25, 2026 18:50 View deployment

ghostdevv previously requested changes Apr 13, 2026
View reviewed changes

Comment threadserver/api/registry/license-change/[...pkg].get.ts

custom key added to useFetch function in useLicenseChange, comments u…
db9c4ed
…pdated in license-change api

vercelBotdeployed to Preview – npmx.dev April 15, 2026 08:06 View deployment

serhalp requested a review from ghostdevv April 20, 2026 00:54

serhalp added the needs review This PR is waiting for a review from a maintainer label Apr 20, 2026

gameroman requested changes Apr 30, 2026
View reviewed changes

Comment threadi18n/locales/en.json Outdated

Update i18n/locales/en.json
386460d
Co-authored-by: Roman <dev@rman.dev>

vercelBotdeployed to Preview – npmx.dev May 2, 2026 08:03 View deployment

43081j reviewed May 2, 2026
View reviewed changes

Comment threadserver/api/registry/license-change/[...pkg].get.ts Outdated

43081j reviewed May 2, 2026
View reviewed changes

Comment threadserver/api/registry/license-change/[...pkg].get.ts Outdated

43081j approved these changes May 2, 2026
View reviewed changes

chore: reuse fetchNpmPackage
24ebc75

43081j enabled auto-merge May 2, 2026 10:42

43081j approved these changes May 2, 2026
View reviewed changes

vercelBotdeployed to Preview – npmx.dev May 2, 2026 10:44 View deployment

43081j added this pull request to the merge queue May 9, 2026

Merged via the queue into npmx-dev:main with commit 42fb7b0May 9, 2026
22 checks passed

github-actionsBot mentioned this pull request May 9, 2026
chore: release v0.11.0 #2670
Merged

serhalp added this to the release: crystal chronicle (v0.11) milestone May 11, 2026

github-project-automationBot added this to Releases May 11, 2026

github-project-automationBot moved this from Backlog to In progress in Releases May 11, 2026

github-project-automationBot moved this from In progress to Released in Releases May 11, 2026

github-project-automationBot moved this to Backlog in Releases May 11, 2026

coderabbitaiBot mentioned this pull request May 12, 2026
fix: avoid false license-change warning on first release #2722
Closed

ghostdevv removed the needs review This PR is waiting for a review from a maintainer label May 31, 2026

	functiongetComparisonVersion(pkg: SlimPackument,resolvedVersion: string): string\|null{
	constisCurrentPrerelease=prerelease(resolvedVersion)!==null

	if(isCurrentPrerelease){
	constlatest=pkg['dist-tags']?.latest
	if(!latest\|\|latest===resolvedVersion)returnnull
	returnlatest
	}

	// Find the previous version in time that was stable
	conststableVersions=Object.keys(pkg.time)
	.filter(v=>v!=='modified'&&v!=='created'&&valid(v)!==null&&prerelease(v)===null)
	.sort((a,b)=>compare(a,b))

	constcurrentIdx=stableVersions.indexOf(resolvedVersion)
	// Don't compare the second version against the first as the first
	// has no baseline so a large size difference is expected
	if(currentIdx<=1)returnnull

	returnstableVersions[currentIdx-1]!
	}

Uh oh!

Uh oh!

Conversation

aisiklar commented Mar 21, 2026

🔗 Linked issue

🧭 Context

📚 Description

Uh oh!

vercelBot commented Mar 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Mar 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

coderabbitaiBot commented Mar 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Suggested reviewers

Uh oh!

ghostdevv left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aisiklar commented Mar 23, 2026

Uh oh!

ghostdevv commented Mar 23, 2026

Uh oh!

codecovBot commented Mar 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aisiklar commented Mar 24, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ghostdevvMar 25, 2026

Choose a reason for hiding this comment

Uh oh!

ghostdevvMar 25, 2026

Choose a reason for hiding this comment

Uh oh!

aisiklar commented Mar 27, 2026

Uh oh!

Uh oh!

gameroman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aisiklar commented May 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercelBot commented Mar 21, 2026•
edited
Loading

github-actionsBot commented Mar 21, 2026•
edited
Loading

coderabbitaiBot commented Mar 21, 2026•
edited
Loading

ghostdevv left a comment •
edited
Loading

codecovBot commented Mar 24, 2026•
edited
Loading

aisiklar commented Mar 24, 2026•
edited
Loading