Skip to content

fix(i18n): add missing translations for hi-IN - #2254

Merged
ghostdevv merged 3 commits into
npmx-dev:mainfrom
trivikr:hi-IN
Mar 24, 2026
Merged

fix(i18n): add missing translations for hi-IN#2254
ghostdevv merged 3 commits into
npmx-dev:mainfrom
trivikr:hi-IN

Conversation

@trivikr

Copy link
Copy Markdown
Contributor

🔗 Linked issue

N/A

🧭 Context

Add missing translations for hi-IN

📚 Description

Add missing translations for hi-IN

@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMar 24, 2026 2:30pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMar 24, 2026 2:30pm
npmx-lunariaIgnoredIgnoredMar 24, 2026 2:30pm

Request Review

@github-actions

github-actionsBot commented Mar 24, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
i18n/locales/hi-IN.jsonLocalization changed, will be marked as complete.
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecovBot commented Mar 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request substantially expands the Hindi locale JSON by replacing many previously-empty placeholder objects with complete translation structures. New and extended keys cover footer navigation, keyboard shortcuts, search (sorting, rate limiting, instant search, Algolia notice, metadata), blog content, settings (data_source, instant search, theme/UX toggles, keyboard shortcuts), errors by HTTP status, common UI verbs, profile/package/readme/provenance/security sections, compare UI (facets, diffs, charts, table view), privacy policy, accessibility, translation status, and new top-level sections like action_bar and vacations. No code or exported/public entities were changed.

Possibly related PRs

  • fix(i18n): update Czech translations #1557 — Parallel i18n changes adding the same localization keys/structures (shortcuts, search, settings.data_source, provenance_section, security_downgrade, privacy_policy, a11y, no_dependency, etc.) in a different locale JSON file.

Suggested reviewers

  • danielroe
  • whitep4nth3r
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly states the purpose: adding missing translations for hi-IN locale, which aligns with the comprehensive expansion of Hindi locale translations in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a3facbd-379a-4543-a804-574a10b88b0c

📥 Commits

Reviewing files that changed from the base of the PR and between 1fd2d53 and 6fcb0b4.

📒 Files selected for processing (1)
  • i18n/locales/hi-IN.json

Comment threadi18n/locales/hi-IN.json Outdated
Comment threadi18n/locales/hi-IN.json Outdated

@ghostdevvghostdevv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you take a look at the code rabbit suggestions? then I can merge!

trivikrand others added 2 commits March 24, 2026 07:26
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@trivikr

Copy link
Copy Markdown
ContributorAuthor

Incorporated suggestions from Coderabbit

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
i18n/locales/hi-IN.json (1)

24-1468: ⚠️ Potential issue | 🟡 Minor

Fix missing {count} placeholder in about.contributors.title.

The token parity check against en.json found 1 mismatch: the Hindi translation of about.contributors.title is missing the {count} interpolation token present in the English version. Add the placeholder to the Hindi string to preserve pluralisation support.

🧹 Nitpick comments (1)
i18n/locales/hi-IN.json (1)

235-235: Localise the prefilled invite share text for hi-IN.

profile.invite.compose_text is still fully English, which creates a mixed-language experience in the Hindi locale.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9d9d17c3-ebf7-4171-a13e-2df288951dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 6fcb0b4 and ffc0fc7.

📒 Files selected for processing (1)
  • i18n/locales/hi-IN.json

@ghostdevv
ghostdevv added this pull request to the merge queueMar 24, 2026
Merged via the queue into npmx-dev:main with commit d80e1d2Mar 24, 2026
20 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Mar 24, 2026
@trivikr
trivikr deleted the hi-IN branch March 24, 2026 15:48
ghostdevv pushed a commit that referenced this pull request Mar 29, 2026
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@trivikr@ghostdevv