Uh oh!
There was an error while loading. Please reload this page.
chore: improve externals configuration in chromatic - #2261
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request modifies the 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cylewaitforit
left a comment
There was a problem hiding this comment.
Thanks @JReinhold !
I had to move the theme out of uno.config.ts in #2252. So depending on if this merges before or after I will probably add uno.theme.ts to this array soon. I think we would want to bust cache on changes to either file but I imagine that neither file would really change all that often though.
ad12269 to
edd9627Compare
This comment was marked as resolved.
This comment was marked as resolved.
ghostdevv
commented
Mar 24, 2026
I just merged your PR with main and added the change there! |
🔗 Linked issue
🧭 Context
To cut down on Chromatic snapshot usage, we're trying to be more aggressive about not cache busting as often. Currently changes to
nuxt.config.tsandapp/assets/main.cssaccounts for over 5000 snapshots a week, which are most likely not necessary.If we see that the cache is now busted to rarely, we can continue iterating on this.
📚 Description