Uh oh!
There was an error while loading. Please reload this page.
feat: new og images - #2292
Conversation
# Conflicts: # nuxt.config.ts # pnpm-lock.yaml
ghostdevv
left a comment
There was a problem hiding this comment.
a few more things 😅 code rabbit also has a couple things unresolved
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| defineOgImageComponent('Package', { | ||
| name: () => packageName.value, | ||
| version: () => requestedVersion.value ?? '', |
There was a problem hiding this comment.
was removing the ?? '' intentional?
There was a problem hiding this comment.
Yes, null should be passed for a missing version not an empty string (which is handled by Nuxt islands automatically when nullish value is passed).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| expect(component.text()).toContain('test') | ||
| expect(component.text()).toContain('repo') |
Uh oh!
There was an error while loading. Please reload this page.
| content: { | ||
| pipeline: { | ||
| exclude: [ | ||
| // Preserve the UnoCSS defaults that @unocss/nuxt normally sets |
There was a problem hiding this comment.
Because we're redefining the config, you'd have to look at the unocss module internals to know more.
I think these changes have been implemented
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Daniel Roe <daniel@roe.dev> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
🔗 Linked issue
#1654
🧭 Context
The previous PR was rolled back due to some Takumi stability issues. These are now solved afaik and OG Image got a v6 stable release so it's a good time to reintroduce it. (Takumi is v1 beta now so also likely stable very soon)
📚 Description
Same as before, I've resynced the UI to match recent branding changes.
sample - check PR files for more
https://npmx.dev/

https://npmx.dev/accessibility

https://npmx.dev/blog/alpha-release

https://npmx.dev/package/@nuxt/kit

https://npmx.dev/package-docs/ufo/v/1.6.3

Supersedes #2122 (rebased on latest main with CI fixes).