Skip to content

fix(i18n): add missing norwegian nb-NO translations - #2293

Merged
ghostdevv merged 2 commits into
npmx-dev:mainfrom
bonsak:feat/update-norwegian-translation
Mar 27, 2026
Merged

fix(i18n): add missing norwegian nb-NO translations#2293
ghostdevv merged 2 commits into
npmx-dev:mainfrom
bonsak:feat/update-norwegian-translation

Conversation

@bonsak

Copy link
Copy Markdown
Contributor

🧭 Context

Norwegian translation was missing several 100 keys compared to the English one.

📚 Description

Translated missing keys in the Norwegian translation

First pass of translation done with Opus 4.5
Second pass roof read by me.

@vercel

vercelBot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devReadyReadyPreview, CommentMar 27, 2026 0:10am
npmx.devReadyReadyPreview, CommentMar 27, 2026 0:10am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
npmx-lunariaIgnoredIgnoredMar 27, 2026 0:10am

Request Review

@github-actions

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
i18n/locales/nb-NO.jsonLocalization changed, will be marked as complete.
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai

coderabbitaiBot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request expands the Norwegian Bokmål localisation file (nb-NO.json) by populating previously-empty placeholder objects with comprehensive translation strings. The changes add and complete translations across numerous application areas, including blog content, package information, accessibility features, keyboard shortcuts, privacy policies, instant search functionality, and various UI controls. The modification involves adding 588 lines whilst removing 69 lines from the existing locale file.

Possibly related PRs

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly relates to the changeset, explaining that Norwegian translations for several hundred missing keys have been added to the localization file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecovBot commented Mar 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
i18n/locales/nb-NO.json (1)

1-1521: Consider adding an automated placeholder-parity check in CI for locale PRs.

Given the size of this translation delta, a lightweight script that compares placeholder tokens per key against the reference locale would prevent accidental runtime interpolation drift in future updates.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 04c7753b-e019-4a0f-a3b2-00a8d98ac02f

📥 Commits

Reviewing files that changed from the base of the PR and between 3d42fbf and b89a330.

📒 Files selected for processing (1)
  • i18n/locales/nb-NO.json

@ghostdevvghostdevv changed the title fix(i18n): update norwegian translationfix(i18n): add missing norwegian nb-NO translationsMar 27, 2026
@ghostdevv
ghostdevv added this pull request to the merge queueMar 27, 2026
Merged via the queue into npmx-dev:main with commit 5eb8fd4Mar 27, 2026
21 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Mar 27, 2026
@bonsak
bonsak deleted the feat/update-norwegian-translation branch March 27, 2026 18:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bonsak@ghostdevv