Skip to content

fix: typo in chart config attribute - #2328

Merged
graphieros merged 1 commit into
mainfrom
typo-in-facetbarchart-config
Mar 30, 2026
Merged

fix: typo in chart config attribute#2328
graphieros merged 1 commit into
mainfrom
typo-in-facetbarchart-config

Conversation

@graphieros

@graphierosgraphieros commented Mar 30, 2026

Copy link
Copy Markdown
Member

Resolves#2327

An attribute was misspelled in FacetBarChart.vue's configuration object, silently ignored because the type is very permissive.

@graphierosgraphieros linked an issue Mar 30, 2026 that may be closed by this pull request
@vercel

vercelBot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMar 30, 2026 11:15am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredMar 30, 2026 11:15am
npmx-lunariaIgnoredIgnoredMar 30, 2026 11:15am

Request Review

@codecov

codecovBot commented Mar 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The change updates a configuration key in the FacetBarChart component. Specifically, userOptions.buttonTitle was replaced with userOptions.buttonTitles in the VueUiHorizontalBar chart configuration. The translation values for img, svg, and altCopy remain the same. No modifications were made to chart logic, rendering, datasets, callbacks, or control flow. The change affects only the internal component configuration.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedThe code change directly addresses the objective from issue #2327 by correcting the property name from userOptions.buttonTitle to userOptions.buttonTitles in FacetBarChart.vue.
Out of Scope Changes check✅ PassedThe pull request contains only the necessary change to fix the typo, with no additional modifications outside the scope of issue #2327.
Description check✅ PassedThe pull request description clearly relates to the changeset, explaining the typo fix in FacetBarChart.vue configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch typo-in-facetbarchart-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@graphierosgraphieros changed the title fix: typofix: typo in chart config attributeMar 30, 2026
@graphieros
graphieros requested a review from a teamMarch 30, 2026 11:18
@graphieros
graphieros added this pull request to the merge queueMar 30, 2026
@graphieros
graphieros removed this pull request from the merge queue due to a manual request Mar 30, 2026
@graphieros
graphieros added this pull request to the merge queueMar 30, 2026
Merged via the queue into main with commit b3da028Mar 30, 2026
26 checks passed
@graphieros
graphieros deleted the typo-in-facetbarchart-config branch March 30, 2026 12:43
@github-actionsgithub-actionsBot mentioned this pull request Mar 30, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in FacetBarChart config

2 participants

@graphieros@TheAlexLichter