Skip to content

fix: correct code colors - #2362

Merged
alexdln merged 1 commit into
npmx-dev:mainfrom
alexdln:fix/correct-code-colors
Apr 3, 2026
Merged

fix: correct code colors#2362
alexdln merged 1 commit into
npmx-dev:mainfrom
alexdln:fix/correct-code-colors

Conversation

@alexdln

Copy link
Copy Markdown
Member

🧭 Context

Missed one rule on revert :(

So final touch, checked everything else and now that's all

@vercel

vercelBot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentApr 2, 2026 11:23am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewApr 2, 2026 11:23am
npmx-lunariaIgnoredIgnoredApr 2, 2026 11:23am

Request Review

@codecov

codecovBot commented Apr 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7166a654-4d9c-4e2c-9f75-c1084b1bf3d1

📥 Commits

Reviewing files that changed from the base of the PR and between d3f60cb and 1864b2b.

📒 Files selected for processing (1)
  • app/assets/main.css

📝 Walkthrough

Walkthrough

The pull request modifies CSS selectors in the main stylesheet to refine the Shiki syntax-highlighting theme application. The selector scope for light theme styling was narrowed from a global rule to a light-specific rule, restricting when foreground and background colour properties apply. A blank line was also added to a media-contrast block. The changes affect only CSS selector specificity and formatting, with no alterations to exported declarations.

Possibly related PRs

Suggested labels

front

Suggested reviewers

  • RamaHerbin
  • danielroe
  • graphieros
🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 inconclusive)

Check nameStatusExplanationResolution
Description check❓ InconclusiveThe description is vague and non-descriptive, using informal language like 'Missed one rule on revert' and 'final touch' without clearly conveying what changes were made.Provide a more detailed description explaining what CSS rule was missed, why it needed correction, and how the light/dark theme selector change improves code colour handling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@graphierosgraphieros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should've seen it too

@alexdln
alexdln added this pull request to the merge queueApr 3, 2026
Merged via the queue into npmx-dev:main with commit 1d1f450Apr 3, 2026
21 checks passed
@alexdln
alexdln deleted the fix/correct-code-colors branch April 3, 2026 11:19
@github-actionsgithub-actionsBot mentioned this pull request Apr 3, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexdln@graphieros