Skip to content

refactor: use useVisibleItems in DeprecatedTree - #2399

Merged
serhalp merged 1 commit into
mainfrom
jg/visible-depretreetions
Apr 6, 2026
Merged

refactor: use useVisibleItems in DeprecatedTree#2399
serhalp merged 1 commit into
mainfrom
jg/visible-depretreetions

Conversation

@43081j

Copy link
Copy Markdown
Contributor

🔗 Linked issue

N/A

🧭 Context

Part of migrating to the new useVisibleItems composable.

📚 Description

Switches the deprecated notice to use the new useVisibleItems
composable.

Switches the deprecated notice to use the new `useVisibleItems`
composable.
@vercel

vercelBot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentApr 6, 2026 0:51am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredApr 6, 2026 0:51am
npmx-lunariaIgnoredIgnoredApr 6, 2026 0:51am

Request Review

@codecov

codecovBot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e6b7b0f4-2b32-46d9-ac7a-230b97c54b9c

📥 Commits

Reviewing files that changed from the base of the PR and between 68abc5d and 929903c.

📒 Files selected for processing (1)
  • app/components/Package/DeprecatedTree.vue

📝 Walkthrough

Walkthrough

The DeprecatedTree.vue component has been refactored to replace its manual pagination logic with a useVisibleItems composable-driven mechanism. Previously, the component directly sliced the deprecated packages array and conditionally showed a "show all" button based on whether the list exceeded five items. The update now renders visibleItems derived from analysisData.deprecatedPackages with a fixed page size of five, uses a hasMorePackages condition for the button visibility, and triggers an expandPackages function instead of mutating the showAll state directly.

Possibly related PRs

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly relates to the changeset, explaining the migration to the new useVisibleItems composable in the DeprecatedTree component.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg/visible-depretreetions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@serhalp
serhalp added this pull request to the merge queueApr 6, 2026
Merged via the queue into main with commit a2948d7Apr 6, 2026
24 checks passed
@serhalp
serhalp deleted the jg/visible-depretreetions branch April 6, 2026 22:51
@github-actionsgithub-actionsBot mentioned this pull request Apr 6, 2026
@serhalpserhalp changed the title feat: use useVisibleItems in DeprecatedTreerefactor: use useVisibleItems in DeprecatedTreeApr 7, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@43081j@serhalp