Skip to content

refactor: use useVisibleItems in vulnerability tree - #2405

Merged
serhalp merged 1 commit into
mainfrom
jg/visible-voolnerabools
Apr 7, 2026
Merged

refactor: use useVisibleItems in vulnerability tree#2405
serhalp merged 1 commit into
mainfrom
jg/visible-voolnerabools

Conversation

@43081j

Copy link
Copy Markdown
Contributor

🔗 Linked issue

N/A

🧭 Context

Part of moving to the useVisibleItems composable.

📚 Description

Switches the vulnerability tree to use the new useVisibleItems
composable.

Switches the vulnerability tree to use the new `useVisibleItems`
composable.
@vercel

vercelBot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentApr 7, 2026 8:56am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredApr 7, 2026 8:56am
npmx-lunariaIgnoredIgnoredApr 7, 2026 8:56am

Request Review

@codecov

codecovBot commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b09a2065-e73f-4cff-a53e-ab8911a9c9fb

📥 Commits

Reviewing files that changed from the base of the PR and between 15b53bf and fef1f6b.

📒 Files selected for processing (1)
  • app/components/Package/VulnerabilityTree.vue

📝 Walkthrough

Walkthrough

The VulnerabilityTree.vue component was refactored to replace its local showAllPackages state and manual array slicing with the useVisibleItems composable. The component now uses visiblePackages directly for rendering and controls the "show all packages" button visibility and behaviour through the composable's hasMorePackages and expandPackages properties instead of a boolean toggle mechanism.

Possibly related PRs

Suggested reviewers

  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description accurately describes the changeset, explaining the migration to useVisibleItems composable in the vulnerability tree.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg/visible-voolnerabools

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevv

Copy link
Copy Markdown
Member

@43081j what's an easy way to test this?

@43081j

Copy link
Copy Markdown
ContributorAuthor

https://npmxdev-git-jg-visible-voolnerabools-npmx.vercel.app/package/gulp/v/2.7.0

this one shows it under the vulnerabilities box. you can expand some of them that have many vulnerabilities.

@serhalpserhalp changed the title feat: use useVisibleItems in vulnerability treerefactor: use useVisibleItems in vulnerability treeApr 7, 2026
@serhalp
serhalp added this pull request to the merge queueApr 7, 2026
Merged via the queue into main with commit 24ce294Apr 7, 2026
25 checks passed
@serhalp
serhalp deleted the jg/visible-voolnerabools branch April 7, 2026 17:39
@github-actionsgithub-actionsBot mentioned this pull request Apr 7, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@43081j@ghostdevv@serhalp