Skip to content

refactor: use new pnpm allowBuilds setting - #2407

Merged
ghostdevv merged 1 commit into
npmx-dev:mainfrom
btea:chore/use-allowBuilds
Apr 7, 2026
Merged

refactor: use new pnpm allowBuilds setting#2407
ghostdevv merged 1 commit into
npmx-dev:mainfrom
btea:chore/use-allowBuilds

Conversation

@btea

@bteabtea commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

🧭 Context

📚 Description

https://pnpm.io/settings#allowbuilds

Replace onlyBuiltDependencies and ignoredBuiltDependencies with allowBuilds.

@vercel

vercelBot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devReadyReadyPreview, CommentApr 7, 2026 10:03am
npmx.devReadyReadyPreview, CommentApr 7, 2026 10:03am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
npmx-lunariaIgnoredIgnoredApr 7, 2026 10:03am

Request Review

@codecov

codecovBot commented Apr 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 859fc65f-4cde-4a64-b109-11410ba23878

📥 Commits

Reviewing files that changed from the base of the PR and between 15b53bf and 90c47cf.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

The pnpm-workspace.yaml configuration file has been updated to replace the separate ignoredBuiltDependencies and onlyBuiltDependencies settings with a unified allowBuilds map. This map explicitly defines build permissions for eight dependencies: @resvg/resvg-js, better-sqlite3, and sharp@0.34.5 are permitted to build, whilst @parcel/watcher, core-js, esbuild, unrs-resolver, and vue-demi are prevented from building. The remaining workspace configuration remains unchanged.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description directly addresses the changeset, explaining the replacement of deprecated pnpm configuration keys with the new allowBuilds setting.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevvghostdevv changed the title chore: use allowBuildsrefactor: use new pnpm allowBuilds settingApr 7, 2026
@ghostdevv
ghostdevv added this pull request to the merge queueApr 7, 2026
Merged via the queue into npmx-dev:main with commit 96dd69fApr 7, 2026
22 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Apr 7, 2026
@btea
btea deleted the chore/use-allowBuilds branch April 7, 2026 14:54
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@btea@ghostdevv