Skip to content

chore: update artemis noodle range - #2424

Merged
serhalp merged 1 commit into
npmx-dev:mainfrom
alexdln:chore/update-noodle-range
Apr 8, 2026
Merged

chore: update artemis noodle range#2424
serhalp merged 1 commit into
npmx-dev:mainfrom
alexdln:chore/update-noodle-range

Conversation

@alexdln

@alexdlnalexdln commented Apr 8, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

Increased visible time for artemis noodle

@vercel

vercelBot commented Apr 8, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentApr 8, 2026 6:47pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredApr 8, 2026 6:47pm
npmx-lunariaIgnoredIgnoredApr 8, 2026 6:47pm

Request Review

@coderabbitai

coderabbitaiBot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The changes extend the noodle feature to support date ranges. The Noodle type in app/components/Noodle/index.ts now includes an optional dateTo field alongside the existing date field. The active noodle selection logic in app/components/Landing/IntroHeader.vue has been updated to perform range matching when a dateTo value is present, whilst maintaining single-date matching for noodles without an end date. The artemis noodle entry has been configured with a start and end date window.

Possibly related PRs

  • feat: noodles #2421: Introduces the noodle feature that this PR extends by adding date range support and updating the filtering logic within the same type and code paths.

Suggested reviewers

  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description directly relates to the changeset, which updates the artemis noodle's date range to increase its visible time window.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitaiBot reviewed Apr 8, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 400b8a14-77f3-43e3-8905-7f88747f3520

📥 Commits

Reviewing files that changed from the base of the PR and between ed72177 and 19936e3.

📒 Files selected for processing (2)
  • app/components/Landing/IntroHeader.vue
  • app/components/Noodle/index.ts

Comment threadapp/components/Landing/IntroHeader.vue
Comment threadapp/components/Noodle/index.ts
@codecov

codecovBot commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@serhalp
serhalp added this pull request to the merge queueApr 8, 2026
Merged via the queue into npmx-dev:main with commit ad7b241Apr 8, 2026
24 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Apr 8, 2026
Merged
Adebesin-Cell added a commit to Adebesin-Cell/npmx.dev that referenced this pull request May 22, 2026
@Adebesin-Cell
feat(noodles): restore artemis, drop query-param trigger, fix bowl mo…
1c4eb7f
…on blend
- Restore the artemis noodle from npmx PR npmx-dev#2421/npmx-dev#2424. The light/dark
SVGs were already in public/extra/; the SFC was removed when press
was added. Registered in Noodle/index.ts and app/noodles.ts with the
original April 2026 date range.
- Drop the `?<key>` query-param branch from IntroHeader — all noodles
are historical now, so activation is purely date-based.
- Match Kawaii's hover/scale animation on Press, so all three noodles
feel consistent on the homepage.
- Remove the press-day tooltip — it leaks into the /noodles archive
card on hover.
- Bowl moon image was showing its black/white rectangle background in
the bowl on /noodles. Add `mix-blend-lighten light:mix-blend-darken`
so it dissolves into the bowl bg in both themes (same trick the
artemis logo uses).
- Stamp prUrl on press + artemis so their cards link to the shipping PR.
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
@alexdln@ayo-run
chore: update artemis noodle range (npmx-dev#2424)
7320fe0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@patak-catpatak-catpatak-cat approved these changes
@serhalpserhalpserhalp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexdln@patak-cat@serhalp