Skip to content

chore: update vp and fix precommit - #2433

Closed
alexdln wants to merge 5 commits into
npmx-dev:mainfrom
alexdln:chore/update-vp
Closed

chore: update vp and fix precommit#2433
alexdln wants to merge 5 commits into
npmx-dev:mainfrom
alexdln:chore/update-vp

Conversation

@alexdln

Copy link
Copy Markdown
Member

🧭 Context

The previous version of vite-plus it didn't (or didn't always) support the pre-commit configuration logic, so it stopped working for many contributors.

Updated the version and also corrected hooks description in contributing.md

@vercel

vercelBot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devReadyReadyPreview, CommentApr 9, 2026 10:25am
npmx.devErrorErrorApr 9, 2026 10:25am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
npmx-lunariaIgnoredIgnoredApr 9, 2026 10:25am

Request Review

@coderabbitai

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request migrates the repository's pre-commit hook configuration from the separate lint-staged and simple-git-hooks tooling to vite-plus. The changes include adding a new pre-commit hook file that runs vp staged, updating the documentation to reflect the new tooling approach, and bumping the vite-plus dependency from version 0.1.12 to 0.1.16 in the package manifest.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe description accurately explains the context and purpose of the changes: updating vite-plus version to fix pre-commit support and correcting documentation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a910bdd-1526-4788-81b3-af98ec560a03

📥 Commits

Reviewing files that changed from the base of the PR and between 57687cc and e2d13dc.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .vite-hooks/pre-commit
  • CONTRIBUTING.md
  • package.json

Comment threadCONTRIBUTING.md
@alexdln

Copy link
Copy Markdown
MemberAuthor

I can't seem to figure out the error yet, I'll try to return to it later (or hopefully someone else can solve it)

@ghostdevv

Copy link
Copy Markdown
Member

cc: @fengmk2

@fengmk2

Copy link
Copy Markdown
Contributor

Let me try

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alexdln@ghostdevv@fengmk2