Skip to content

ci: revert "ci: auto-remove needs review label when PR is reviewed" - #2440

Merged
ghostdevv merged 1 commit into
mainfrom
revert-2402-ci/remove-needs-review-label-on-pr-review
Apr 9, 2026
Merged

ci: revert "ci: auto-remove needs review label when PR is reviewed"#2440
ghostdevv merged 1 commit into
mainfrom
revert-2402-ci/remove-needs-review-label-on-pr-review

Conversation

@serhalp

Copy link
Copy Markdown
Member

Reverts #2402

It fails on fork PRs... of course, because it doesn't have permission to remove labels.

Reverting while I think about an alternative approach.

@vercel

vercelBot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentApr 9, 2026 5:13pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredApr 9, 2026 5:13pm
npmx-lunariaIgnoredIgnoredApr 9, 2026 5:13pm

Request Review

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 01ee2724-3f96-4377-b251-e1b8a13e8f4d

📥 Commits

Reviewing files that changed from the base of the PR and between c93d9b0 and 8736bd9.

📒 Files selected for processing (1)
  • .github/workflows/remove-needs-review-on-review.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/remove-needs-review-on-review.yml

📝 Walkthrough

Walkthrough

This PR removes the .github/workflows/remove-needs-review-on-review.yml GitHub Actions workflow file. The workflow previously automated the removal of the "needs review" label from pull requests upon review submission. It executed only when triggered by pull request review events and validated that the reviewer possessed appropriate repository permissions (admin, maintain, or write access) before removing the label.

Possibly related PRs

Suggested reviewers

  • 43081j
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly explains the revert of PR #2402 and provides the reason: the workflow fails on fork PRs due to lack of label removal permissions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-2402-ci/remove-needs-review-label-on-pr-review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecovBot commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv
ghostdevv added this pull request to the merge queueApr 9, 2026
Merged via the queue into main with commit 5a2b1a6Apr 9, 2026
24 checks passed
@ghostdevv
ghostdevv deleted the revert-2402-ci/remove-needs-review-label-on-pr-review branch April 9, 2026 17:20
@github-actionsgithub-actionsBot mentioned this pull request Apr 9, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@serhalp@ghostdevv